Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 30 2019 20:42
    timja commented #56
  • Jan 30 2019 20:32
    imaffe commented #56
  • Jan 30 2019 18:34
    imaffe commented #56
  • Jan 29 2019 11:58
    martinda commented #56
  • Jan 29 2019 07:07
    imaffe commented #56
  • Jan 28 2019 18:35
    imaffe synchronize #56
  • Jan 28 2019 14:28
  • Jan 26 2019 14:50
    martinda commented #56
  • Jan 26 2019 08:28
    imaffe commented #56
  • Jan 26 2019 08:20
    imaffe commented #56
  • Jan 22 2019 16:33
  • Jan 19 2019 17:48
    imaffe commented #56
  • Jan 19 2019 10:52
    oleg-nenashev commented #56
  • Jan 19 2019 04:42
    imaffe commented #56
  • Jan 19 2019 04:31
    imaffe synchronize #56
  • Jan 19 2019 03:38
    imaffe commented #56
  • Jan 19 2019 03:32
    imaffe commented #56
  • Jan 17 2019 07:20
    alexsomai closed #58
  • Jan 17 2019 06:32
    imaffe commented #51
  • Jan 17 2019 03:46
    imaffe synchronize #56
Martin d'Anjou
@martinda
Which room? There is a room with the hangout email invite and there is the general one.
@hynespm link for meeting ^
affe
@imaffe
@martinda I'll go to the company first, and see if I can send the email around noon.
Thanks @martinda @alexsomai
affe
@imaffe
@martinda Needs some help ~ Should I send to dev-public or gsoc-public , how do I include CNCF sig in the mailing list ?
Martin d'Anjou
@martinda
Start with jenkins-gsoc-all, and notify Oleg here with a mention once your have the link.
affe
@imaffe

Hi All,

This is Yufei, student for GSoC 2019 Cloud Features for External Workspace Manger. We might need to change the plan of our original proposal. There are some important updates to share with you.

What we've done :

  1. I implemented the 1st iteration in EWM to make it support AWS EFS, and currently working fine.

But we discovered :

  1. Our initial design couples EFS with EWM, and creating/managing EFS should not be within the responsibility of a specific-purpose plugin.
  2. User might not want to use our cloud feature since it looks useless, as such task can be done by IaaC tools like CloudFormation and Terraform
  3. Continuing on our initial plan might get GSoC done, but doing no good to our community.

Then we decide to :

  1. decouple EFS related functionality with EWM, by creating a new plugin for EFS only, make Jenkins able to manage EFS as user defines.
  2. Migrate 1st coding phase code to the new plugin, so the new plugin won't need writing code from scratch.
  3. Release documents about the new plugin, and focus on the new plugin in the rest of our coding periods.

If you have any comments and suggestions, please let us know. We really need feedbacks from the community, and we will keep on working.
Thanks !

Yufei Zhang.

This is the draft email, does it look good ?
Martin d'Anjou
@martinda
Looks good to me.
Alexandru Somai
@alexsomai
Looks good to me, as well 👍
Patrick Hynes
@hynespm
Just catching up on this, saw the email. Looked good.
affe
@imaffe
@martinda @alexsomai Well, now I created a draft plugin using maven, but I'm not sure whether it is well-named. If possible, can you create a github repo for me (with just a basic plugin structure), thanks so much.
affe
@imaffe
I created one, but not an official one.
Martin d'Anjou
@martinda
@imaffe for new plugin hosting request see https://jenkins.io/doc/developer/publishing/requesting-hosting/
Martin d'Anjou
@martinda
@imaffe I do not have sufficient permissions to create a repository in the jenkinsci organization. That's why you should open a ticket, so infra people can create one for you.
affe
@imaffe
@martinda I went to hospital today, so didn't reply asap. Yeah tonight I'm going to create new tickets and try to build a sample plugin.
affe
@imaffe
@alexsomai Hi Alex, do you know where is the tutorial for developing a pipeline step plugin ? I remember I saw it before, but couldn't find it now.
Alexandru Somai
@alexsomai
@imaffe Hi Yufei, I think this is what you were looking for https://jenkins.io/doc/developer/plugin-development/pipeline-integration/
and Defining Symbols is where you actually name your step: https://jenkins.io/doc/developer/plugin-development/pipeline-integration/#defining-symbols
affe
@imaffe
Hi Martin, can anyone see the hangout link of the invitation I just sent ?
Martin d'Anjou
@martinda
I though you would only invite the people who responded to the doodle. But there is a lot more people than that in the invite.
@imaffe I would keep the invite to the list of people on the doodle.
affe
@imaffe
Well, I thought Oleg means, every one can come if they want.
Martin d'Anjou
@martinda
So usually we send the invite to the people on the doodle, and we post the link to gitter when the meeting starts.
affe
@imaffe
Sorry, I think there is no turning back right.
Martin d'Anjou
@martinda
I think you can send a meeting cancellation, then resend an invitation, or "uninvite" people.
affe
@imaffe
I cannot see Tim Jacomb's email, should we notice him when the meeting begins ?
Oleg Nenashev
@oleg-nenashev

Well, I thought Oleg means, every one can come if they want.

Taking the public announcements, I believe it is going to happen in such way now

I was really asking for a private meeting and provate discussions until we are ready to announce that. But is obviously too late. Let's proceed in public as much as possible
Martin d'Anjou
@martinda
@imaffe can you please create a pull-request so we can review the blog post?
Oh, just saw it.
affe
@imaffe
@oleg-nenashev @martinda @alexsomai Hi Alex, got a problem about decriptor and its outer class, e.g. DiskPool : https://github.com/jenkinsci/external-workspace-manager-plugin/blob/master/src/main/java/org/jenkinsci/plugins/ewm/definitions/DiskPool.java , what's the difference of putting fields in the outer class and putting fields in the decriptor class ? in here : https://github.com/jenkinsci/configuration-as-code-plugin/blob/master/docs/PLUGINS.md the FooBar class has charset and password fields in the decriptor, but for Authentication class the fields are just defined in the outer class. I understand it as, only those appear in top level Web UI will put fields in descriptor together with a configure() method, and all its child components doesn't need to do that.
@martinda My JIRA again won't show the tickets I created.. It is not in the backlog as well, can you please take a look what's happening ?
Alexandru Somai
@alexsomai
@imaffe I don't remember exactly why I did that, maybe I was wrong. So you are saying that the fields from DiskPool class should have been in the descriptor, right? because all of them are shown in the Web UI. I think it will be quite tricky to change that now ...
also, I don't know why I've put the DescriptorImpl as inner class of DiskPool:(. More appropriate would have been to place it as outer class.
Martin d'Anjou
@martinda
@imaffe For the Jira, the reason they do not show is because they are missing the label gsoc-2019 in the "Labels" field. I added that label to the two issues and the one epic.
They now all show on the board.
affe
@imaffe
@alexsomai No, DiskPoolshould not put fields in descriptor, the initial code is right. Only three class needs to put fields to descriptor : ExwsStep, ExwsAllocateStep and ExternalWorkspaceProperty because they are the entry of WebUI. (Not sure, but will ask in the public email)
@hynespm Hi Patrick, there is a blog post PR needs review : jenkins-infra/jenkins.io#2323, Thanks ~
Alexandru Somai
@alexsomai
@imaffe @martinda I'll be on vacation starting tomorrow, for 1 week. Therefore, I'll be only available to briefly answer here in the chat, or on the e-mail. I won't be able to make code reviews & stuff.
Martin d'Anjou
@martinda
Thanks for letting us know. Have a good vacation.
Alexandru Somai
@alexsomai
thanks!
affe
@imaffe
Have a good vacation !
Alexandru Somai
@alexsomai
Thank you 👍
affe
@imaffe
@martinda Hi Martin, do you know how did Alex managed to access agents before we started JCasC compatibility refactor ? e.g Here in : https://github.com/imaffe/external-workspace-manager-plugin/blob/9d342da7a467d775e8106957b8e0006f7a9eb9d9/src/test/java/org/jenkinsci/plugins/ewm/nodes/ConfigMigrationTest.java#L41, Where did that "node1" come from ?
@imaffe ^