Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 30 2019 20:42
    timja commented #56
  • Jan 30 2019 20:32
    imaffe commented #56
  • Jan 30 2019 18:34
    imaffe commented #56
  • Jan 29 2019 11:58
    martinda commented #56
  • Jan 29 2019 07:07
    imaffe commented #56
  • Jan 28 2019 18:35
    imaffe synchronize #56
  • Jan 28 2019 14:28
  • Jan 26 2019 14:50
    martinda commented #56
  • Jan 26 2019 08:28
    imaffe commented #56
  • Jan 26 2019 08:20
    imaffe commented #56
  • Jan 22 2019 16:33
  • Jan 19 2019 17:48
    imaffe commented #56
  • Jan 19 2019 10:52
    oleg-nenashev commented #56
  • Jan 19 2019 04:42
    imaffe commented #56
  • Jan 19 2019 04:31
    imaffe synchronize #56
  • Jan 19 2019 03:38
    imaffe commented #56
  • Jan 19 2019 03:32
    imaffe commented #56
  • Jan 17 2019 07:20
    alexsomai closed #58
  • Jan 17 2019 06:32
    imaffe commented #51
  • Jan 17 2019 03:46
    imaffe synchronize #56
affe
@imaffe
I cannot see Tim Jacomb's email, should we notice him when the meeting begins ?
Oleg Nenashev
@oleg-nenashev

Well, I thought Oleg means, every one can come if they want.

Taking the public announcements, I believe it is going to happen in such way now

I was really asking for a private meeting and provate discussions until we are ready to announce that. But is obviously too late. Let's proceed in public as much as possible
Martin d'Anjou
@martinda
@imaffe can you please create a pull-request so we can review the blog post?
Oh, just saw it.
affe
@imaffe
@oleg-nenashev @martinda @alexsomai Hi Alex, got a problem about decriptor and its outer class, e.g. DiskPool : https://github.com/jenkinsci/external-workspace-manager-plugin/blob/master/src/main/java/org/jenkinsci/plugins/ewm/definitions/DiskPool.java , what's the difference of putting fields in the outer class and putting fields in the decriptor class ? in here : https://github.com/jenkinsci/configuration-as-code-plugin/blob/master/docs/PLUGINS.md the FooBar class has charset and password fields in the decriptor, but for Authentication class the fields are just defined in the outer class. I understand it as, only those appear in top level Web UI will put fields in descriptor together with a configure() method, and all its child components doesn't need to do that.
@martinda My JIRA again won't show the tickets I created.. It is not in the backlog as well, can you please take a look what's happening ?
Alexandru Somai
@alexsomai
@imaffe I don't remember exactly why I did that, maybe I was wrong. So you are saying that the fields from DiskPool class should have been in the descriptor, right? because all of them are shown in the Web UI. I think it will be quite tricky to change that now ...
also, I don't know why I've put the DescriptorImpl as inner class of DiskPool:(. More appropriate would have been to place it as outer class.
Martin d'Anjou
@martinda
@imaffe For the Jira, the reason they do not show is because they are missing the label gsoc-2019 in the "Labels" field. I added that label to the two issues and the one epic.
They now all show on the board.
affe
@imaffe
@alexsomai No, DiskPoolshould not put fields in descriptor, the initial code is right. Only three class needs to put fields to descriptor : ExwsStep, ExwsAllocateStep and ExternalWorkspaceProperty because they are the entry of WebUI. (Not sure, but will ask in the public email)
@hynespm Hi Patrick, there is a blog post PR needs review : jenkins-infra/jenkins.io#2323, Thanks ~
Alexandru Somai
@alexsomai
@imaffe @martinda I'll be on vacation starting tomorrow, for 1 week. Therefore, I'll be only available to briefly answer here in the chat, or on the e-mail. I won't be able to make code reviews & stuff.
Martin d'Anjou
@martinda
Thanks for letting us know. Have a good vacation.
Alexandru Somai
@alexsomai
thanks!
affe
@imaffe
Have a good vacation !
Alexandru Somai
@alexsomai
Thank you 👍
affe
@imaffe
@martinda Hi Martin, do you know how did Alex managed to access agents before we started JCasC compatibility refactor ? e.g Here in : https://github.com/imaffe/external-workspace-manager-plugin/blob/9d342da7a467d775e8106957b8e0006f7a9eb9d9/src/test/java/org/jenkinsci/plugins/ewm/nodes/ConfigMigrationTest.java#L41, Where did that "node1" come from ?
@imaffe ^
affe
@imaffe
Thanks ~
Oleg Nenashev
@oleg-nenashev
What is the plan for the next steps? Any plans to update the website and so on?
affe
@imaffe
Website you mean Jenkins.io ? Yes.
affe
@imaffe
@martinda Hi Martin, can you send the meeting link to Tim as he only get links from gitter. I cannot see the hangout link in the calendar ..
Martin d'Anjou
@martinda
@imaffe Done. Tim should have it. Click ONE TIME on the calendar item, not twice. Then you see the hangout link.
I sent it to Tim just a minute ago.
bharat4544
@bharat4544
Can anyone help in setting up "external_workspace_manager_plugin"?
Alexandru Somai
@alexsomai
hi @bharat4544, I saw your email with the issue that you are facing. I'll try to answer you there.
bharat4544
@bharat4544
Thanks @alexsomai Would really appreciate your help in this regard
Martin d'Anjou
@martinda
Hi @bharat4544 , I can help too but I do not see your question.
Alexandru Somai
@alexsomai
hi @martinda. Are you ok if I add you to the email thread where @bharat4544 sent me details with his issue? Maybe you have o good insight on this, because I can't find the root cause
Martin d'Anjou
@martinda
Yes sure @alexsomai
I will try to look at it tonight.
Alexandru Somai
@alexsomai
thanks. no worries, when you have time. the configs seems to be set correctly (you'll see in the email), so not sure what's wrong :(
bharat4544
@bharat4544
Thanks for looking into this @alexsomai @martinda
Martin d'Anjou
@martinda
@bharat4544 Not sure why you are having trouble, I did not have a deep look, but in my case I use the "External Workspace Templates" under the Global config and no "per-node" configuration. I set the node label to match between the "EW Templates" and the node definition. The Jenkinsfile also matches the same node label name node("the_node_label") { ... }. Unfortunately I am swamped these days.
bharat4544
@bharat4544
Hi @martinda I have tried that as well but it doesn't help much. Problem is the node making a reference to individual path rather than shared workspace path as shown in the log. Will keep trying and update if i get anywhere further progress. Thanks
Martin d'Anjou
@martinda
I am reviewing PR #68 it might take a while, I want to check many things including test coverage.
Benjamin Beggs
@BenjaminBeggs
@alexsomai do you have an intuition as to why https://github.com/jenkinsci/external-workspace-manager-plugin/pull/68#pullrequestreview-263295752 occurs? I'm unsure where the asymmetry between the unit tests and this import failure originates
Benjamin Beggs
@BenjaminBeggs
(Don't be too concerned about my above question, this issue does not seem to arise due to EWM as far as I can see right now)
@alexsomai is the Workspace Cleanup Plugin simply a recommended plugin for workspace cleanup, or is there customized compatibility for it written into the External Workspace Manager itself?
Raghunath Krishnan
@raghunathkrish_twitter
We are looking to use EWM plugin to solve our issue of sharing certain common artifacts/packages needed for builds running in any slave. Quick question: How is the network performance when using EWM? eg; when the pipeline groovy runs on a slave and enters a exws block, will this be opening a socket or something to download the workspace from the diskpool in master? correct me if I am wrong.
Alexandru Somai
@alexsomai
@BenjaminBeggs sorry, I haven't seen your first mention, not sure why I wasn't notified
yes, the cleanup plugin can be used in conjunction with EWM, but it's optional
@raghunathkrish_twitter the workspace should be downloaded only once on your common diskpool, afterwards, if you configure the plugin correctly, you should have access to that workspace via mount points to that diskpool.
Benjamin Beggs
@BenjaminBeggs
@alexsomai No worries. I am researching an update to EWM that will clear external workspaces once all builds "pointing" to it have been deleted by routine build discards. My current proposed implementation will read fingerprint build data and ask the Workspace Cleanup Plugin to clear an external workspace once no fingerprints contain a given external workspace directory. Does this implementation seem compatible with EWM processes? Are you aware if there might be an accessible point of implementation for this within the preexisting Workspace Cleanup plugin support in EWM?
Raghunath Krishnan
@raghunathkrish_twitter
@alexsomai Thanks. is the disk pool present in the master, slave or where? I mean, in reality, does the slave download the workspace from the mounted disk?