Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Mark Waite
    @MarkEWaite
    I've merged jenkins-infra/jenkins.io#4509 so that the blog post can be linked in your report @arpoch
    Harshit Chopra
    @arpoch
    @MarkEWaite , @justinharringa:matrix.org , @rishabhBudhouliya , I will be late today can we reschedule yhe meeting to 08:30 Am IST today?
    Mark Waite
    @MarkEWaite
    Rescheduling to an hour later is fine with me. Talk to you then @arpoch
    Harshit Chopra
    @arpoch
    Thanks @MarkEWaite,
    Harshit Chopra
    @arpoch
    @MarkEWaite created a PR for the changes in GSOC-21 work report-
    jenkins-infra/jenkins.io#4519
    Mark Waite
    @MarkEWaite
    Merged that PR @arpoch . Thanks!
    Harshit Chopra
    @arpoch
    @rishabhBudhouliya , could you share your presentation slides for final evaluation phase held by CDF GSoC. That could be used as a reference by me.
    Rishabh Budhouliya
    @rishabhBudhouliya
    @arpoch I know I missed it last time, but this time if you'd like to sit for sometime for reviewing your presentation, I will definitely be available. Let me know if you want to do that.
    3 replies
    Harshit Chopra
    @arpoch
    @MarkEWaite , @rishabhBudhouliya , @justinharringa:matrix.org , the link of slides for CDF-GSoC-21 final evaluation:
    https://docs.google.com/presentation/d/1oVjwKt4OsxxDWs4eY3JL6jNxi2YyY9IQNizws-EAITM/edit?usp=sharing
    Rishabh Budhouliya
    @rishabhBudhouliya
    @arpoch From a cursory view, it looks great. I know you've done great work this summer and you are directly outlining it in your presentation.
    I do have some comments which are optional and my personal opinion:
    • When I was coming up with the final presentation, I always wondered how to make the presentation more palatable to the general audience. I believe thinking like a salesman works. Make the product as simple as you can to sell it.
    • We all know you've done a project on credentials binding for the git plugin, why have you done it and what does it mean? You could mention that it the presentation intro if you'd like. Some people might not remember the motivation of the project explain during the phase 1 presentations.
    • It's hard and often times superflous, but I like to attach a bigger meaning to the project. Something along the lines of ~providing convenience to the Jenkins user~ or ~more freedom of choice to the pipeline users~.
    • Git plugin is one of the most used plugin in the ecosystem, the checkout step is probably used by everyone using a Jenkins pipeline. Even a small feature means a lot to the community, yours is a big one, sell it like that.
    Also, I think I made a mistake by naming the title of the presentation = the name of the project. Everyone knows the name of the project. The title should be what you want to sell. The meaning of the project.
    1 reply
    Justin Harringa
    @justinharringa:matrix.org
    [m]
    On the road ahead you mention "test units" where I think you mean to say "unit tests" but I could be misunderstanding intent 😃
    2 replies
    Harshit Chopra
    @arpoch

    @MarkEWaite , @justinharringa:matrix.org , @rishabhBudhouliya , I dont know why I didn't gave attention to this before even though I knew that it was coming. The Github support for password authentication has been completely discontinued, although I am using gitlab vcs now to demo my project work.

    As developer I am curious to know that does Jenkins credentials Plugin support access Token, from what I have investigated it dose not, I have seen workarounds of using Username/Password credential as access token.

    I think the Username and Password binding should include support for access tokens since password based auth are not that secure and seems to be deprecated in the coming future.

    3 replies
    Justin Harringa
    @justinharringa:matrix.org
    [m]
    Not going to be able to make the presentation but I'm sure it's going to go great! Nice work @arpoch !
    1 reply
    Rishabh Budhouliya
    @rishabhBudhouliya
    @arpoch are you going to be there for the phase 2 session or are you submitting the pre-recorded presentation?
    1 reply
    Justin Harringa
    @justinharringa
    @arpoch @rishabhBudhouliya do we have any topics to discuss this week? Maybe we should just meet once more next week when Mark is back if you're interested?
    Harshit Chopra
    @arpoch
    No new topics to discuss on from my side, currently working on the test cases. Next week sounds great. If Justin you or Rishabh have anything to discuss I am all in.
    Justin Harringa
    @justinharringa
    Sounds good. Definitely let us know if you need anything :)
    Harshit Chopra
    @arpoch
    @MarkEWaite, you can remove my access to your remote machine has it's not required yet and could be granted again if required. Please ignore if you already have.
    Mark Waite
    @MarkEWaite
    Thanks @arpoch. Will remove your account
    Mark Waite
    @MarkEWaite
    @arpoch your account has been removed, as has the account for @rishabhBudhouliya
    If either of you need an account in the future, let me know, and we'll recreate them
    Harshit Chopra
    @arpoch
    Thanks Mark
    Harshit Chopra
    @arpoch
    @MarkEWaite, do you have any topics that you would like to discuss for the git-credentials-binding project, if so then we can schedule a meeting this week or later as suited by you, @justinharringa and @rishabhBudhouliya .
    Mark Waite
    @MarkEWaite
    @arpoch I'm behind schedule at work currently (a week's vacation does that). I don't have any topics for the Wednesday time. The Friday time might be a good place to discuss next steps and identify alternatives as we consider releasing the ssh private key support.
    Topics on my mind include:
    • Strengths and weaknesses of current implementation (strong: private key support on Linux, weak: private key support on Windows due to requiring ssh in the path)
    • Alternatives for releasing the phase 2 ssh private key implementation
    • Testing and other activities needed before merge and release
    • Handling issues that may be reported after release (does @arpoch want to be assigned Jira tickets, etc.)
    • Should we provide more examples with more details (and possibly close more Jira tickets as a result)?
    Harshit Chopra
    @arpoch
    • Handling issues that may be reported after release (does @arpoch want to be assigned Jira tickets, etc.)
    Absolutely. I think that it's a great way to stay connected with the community and reliable enough to answer whys or hows for our implementation in the upcoming future.
    Justin Harringa
    @justinharringa:matrix.org
    [m]
    No worries. I probably won't be able to make Friday as normal but again super appreciative of all the good work!
    Harshit Chopra
    @arpoch
    @MarkEWaite, is there a meeting scheduled for us today?
    Mark Waite
    @MarkEWaite
    Sorry that I'm late. Yes, we had planned to meet today. I'll join immediately.
    Sorry about that @arpoch . Had a personal meeting 30 minutes prior, then got involved writing tests for the Jenkins installers
    Harshit Chopra
    @arpoch
    @MarkEWaite, just wanted to bring it your notice, the issue that we faced with sshj library has been resolved. So sshj can now perform decryption of passphrase protected RSA private keys.
    Mark Waite
    @MarkEWaite
    @arpoch that's good to hear. Is that in an update of the sshj library? Would you be willing to update the pull request to use the newer library?
    Harshit Chopra
    @arpoch

    Is that in an update of the sshj library?

    Yes, the update is available in ssh v0.32.0

    Would you be willing to update the pull request to use the newer library?

    Currently we are depending upon sshd transitive dependency, so are you suggesting on using the sshj library instead of sshd?

    Mark Waite
    @MarkEWaite
    I'm open to changing the dependency if it simplifies the implementation. Alternately, if sshd provides the sshj library for us, then a pull request to update the sshj library inside sshd would be good
    Harshit Chopra
    @arpoch
    The sshj library is not provided as a transitive dependency in the git plugin. So I could try creating a new branch and test the sshj on that, if everything works as expected I will merge it into the PR branch.
    Harshit Chopra
    @arpoch
    @MarkEWaite I have tested the sshj library for RSA openssh formatted with passphrase protection and it works as expected but some issues are being encountered with the ed25519, I will have to look more into it and will update in chat.
    Mark Waite
    @MarkEWaite
    Thanks for investigating @arpoch !
    Rishabh Budhouliya
    @rishabhBudhouliya
    Hi @MarkEWaite , I was checking out the 2022 GSoC ideas discussion page and I'd like to discuss this particular idea: https://community.jenkins.io/t/google-summer-of-code-gsoc-2022-call-for-organizers-mentors-and-project-ideas/1010/7?u=rishabhbudhouliya
    git maintenance is supposed to optimise existing git repo and speed up git operations. Do we have any data to validate the decrease in operation time and how this would be beneficial for the git plugin and its users? If not, would we include a benchmarking experiment as an expectation in the gsoc proposal for this idea?
    Mark Waite
    @MarkEWaite
    https://issues.jenkins.io/browse/JENKINS-13493 includes a report of detectable performance improvements after garbage collection of a long-lived cache repository. I'm not worried about having the rigor of a benchmark inside the plugin because the performance loss is due to the git tool (both command line git and JGit), not due to code in the plugin. I saw performance improvements on ci.jenkins.io as well.
    Rishabh Budhouliya
    @rishabhBudhouliya
    Ah, got it. Thanks for the reference, Mark. Never imagined a .git cache would take up to 300GB of disk space!
    Mark Waite
    @MarkEWaite
    Yes, that's a larger than typical repository. 5+ years ago I was regularly handling a git repository that was 20 GB. It was a painful example of poor decisions on what to include in the repository. It was still useful to us, even though its size made it much less useful than it could have been
    Rishabh Budhouliya
    @rishabhBudhouliya
    More of a reason to have this feature on the git plugin. Looks like a great GSoC project.
    Gabriele Catania
    @ilCatania
    Hi all, I found a bug in the Jenkins Git plugin where tags are not checked out unless you clone the project twice. More than a month ago I filed a JIRA ticket: https://issues.jenkins.io/browse/JENKINS-67984 with details on how to reproduce the bug. Can anyone help me with pointers please?
    Mark Waite
    @MarkEWaite
    @Hrushi20 and @rishabhBudhouliya, I've placed the Git Cache Maintenance meeting recordings at https://community.jenkins.io/t/git-cache-maintenance-gsoc-2022/2563#git-cache-maintenance-meeting-recordings-1
    Hrushikesh
    @hrushi2001:matrix.org
    [m]
    Thank you @MarkEWaite: