Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 05:22
    dependabot[bot] labeled #397
  • 05:22
    dependabot[bot] opened #397
  • 05:22

    dependabot[bot] on maven

    Bump commons-lang3 from 3.11 to… (compare)

  • Mar 01 17:59
    bitwiseman synchronize #392
  • Mar 01 17:45
    dependabot[bot] synchronize #391
  • Mar 01 17:45

    dependabot[bot] on maven

    Bump github from 1.32.0 to 1.33… (compare)

  • Mar 01 17:45
    dependabot[bot] edited #391
  • Mar 01 17:45
    dependabot[bot] edited #391
  • Mar 01 17:45
    dependabot[bot] synchronize #394
  • Mar 01 17:45

    dependabot[bot] on maven

    Bump bom-2.263.x from 23 to 25 … (compare)

  • Mar 01 17:45
    dependabot[bot] edited #394
  • Mar 01 17:45
    dependabot[bot] edited #394
  • Mar 01 17:44

    bitwiseman on master

    [maven-release-plugin] prepare … (compare)

  • Mar 01 17:44

    bitwiseman on github-branch-source-2.10.2

    (compare)

  • Mar 01 17:44

    bitwiseman on master

    [maven-release-plugin] prepare … (compare)

  • Mar 01 17:36

    bitwiseman on 2.9.x

    [maven-release-plugin] prepare … (compare)

  • Mar 01 17:36

    bitwiseman on github-branch-source-2.9.7

    (compare)

  • Mar 01 17:36

    bitwiseman on 2.9.x

    [maven-release-plugin] prepare … (compare)

  • Mar 01 16:38

    bitwiseman on 2.9.x

    [maven-release-plugin] prepare … [maven-release-plugin] prepare … Bump plugin from 4.15 to 4.16 … and 18 more (compare)

  • Feb 26 23:04
    bitwiseman synchronize #392
Liam Newman
@bitwiseman
@timja It looks like the existing code works with the new version of github-api. Yay! jenkinsci/github-branch-source-plugin#370
Tim Jacomb
@timja
nice :)
Liam Newman
@bitwiseman
@timja I’m going to hold off on a releasing a new version of the github-api-plugin until you verify you don’t need any other fixes.
Liam Newman
@bitwiseman
@timja Do you plan to work on this any more today?
Just checking in.
Tim Jacomb
@timja
maybe
but feel free to do it yourself
@bitwiseman
/ release github-api-plugin
Liam Newman
@bitwiseman
@timja timja/github-branch-source-plugin#1 Looks like we both implemented a solution.
HimanshuNimawat
@HimanshuNimawat

Hello Everyone,
I am stuck in a problem and may be you guys can help me out :)

Problem:-
I enabled webhook in Github for Pull Requests. I am using multibranch pipeline and PR webhooks are working. But, I wanted that jenkins triggers build only when PR opens. At github side, the webhook for PR Requests consists all the triggers, due to which if PR gets closed then also build triggers which causes unwanted builds to be created.

How can I configure Jenkins that it only includes PR open events in multibranch pipeline ?

Hippolyte Vergnol
@CyberHippo
Hi, is this the right place to submit an issue related to the plugin ?
PS: Thanks for the great work :+1:
Liam Newman
@bitwiseman
@HimanshuNimawat I think that is something that you configure on the github side: which hooks to send.
@CyberHippo This is where we discuss the plugin. Issues can be submitted in the Jenkins JIRA.
HimanshuNimawat
@HimanshuNimawat
@bitwiseman Yes, I configured at Github side. Enabled "Pull Requests", but it consists of all the triggers as per its description and due to this only on close PR its getting triggered too.
HimanshuNimawat
@HimanshuNimawat
@bitwiseman what I can do to resolve this issue now ? Any suggestions please
Liam Newman
@bitwiseman
@HimanshuNimawat Sorry, I do not have any further suggesetion here. Having multibranch pipeline only build when a PR is created isn’t a scenario I think was considered.
HimanshuNimawat
@HimanshuNimawat
@bitwiseman Yes, that's correct. When a PR is created, the base branch disappears from the "Branches" section and appears as a PR number in "Pull Requests" Section. At that time what every commit is there in that branch, PR build reruns. But the issue is, when PR is closed, base branch appears in "Branches" Section again and started building itself, which should not be happen.
Liam Newman
@bitwiseman
@HimanshuNimawat There is a setting to ignore branches in the root repo when they are part of a PR.
There’s also a basic-branch-build-strategy plugin that should allow you to filter (rather than exclude all) branches that are built. You might try using that and naming all feature branches in a way that lets you filter them out.
Mathias Leppich
@muhqu
Hi all! I'm searching for jenkins plugin which allows to filter github pull requests based on PR's base branch. e.g. I'm interested in PRs which will merge to "master" but not something from feature branch X to Y.
Liam Newman
@bitwiseman
@muhqu In the same repository or from forks?
Mathias Leppich
@muhqu
same repo
Vincent B.
@ViBiOh_gitlab

Hi there :wave:

I have trouble with the new 2.10.1 version and the RateLimiter.

I have sometimes error like this, even if I'm far from the limit. At the time of error, our monitoring reported 13k API request remaining.

Caused: java.io.InterruptedIOException: sleep interrupted
    at org.kohsuke.github.GitHubRateLimitChecker.checkRateLimit(GitHubRateLimitChecker.java:140)
    at org.kohsuke.github.GitHubClient.sendRequest(GitHubClient.java:392)
Caused: org.kohsuke.github.HttpException: Server returned HTTP response code: -1, message: 'null' for URL: https://api.github.com/app
    at org.kohsuke.github.GitHubClient.interpretApiError(GitHubClient.java:494)
Couldn't authenticate with GitHub app ID XXXX

I was wondering if there a way to disable the RateLimiter for Authentification or whitelist URL to not have rate limit (in our case https://api.github.com/app) ?

Edit: My current setting for RateLimiter is ThrottleOnOver (yaml value, "Throttle at/or near limit")

Liam Newman
@bitwiseman
@ViBiOh_gitlab Interesting. Have you filed a bug report in the Jenkins JIRA? We’ll need the full stack trace (that doesn’t look like it was the full stack) and we may need to collect logs. What does the output before that error look like?
16 replies
Liam Newman
@bitwiseman
No, you definitely can’t completely disable rate limiting for any part of api.github.com. I don’t think the error is what you think it is. It shouldn’t be checking the rate limit when getting app credentials. What is most likely is you are making another request which needs to check the ratelimit and then the credentials have to refresh in the middle of that and that fails.
1 reply
view it on the screen
i'm changing the images to svgs
tested all the others but not that one
Tim Jacomb
@timja
yeah how do i see it in the UI
where
Liam Newman
@bitwiseman
You mean to verify that it is working?
Tim Jacomb
@timja
yeah need to check that it looks ok in wherever it's rendered
Liam Newman
@bitwiseman
Trying now.
Tim Jacomb
@timja
it's the new job screen, thanks!
Liam Newman
@bitwiseman
Yup, 48x48 navigator.
Tim Jacomb
@timja
tbh I think i'll leave it as otherwise it'll look quite out of place
this is the icon set i've been using https://github.com/primer/octicons/tree/master/icons
Liam Newman
@bitwiseman
Why would it look out of place?
Tim Jacomb
@timja
there an icon you think would be good?
But what we have is bit more than an icon...
Tim Jacomb
@timja
Yeah i think ill leave it for now, should have a PR up by next week :)
Liam Newman
@bitwiseman
Cool
Liam Newman
@bitwiseman
@timja @ViBiOh_gitlab jenkinsci/github-branch-source-plugin#395 Please give this a try once CI passes and produces an incremental.
Tim Jacomb
@timja
I can't this week but can probably next week
Liam Newman
@bitwiseman
Sure.