Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 01:57

    LinuxSuRen on master

    Add the title of a merge reques… (compare)

  • 01:57
    LinuxSuRen closed #55
  • 01:57
    LinuxSuRen commented #55
  • Sep 12 07:36
    baymac review_requested #55
  • Sep 12 07:36
    baymac review_requested #55
  • Sep 12 02:17
    LinuxSuRen commented #55
  • Sep 12 02:12
    LinuxSuRen commented #55
  • Sep 12 02:10
    LinuxSuRen review_request_removed #55
  • Sep 12 02:10
    LinuxSuRen review_requested #55
  • Sep 12 02:10
    LinuxSuRen review_requested #55
  • Sep 12 02:10
    LinuxSuRen opened #55
  • Sep 11 22:18
  • Sep 11 17:06
    casz commented #54
  • Sep 11 13:36
    casz synchronize #54
  • Sep 11 13:29
    casz synchronize #54
  • Sep 11 09:52
    casz labeled #54
  • Sep 11 08:50
    baymac commented #54
  • Sep 11 08:46
    casz commented #54
  • Sep 11 08:39
    casz edited #54
  • Sep 11 08:37
    casz labeled #53
Joseph Petersen
@casz
@baymac are you okay with me doing a release train for jenkinsci/gitlab-branch-source-plugin#53
Parichay Barpanda
@baymac
Yup, that's okay 👍
Peter Leibiger
@kuhnroyal
The global libraries are now always loaded from gitlab.com and not from the specified Gitlab server. Unless I set Implicit to true.
And this of course always fails with Access Denied and then fails the build.
Peter Leibiger
@kuhnroyal
Actually it has nothing to do with the implicit flag, every time I reload the config with JCasC, it tries to load the shared library from gitlab.com - once I go to 'Configure System' and save the configuration without changes, it works.
Joseph Petersen
@casz
@kuhnroyal for global libraries I'd suggest using a standard git source.
Peter Leibiger
@kuhnroyal
Yea I could probably do that. But this worked before my holiday with one of the last betas ;)
Parichay Barpanda
@baymac
Do you have any idea if anything causing this issue? @casz @kuhnroyal
@kuhnroyal Can you tell in which beta release did this feature work?
Peter Leibiger
@kuhnroyal
I have no clue tbh. When the JCasC config is reloaded it breaks and tries to pull from gitlab.com. When I save it without changes in ' Configure System' it works afterwards. My guess is that the serverUrl is blank after reload, somewhere around here: https://github.com/jenkinsci/gitlab-branch-source-plugin/blob/master/src/main/java/io/jenkins/plugins/gitlabserverconfig/servers/GitLabServer.java#L117
And when the config view is opened it somehow gets populated and works on save.
Peter Leibiger
@kuhnroyal
shared_library_reload.png
This is after reloading existing configuration
shared_library_after_manual_save.png
And this is after I press save without any changes.
But builds also fail with the same error, not only the config view.
Parichay Barpanda
@baymac
Thanks, I'll take a look and let you know.
Joseph Petersen
@casz
okay, actually @kuhnroyal I saw the exact same issue today :) I think it is what I currently have a fix for :laughing:
jenkinsci/gitlab-branch-source-plugin#54 should fix it, I believe it is a bug with failing lightweight checkout
and for some reason lightweight checkout defaults to HTTP url (which we do not have configured properly) we only use ssh checkout on Jenkins
I'd like to investigate the bug further. Since I can reproduce it with our dockerized setup after hitting reload JCasC
Joseph Petersen
@casz
19:01:02  Querying the current revision of branch master...
19:01:02  Current revision of branch master is 680d18759183d09242a050bf5db10ccf22d09a85
19:01:02  [GitLab Pipeline Status] Notifying branch build status: FAILED Group/Repo/master: There was a failure building this commit
19:01:02  [GitLab Pipeline Status] Notified
19:01:02  hudson.plugins.git.GitException: Command "git fetch --tags --force --progress origin +refs/heads/*:refs/remotes/origin/* --prune" returned status code 128:
19:01:02  stdout: 
19:01:02  stderr: remote: HTTP Basic: Access denied
19:01:02  fatal: Authentication failed for 'https://snip/Group/repo.git/'
19:01:02  
19:01:02      at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2099)
19:01:02      at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1791)
19:01:02      at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$400(CliGitAPIImpl.java:79)
19:01:02      at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:472)
19:01:02      at jenkins.plugins.git.GitSCMFileSystem$BuilderImpl.build(GitSCMFileSystem.java:406)
19:01:02      at jenkins.scm.api.SCMFileSystem.of(SCMFileSystem.java:293)
19:01:02      at org.jenkinsci.plugins.workflow.multibranch.SCMBinder.create(SCMBinder.java:103)
19:01:02      at org.jenkinsci.plugins.workflow.job.WorkflowRun.run(WorkflowRun.java:293)
19:01:02      at hudson.model.ResourceController.execute(ResourceController.java:97)
19:01:02      at hudson.model.Executor.run(Executor.java:429)
19:01:02  Finished: FAILURE
as you can see it goes down the rabbit hole of SCMFileSystem.of
Joseph Petersen
@casz
Hmmm unsure if our two very similar bugs are related @kuhnroyal I'll need to investigate further
Joseph Petersen
@casz
@baymac I think for my bug, I was right on the money! The scmfile could not handle the project being a null pointer :laughing:
Iftekhar Akoob
@chickenbeef
Hi, I see 1.3.0 was released. What are the notable changes?
Parichay Barpanda
@baymac
I don't know why we have 1.3.0 🤔
Oh wait there's been a confusion. 1.3.0 has been released but GitHub releases hasn't been updated.
Iftekhar Akoob
@chickenbeef
Aha, thank you very much :)
Parichay Barpanda
@baymac
@casz thanks for the fix. I'll take a look at it.
Joseph Petersen
@casz
my bad @baymac :sob:
Parichay Barpanda
@baymac
It's okay 😅
Jarl Törnroos
@jarl-tornroos
Hi guys!
I’m trying to configure a GitLab multibranch pipeline. It works fin while I configure the Job and I can see all of the repositories but when I save it will fail in the “scanning GitLab Project” with a 404 Not Found.
Is this btw the right place to ask for help or report bugs? Seems like it’s not possible to create issues in the GitHub repo.
Joseph Petersen
@casz
@jarl-tornroos right place to ask questions, better place to report bugs is https://issues.jenkins-ci.org when you create issue under the JENKINS project select the gitlab-branch-source component
Parichay Barpanda
@baymac
@jarl-tornroos can you share link to your GitLab repository?
Joseph Petersen
@casz
@baymac seems like we have issue with lightweight checkout of Jenkinsfile with merge requests.
Which fails on our instance because our Jenkins master does not have git lfs installed (we do not intend to remove the git lfs behavior nor do we intend on installing git lfs on our Jenkins master)
16:42:39  Merge request !1 opened
16:42:39  Triggered by GitLab Merge Request #1: timestamps => master
16:42:40  Querying the current revision of merge request #1...
16:42:40  Current revision of merge request #1 is b5538562e2c6c721657f85b7e859f2f4ad66ea94
16:42:40  Checking out git git@git.3shape.local:jenkins/tests/jenkinsvsphereplugin.git into /var/jenkins_home/workspace/_JenkinsVSpherePlugin_MR-1-merge@script to read Jenkinsfile
Joseph Petersen
@casz
I see the problem @baymac :laughing:
You implemented a custom scmfilesystem build instead of overriding the existing scmsource build(@NonNull SCMSource source, @NonNull SCMHead head, SCMRevision rev)
Parichay Barpanda
@baymac
This message was deleted
Joseph Petersen
@casz
Hmm need to investigate further seems probe fails on finding Jenkinsfile for some odd reason
I'll look into adding testing before messing with it :sweat:
Jarl Törnroos
@jarl-tornroos
@baymac , I can't unfortunately share the repository. The repository is privately hosted on our customers gitlab community edition servers.
Thanks @casz , I'll create an issue in the right place with a bit more details.
Parichay Barpanda
@baymac
Okay share the full log and other details like the GitLab and the Jenkins server version
Joseph Petersen
@casz
hmm jenkinsci/gitlab-branch-source-plugin#54 currently fixes the lightweight checkout failures due to the usage of transient project so perhaps a separate issue for fixing merge request lightweight checkout will be better.
WDYT @baymac should we merge and move to a new PR for fixing merge request lightweight checkout
Parichay Barpanda
@baymac
@casz okay 👍
Parichay Barpanda
@baymac
@casz Is there any updates on fixing MR lightweight checkout npe? Shall we merge #54?