Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Mar 31 22:21
    dependabot[bot] labeled #68
  • Mar 31 22:21
    dependabot[bot] opened #68
  • Mar 31 22:21

    dependabot[bot] on maven

    Bump guava from 28.2-jre to 29.… (compare)

  • Oct 12 2020 17:03
    markyjackson-taulia commented #35
  • Aug 29 2020 13:49

    Loghijiaha on master

    code cleanup Added HTML view (compare)

  • Aug 29 2020 13:49
    Loghijiaha closed #67
  • Aug 28 2020 18:21
    Loghijiaha commented #67
  • Aug 28 2020 18:20
    Loghijiaha synchronize #67
  • Aug 28 2020 17:48
    Loghijiaha opened #67
  • Aug 28 2020 07:48

    Loghijiaha on master

    Fixed unnecessary SEVERE log (compare)

  • Aug 28 2020 07:48
    Loghijiaha closed #66
  • Aug 27 2020 17:45
    Loghijiaha opened #66
  • Aug 24 2020 20:32

    Loghijiaha on master

    Updated release draft Updated changelog (compare)

  • Aug 24 2020 20:32
    Loghijiaha closed #65
  • Aug 24 2020 20:22
    Loghijiaha commented #65
  • Aug 24 2020 15:44
    Loghijiaha synchronize #65
  • Aug 24 2020 15:43
    Loghijiaha opened #65
  • Aug 24 2020 10:48

    Loghijiaha on master

    [maven-release-plugin] prepare … (compare)

  • Aug 24 2020 10:48

    Loghijiaha on machine-learning-1.0.1

    (compare)

  • Aug 24 2020 10:47

    Loghijiaha on master

    [maven-release-plugin] prepare … (compare)

Loghi
@Loghijiaha
@all Finally, I think everything is set with the first stable release. Great :tada:
Loghi
@Loghijiaha
What will be a first version number ? Any code of conduct applicable to the first version number?
Bruno P. Kinoshita
@kinow
@Loghijiaha well done!! Normally version number either starts at 0.1 if the release doesn't include the main features of the product (nginx was 0.x for a long time, for example, pandas too), or with 1.0. Either way would be fine IMO. More important is to follow semver to give users/sysadmins/etc a good idea of when an update is safe or not
Loghi
@Loghijiaha
Yes Thanks, @kinow jenkinsci/machine-learning-plugin#61 There was a bunch of Javadoc warning which does not allow me to release.
Bruno P. Kinoshita
@kinow
Yup, I noticed you fixed that, and also the SNAPSHOT version. I think one last check that Jenkins does is SpotBugs. In case you find some issues, it should print the command to review the spotsbugs locally. If no issues found, however, then you should be ready to publish it!
Loghi
@Loghijiaha
I ran mvn clean install, there were no spotbugs.
But the release was failed at the first time.
This message was deleted
<scm>
        <connection>scm:git:git://github.com/jenkinsci/${project.artifactId}-plugin.git</connection>
        <developerConnection>scm:git:git@github.com:jenkinsci/${project.artifactId}-plugin.git</developerConnection>
        <url>https://github.com/jenkinsci/${project.artifactId}-plugin</url>
      <tag>1.0</tag>
Can i do a release for 1.0 now or 1.1?
Bruno P. Kinoshita
@kinow
For 1.0. If it hasn't been released already, you should be able to release 1.0
If there's already a tag, you can - always carefully - remove the tag (do note that in some projects editing tags may be prohibited, with hooks to make them read-only)
Loghi
@Loghijiaha
Released :tada:
Will it take time to reflect on io.jenkins ?
Bruno P. Kinoshita
@kinow
I think it takes about 2 hours? I think there's a process somewhere that runs every 2 hours to sync the update center... Though that value could have changed (or my memory could be wrong, more likely haha).
But congrats Loghi!!! I bet it feels good to have the final version of the plug-in working as expected, and released!
Looking forward to our meeting tomorrow (for me at least it's tomorrow). o/
Loghi
@Loghijiaha
Yes it is now available in the plugin reo.
Ioannis K. Moutsatsos
@imoutsatsos
image.png
1 reply
@kinow I have followed your instructions from Aug 11, and run with a fresh master checkout. Although it seems that I can now start a python3 jupyter kernel it fails with io.grpc error later
image.png
@kinow Python wirh miniconda
Ioannis K. Moutsatsos
@imoutsatsos
image.png
Also a job using the Kernel runs forever. You can't interrupt it from the Jenkins console
2 replies
image.png
Loghi
@Loghijiaha
I installed the released version 1.0 and when I try to build it does not recognize our monkey-patched Zeppelin Launcher. It says java.lang.NoSuchMethodError: org.apache.zeppelin.interpreter.util.ProcessLauncher.<init>(Lorg/apache/commons/exec/CommandLine;Ljava/util/Map;Ljava/lang/String;)V because it tends to use from the zeppelin-jupyter.jar.But this works in master as we expected. Had to discuss and fix. https://issues.jenkins-ci.org/browse/JENKINS-63475
Bruno P. Kinoshita
@kinow
Hmmm, it might be that in Jenkins the classloader works differently. Hmmm
@Loghijiaha ^

@imoutsatsos I think you may have to re-sync the repo. @Loghijiaha fixed the grpc nullpointer. Strange this error of the kernel waiting forever. From what I understand, Zeppelin starts a kernel/client, and has some code that keeps waiting for error or the notebook result.

Can you check the console logs of Jenkins? Do they say something like "Waiting for read" or similar?

Ioannis K. Moutsatsos
@imoutsatsos
Away from my workstation at the moment. I'll give it another try before our meeting tonight
Bruno P. Kinoshita
@kinow
Sure, no prob
@Loghijiaha sorry about the issue with at Zeppelin class. I've left a longer comment in JIRA, but here's a possible fix (needs testing): https://www.jenkins.io/doc/developer/plugin-development/dependencies-and-class-loading/#pluginfirstclassloader-and-its-discontents
Loghi
@Loghijiaha
Okay @kinow I will fix and test using that doc.
Ioannis K. Moutsatsos
@imoutsatsos
@kinow and @Loghijiaha after re-sync of my local repo, I can now start the python Kernel successfully and run a hello example! Thank you both for all the feedback while I was setting up the ml plugin on my Win10 workstation 🎈
Loghi
@Loghijiaha
:tada:
Bruno P. Kinoshita
@kinow
Great news @imoutsatsos ! @Loghijiaha has done amazing work in the past days. The plug-in is pretty much to start being used by the wider audience now.
Loghi
@Loghijiaha
@kinow shading the classpath is working. I will give a PR after the meeting.
GSoC 2020 final Meeting
Meeting link: https://zoom.us/j/98822238159
Shivay Lamba
@shivaylamba
That's great Ioannis
Bruno P. Kinoshita
@kinow
Glad to hear it worked @Loghijiaha ! Might be a good idea to add a comment to pom.xml explaining why that changed was required. Or at least include in the commit message.
That's not super common, and may lead to problems if you have a very complex dependency tree (which is not our case for now). Always helpful in case another developer is working on a pull request to your plugin :)
Bruno P. Kinoshita
@kinow
PR reviewed @Loghijiaha . Found no issues! Good job!
Loghi
@Loghijiaha
Thanks @kinow
Will merge it and prepare for teh patch release done.
Bruno P. Kinoshita
@kinow
Sounds good to me. Thank you Loghi!
Loghi
@Loghijiaha
Released 1.0.1 :tada: (working release :exclamation: )
Loghi
@Loghijiaha
Loghi
@Loghijiaha
For the final evaluation, everyone was submitting the project page last year. We will go in the flow as well. Agree?
Loghi
@Loghijiaha
@kinow @imoutsatsos @shivaylamba
Bruno P. Kinoshita
@kinow
It sounds good to me @Loghijiaha . Only thing that I couldn't find in that page is the GitHub repo?