by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Mark Waite
    @MarkEWaite

    I have put all the images for new internationalization page inside /content/images/developer/internationalization/a.png directory. But somehow the image is not loading in the adoc file. I have written this code for image attribute image:../content/images/developer/internationalization/a.png[image,title="Jenkins > Internationalization > before.png"] my image file name is a.png

    @sachinmukherjee I think image references always start with /images rather than /content/images

    @urwa I don't think anyone has done jenkins.io documentation development on Windows. I'm a Windows user, but I always run jenkins.io development environment on Linux. I suspect there are platform specific issues related to either differences in the behavior of make or in the behavior of portions of the site generation steps on Windows computers.
    Oleg Nenashev
    @oleg-nenashev
    @MarkEWaite @urwa I do develop jenkins.io on Windows, but I use WSL and Docker. https://nickjanetakis.com/blog/setting-up-docker-for-windows-and-wsl-to-work-flawlessly can be followed to bootstrap such setup
    Mark Waite
    @MarkEWaite
    Thanks @oleg-nenashev
    rajaws2015
    @rajaws2015
    Hi All, currently i am working on issue https://issues.jenkins-ci.org/browse/WEBSITE-647
    I have a question now :How to determine whether the documentation page comes from Markdown or Asciidoc?
    Oleg Nenashev
    @oleg-nenashev
    Discussed it with @rajaws2015 onsite
    urwa
    @urwa

    Hi @oleg-nenashev ,

    Thanks for your help. I had no idea about WSL and its amazing. I have set it up.
    Now I am having a small issue of \r carriage return since my local repo is on windows that I am trying to run through WSL.
    Here is the exact error:

    ./scripts/ruby pull
    ./scripts/ruby: line 2: $'\r': command not found
    : No such file or directorycripts/docker-env
    ./scripts/ruby: line 5: $'\r': command not found
    ./scripts/ruby: line 8: syntax error near unexpected token `fi'
    '/scripts/ruby: line 8: `fi;
    Makefile:77: recipe for target 'build/ruby' failed
    make: *** [build/ruby] Error 2

    I have come across two suggestions at the moment:

    option 1 seems like NOT the right option since it would be changing files in the repo that I believe I should not be doing.

    About option 2, since WSL is simply a CLI, so making changes in the local repo (creating file, updating file) won't be as simple as in VS Code.

    I just want to ask how does your setup look like while developing jenkins.io in windows.

    Thanks once again.

    Oleg Nenashev
    @oleg-nenashev
    @urwa My Git is configured to preserve the Unix line endings for repos. Ypu can put 'core.autocrlf=input' in settings, but likely you will need to re-clone the repo after it
    Philipp Nowak
    @literalplus
    @urwa what I usually use for that is a .gitattributes file that forces LF line endings on all *.sh files, since shell files don't run with CRLF anyways & most people that can run shell files use editors that can deal with LF. See this GitHub page for an example. There's also some way to migrate existing files via git add. Depends on the project whether this is an acceptable solution though
    urwa
    @urwa

    @oleg-nenashev and @xxyy thank you for your responses.

    While setting up WSL and struggling with permission issues across windows and ubuntu, I found out my system was infested with mining malware. After spending quite some time and failing miserably to fix it. I ended up letting windows go and beginning with a clean Ubuntu installation.

    This solved a lot of errors I kept googling for WSL to work. So now I have added the test.adoc to content/participate folder and updated index.html.haml to link it with this new page.

    The only problem is I forgot to clone from my own remote repo i.e. https://github.com/urwa/jenkins.io.git. Instead I cloned from the original repo i.e. https://github.com/jenkins-infra/jenkins.io.git

    So now I have local repo with a new branch and changes committed to it. BUT I am not sure which remote repo should I push the changes to.

    I would really appreciate any help.

    Mark Waite
    @MarkEWaite
    @urwa I can help with that.
    urwa
    @urwa
    Please do let me know.
    Mark Waite
    @MarkEWaite
    @urwa one technique is to add your personal repository as an additional remote using the commands:
    $ git remote add new-origin https://github.com/urwwa/jenkins.io.git
    $ git remote rename origin upstream
    $ git remote rename new-origin origin
    $ git push --set-upstream origin YOUR_BRANCH_NAME_HERE
    urwa
    @urwa

    Sorry for this blunder, I realized a bit late that the url has my name wrong with an extra w

    urwa@urwa:~/dev/outreachy/jenkins.io$ git remote add new-origin https://github.com/urwwa/jenkins.io.git
    urwa@urwa:~/dev/outreachy/jenkins.io$ git remote rename origin upstream
    urwa@urwa:~/dev/outreachy/jenkins.io$ git remote rename new-origin origin
    urwa@urwa:~/dev/outreachy/jenkins.io$ git remote add new-origin https://github.com/urwa/jenkins.io.git
    urwa@urwa:~/dev/outreachy/jenkins.io$ git remote rename new-origin origin
    fatal: remote origin already exists.

    How should I go from here.

    Mark Waite
    @MarkEWaite

    I think you can use the following commands:

    $ git remote set-url origin https://github.com/urwa/jenkins.io.git
    $ git remote -v

    That should output that the repo named 'origin' is now using your URL

    urwa
    @urwa
    thanks a lot. I removed upstream origin and new-origin using rm and then did git remote add origin <url>
    git push origin <new-branch>
    Mark Waite
    @MarkEWaite

    That's a good start. It will likely simplify your life interacting with command line git if you clone a fresh copy of the repo from the correct URL. There are some settings inside the .git/config file that make life easier for you. Those settings are created by default when you clone, but may not be set with the steps you just took. For your reference, here is the content of my .git/config file:

    [core]
            repositoryformatversion = 0
            filemode = true
            bare = false
            logallrefupdates = true
    [remote "origin"]
            url = git@github.com:MarkEWaite/jenkins.io.git
            fetch = +refs/heads/*:refs/remotes/origin/*
    [branch "master"]
            remote = origin
            merge = refs/heads/master
    [remote "upstream"]
            url = git@github.com:jenkins-infra/jenkins.io.git
            fetch = +refs/heads/*:refs/remotes/upstream/*

    You may also want to install the hub command from https://github.com/github/hub/blob/master/README.md so that you can use the shortcut command:

    $ hub sync

    The hub sync command makes it easier for me to remain current with the upstream repository.

    urwa
    @urwa
    Thank you for this info. Will surely check hub.
    urwa
    @urwa

    Hi,
    I wanted to ask 4 questions:

    • When a reviewer suggests some changes, it is the same process all over again right? i.e. make changes in the local branch -> add -> commit -> push -> pull request. Right? I just wanted to be sure.
    • Secondly to record this small contribution on outreachy, which URL should I use. The issue tracker, the pull request or something else.
    • On a priority scale, should I add the changes in this contribution first OR should I go ahead with another issue and get started on that, since I started late with the contribution process and I see a number of similar issues on issues.jenkin-ci.org/projects.
    • I see a number of issues that have comments where some one shows willingness to do it but it is still unassigned. Is it okay to take that issue OR should I find another one. e.g. this one https://issues.jenkins-ci.org/projects/WEBSITE/issues/WEBSITE-667

    Thanks.

    Mark Waite
    @MarkEWaite

    @urwa, thanks for the questions.

    • When a reviewer suggests some changes, it is the same process all over again right? i.e. make changes in the local branch -> add -> commit -> push -> pull request. Right? I just wanted to be sure.

    Yes, when a suggestion is given you can either apply the suggestion from the GitHub web page or you can apply it on your local copy. If you do it from the web page, then the commit is made directly on GitHub and you'll need to git pull the change to your local copy. If you do it from your local copy, then the commit will need to be pushed to GitHub with git push.

    • Secondly to record this small contribution on outreachy, which URL should I use. The issue tracker, the pull request or something else.

    I generally prefer to create a link in the issue tracker to the pull request and I like to reference the issue number as a link from the pull request. Readers of either are then only one click away from the matching information in the other location.

    • On a priority scale, should I add the changes in this contribution first OR should I go ahead with another issue and get started on that, since I started late with the contribution process and I see a number of similar issues on issues.jenkin-ci.org/projects.

    Review is asynchronous, so some number of pull requests are likely to be in progress at any one time. You're welcome to have multiple pull requests open at a time.

    Assigning an issue to yourself is a clear way to indicate that you intend to work on the issue. It is also a good way to notify others that are watching the issue. If one of those watching the issue has already started work on it, we hope that your notification of issue assignment will alert them. That notification informs them that the issue they forgot to assign themselves has now started work by someone else. They can then converse with you through the issue to decide who should work on the issue.

    urwa
    @urwa
    Thank you so much for the detailed reply. This is all understandable.
    urwa
    @urwa

    Hi,

    I am in the process of contributing to this issue.
    https://issues.jenkins-ci.org/projects/WEBSITE/issues/WEBSITE-667

    In the description is it mentioned: There is some initial content on this page . I just want to know "this page" refers to what page. In other words, where can I get information about "Code Reviews and Core PR Reviewers GitHub teams".

    I have already moved the content from here [https://jenkins.io/participate/#review-changes] to the new page.

    urwa
    @urwa
    I have found link to copy-editors page in the contributing.adoc but its broken.
    Tim Jacomb
    @timja
    It's not broken you need to be a member of the jenkins-infra organisation on GitHub to see it :(
    Gavin Mogan
    @halkeye
    image.png
    yep yep
    urwa
    @urwa
    This message was deleted
    oh right. I got a 404 error. so though it was broken.
    Bukola Bisuga
    @bukolabisuga
    image.png
    Hello, I'd appreciate some help with this issue.
    Mark Waite
    @MarkEWaite
    @bukolabisuga have you checked the permissions on that directory with the command:
    $ ls -altrd /home/bukolabisuga/outreachy/jenkins.io
    Mark Waite
    @MarkEWaite
    Also @bukolabisuga , which operating system are you running on your development environment. Likewise, what is the output of the command:
    $ id
    Bukola Bisuga
    @bukolabisuga
    @MarkEWaite thank you, I'm running Linux on windows using WSL
    This is what i get when i run the following commands above
    image.png
    Zbynek Konecny
    @zbynek
    @bukolabisuga you may need to run PowerShell as admin, then start WSL from that powershell console by typing bash
    Oleg Nenashev
    @oleg-nenashev
    OK, last day!
    Looks like ci.jenkins.io is mostly back
    Sumit Kharche
    @sumitkharche
    @oleg-nenashev I have submitted 4 PR so Am I eligible for Jenkins hacktoberfest.
    Sachin Mukherjee
    @sachinmukherjee
    Hello everyone. Since hacktoberfest is over. Can we still solve the issue label with hacktoberfest ?
    Mark Waite
    @MarkEWaite
    @sachinmukherjee you're welcome to label things with hacktoberfest. We're still inside the time window for hacktoberfest, and will be in that window for about 8 more hours. The hacktoberfest organizers accept any time zone where it is 31 Oct 2019. The day 31 Oct 2019 ends in Hawaii about 8 hours from now.
    Gavin Mogan
    @halkeye
    @sumitkharche check out your stats on https://hacktoberfest.digitalocean.com/profile. as long as things don't get marked as invalid your probably good
    Oleg Nenashev
    @oleg-nenashev
    Once the hacktoberfest is really over, everyone is welcome to keep working on the labeled issues or to take new ones. No need to wait till another event, we welcome contributions 24/7/365 :)
    Oleg Nenashev
    @oleg-nenashev
    @/all thanks to everyone who contributed to Jenkins during Hacktoberfest! It is much appreciated. We have got almost 250 confirmed pull requests, and also hundreds of ones which were not marked for Jenkins Hacktoberfest (let me know if you have such ones!) We will process the results and publish summaries and highlights in the next few weeks. We will also appreciate any feedback about how to do the Hacktoberfest in Jenkibs better next year
    Tracy Miranda
    @tracymiranda
    Thanks to hacktoberfest looks like Jenkins hit a record high number of individual developer contributions: 915!! Thanks all who participated, has been amazing! https://jenkins.devstats.cd.foundation/d/7/companies-contributing-in-repository-groups?orgId=1&from=now-5y&to=now
    Gavin Mogan
    @halkeye
    Yay
    Oleg Nenashev
    @oleg-nenashev
    :+1:
    I am working on Jenkins-specific Hacktoberfest highlights. Meanwhile, a summary blogpost by Digital Ocean. https://blog.digitalocean.com/recapping-hacktoberfest-6/
    Sachin Mukherjee
    @sachinmukherjee
    Hello everyone. Please review this PR jenkins-infra/jenkins.io#2642 for issue https://issues.jenkins-ci.org/browse/WEBSITE-663.