Thanks for the help though.
Steps I did were:
git clone https://github.com/jenkins-infra/jenkins.io.git
index.html.hamlwith link to above created page
may be i missed some step or did something wrong... just putting this info here if it provides some insight.
I have put all the images for new internationalization page inside
/content/images/developer/internationalization/a.pngdirectory. But somehow the image is not loading in the adoc file. I have written this code for image attribute
image:../content/images/developer/internationalization/a.png[image,title="Jenkins > Internationalization > before.png"]my image file name is a.png
@sachinmukherjee I think image references always start with
/images rather than
makeor in the behavior of portions of the site generation steps on Windows computers.
Hi @oleg-nenashev ,
Thanks for your help. I had no idea about WSL and its amazing. I have set it up.
Now I am having a small issue of
\r carriage return since my local repo is on windows that I am trying to run through WSL.
Here is the exact error:
./scripts/ruby pull ./scripts/ruby: line 2: $'\r': command not found : No such file or directorycripts/docker-env ./scripts/ruby: line 5: $'\r': command not found ./scripts/ruby: line 8: syntax error near unexpected token `fi' '/scripts/ruby: line 8: `fi; Makefile:77: recipe for target 'build/ruby' failed make: *** [build/ruby] Error 2
I have come across two suggestions at the moment:
dos2unixhttps://askubuntu.com/a/1046371/128806 and replace CRLF to LF.
option 1 seems like NOT the right option since it would be changing files in the repo that I believe I should not be doing.
About option 2, since WSL is simply a CLI, so making changes in the local repo (creating file, updating file) won't be as simple as in VS Code.
I just want to ask how does your setup look like while developing jenkins.io in windows.
Thanks once again.
git add. Depends on the project whether this is an acceptable solution though
@oleg-nenashev and @xxyy thank you for your responses.
While setting up WSL and struggling with permission issues across windows and ubuntu, I found out my system was infested with mining malware. After spending quite some time and failing miserably to fix it. I ended up letting windows go and beginning with a clean Ubuntu installation.
This solved a lot of errors I kept googling for WSL to work. So now I have added the
content/participate folder and updated
index.html.haml to link it with this new page.
The only problem is I forgot to clone from my own remote repo i.e.
https://github.com/urwa/jenkins.io.git. Instead I cloned from the original repo i.e.
So now I have local repo with a new branch and changes committed to it. BUT I am not sure which remote repo should I push the changes to.
I would really appreciate any help.
$ git remote add new-origin https://github.com/urwwa/jenkins.io.git $ git remote rename origin upstream $ git remote rename new-origin origin $ git push --set-upstream origin YOUR_BRANCH_NAME_HERE
Sorry for this blunder, I realized a bit late that the url has my name wrong with an extra
urwa@urwa:~/dev/outreachy/jenkins.io$ git remote add new-origin https://github.com/urwwa/jenkins.io.git urwa@urwa:~/dev/outreachy/jenkins.io$ git remote rename origin upstream urwa@urwa:~/dev/outreachy/jenkins.io$ git remote rename new-origin origin urwa@urwa:~/dev/outreachy/jenkins.io$ git remote add new-origin https://github.com/urwa/jenkins.io.git urwa@urwa:~/dev/outreachy/jenkins.io$ git remote rename new-origin origin fatal: remote origin already exists.
How should I go from here.
That's a good start. It will likely simplify your life interacting with command line git if you clone a fresh copy of the repo from the correct URL. There are some settings inside the
.git/config file that make life easier for you. Those settings are created by default when you clone, but may not be set with the steps you just took. For your reference, here is the content of my
[core] repositoryformatversion = 0 filemode = true bare = false logallrefupdates = true [remote "origin"] url = firstname.lastname@example.org:MarkEWaite/jenkins.io.git fetch = +refs/heads/*:refs/remotes/origin/* [branch "master"] remote = origin merge = refs/heads/master [remote "upstream"] url = email@example.com:jenkins-infra/jenkins.io.git fetch = +refs/heads/*:refs/remotes/upstream/*
You may also want to install the
hub command from https://github.com/github/hub/blob/master/README.md so that you can use the shortcut command:
$ hub sync
hub sync command makes it easier for me to remain current with the upstream repository.
I wanted to ask 4 questions:
@urwa, thanks for the questions.
- When a reviewer suggests some changes, it is the same process all over again right? i.e. make changes in the local branch -> add -> commit -> push -> pull request. Right? I just wanted to be sure.
Yes, when a suggestion is given you can either apply the suggestion from the GitHub web page or you can apply it on your local copy. If you do it from the web page, then the commit is made directly on GitHub and you'll need to
git pull the change to your local copy. If you do it from your local copy, then the commit will need to be pushed to GitHub with
- Secondly to record this small contribution on outreachy, which URL should I use. The issue tracker, the pull request or something else.
I generally prefer to create a link in the issue tracker to the pull request and I like to reference the issue number as a link from the pull request. Readers of either are then only one click away from the matching information in the other location.
- On a priority scale, should I add the changes in this contribution first OR should I go ahead with another issue and get started on that, since I started late with the contribution process and I see a number of similar issues on issues.jenkin-ci.org/projects.
Review is asynchronous, so some number of pull requests are likely to be in progress at any one time. You're welcome to have multiple pull requests open at a time.
- I see a number of issues that have comments where some one shows willingness to do it but it is still unassigned. Is it okay to take that issue OR should I find another one. e.g. this one https://issues.jenkins-ci.org/projects/WEBSITE/issues/WEBSITE-667
Assigning an issue to yourself is a clear way to indicate that you intend to work on the issue. It is also a good way to notify others that are watching the issue. If one of those watching the issue has already started work on it, we hope that your notification of issue assignment will alert them. That notification informs them that the issue they forgot to assign themselves has now started work by someone else. They can then converse with you through the issue to decide who should work on the issue.
I am in the process of contributing to this issue.
In the description is it mentioned: There is some initial content on this page . I just want to know "this page" refers to what page. In other words, where can I get information about "Code Reviews and Core PR Reviewers GitHub teams".
I have already moved the content from here [https://jenkins.io/participate/#review-changes] to the new page.
hacktoberfest. We're still inside the time window for hacktoberfest, and will be in that window for about 8 more hours. The hacktoberfest organizers accept any time zone where it is 31 Oct 2019. The day 31 Oct 2019 ends in Hawaii about 8 hours from now.