I wanted to ask 4 questions:
@urwa, thanks for the questions.
- When a reviewer suggests some changes, it is the same process all over again right? i.e. make changes in the local branch -> add -> commit -> push -> pull request. Right? I just wanted to be sure.
Yes, when a suggestion is given you can either apply the suggestion from the GitHub web page or you can apply it on your local copy. If you do it from the web page, then the commit is made directly on GitHub and you'll need to
git pull the change to your local copy. If you do it from your local copy, then the commit will need to be pushed to GitHub with
- Secondly to record this small contribution on outreachy, which URL should I use. The issue tracker, the pull request or something else.
I generally prefer to create a link in the issue tracker to the pull request and I like to reference the issue number as a link from the pull request. Readers of either are then only one click away from the matching information in the other location.
- On a priority scale, should I add the changes in this contribution first OR should I go ahead with another issue and get started on that, since I started late with the contribution process and I see a number of similar issues on issues.jenkin-ci.org/projects.
Review is asynchronous, so some number of pull requests are likely to be in progress at any one time. You're welcome to have multiple pull requests open at a time.
- I see a number of issues that have comments where some one shows willingness to do it but it is still unassigned. Is it okay to take that issue OR should I find another one. e.g. this one https://issues.jenkins-ci.org/projects/WEBSITE/issues/WEBSITE-667
Assigning an issue to yourself is a clear way to indicate that you intend to work on the issue. It is also a good way to notify others that are watching the issue. If one of those watching the issue has already started work on it, we hope that your notification of issue assignment will alert them. That notification informs them that the issue they forgot to assign themselves has now started work by someone else. They can then converse with you through the issue to decide who should work on the issue.
I am in the process of contributing to this issue.
In the description is it mentioned: There is some initial content on this page . I just want to know "this page" refers to what page. In other words, where can I get information about "Code Reviews and Core PR Reviewers GitHub teams".
I have already moved the content from here [https://jenkins.io/participate/#review-changes] to the new page.
hacktoberfest. We're still inside the time window for hacktoberfest, and will be in that window for about 8 more hours. The hacktoberfest organizers accept any time zone where it is 31 Oct 2019. The day 31 Oct 2019 ends in Hawaii about 8 hours from now.