Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Oleg Nenashev
    @oleg-nenashev
    @MarkEWaite As long as you merge them, this is fine. This is rather for closed ones and for PRs outside repos with the hacktoberfest topic
    Gavin Mogan
    @halkeye
    yea, so afaik, if the repo has hacktoberfest topic, and its merged = good
    if its merged with the label without the topic = good
    not merged, not labeled with the topic = good
    anything else is ignored?
    Oleg Nenashev
    @oleg-nenashev
    @halkeye "if its merged with the label without the topic = good" . No, this PRs will not be counted at the moment. hacktoberfest topic on a repo is a strong prerequisite
    Gavin Mogan
    @halkeye
    ahh okay
    so adding the label would just help for tracking then?
    Oleg Nenashev
    @oleg-nenashev
    Well, the proposal above is about asking the Hacktoberfest team to changetheir queries
    Otherwise we will have to negotiate with any maintainer about adding the Hacktoberfest topic... or to add them without asking
    Gavin Mogan
    @halkeye
    ooooo
    i totally misunderstood your comment sorry
    so your proposing "if its merged with the label without the topic = good" gotcha
    I was confused cause jenkins has a hacktoberfest team
    Gavin Mogan
    @halkeye
    Additionally, any pull request with the hacktoberfest-accepted label, submitted to any public GitHub repository, with or without the hacktoberfest topic, will be considered valid for Hacktoberfest.
    Oleg Nenashev
    @oleg-nenashev
    Looks like they have fixed it since the Saturday announcement :+1:
    It means that we are fine, no need to ask maintainers about adding a label.
    Elijah Shackelford
    @eshack94
    Would someone mind adding the hacktoberfest topic label to the job-restrictions plugin (https://github.com/jenkinsci/job-restrictions-plugin)? I opened a PR to it just now for doc migration, but I don't think it will count without the label.
    Gavin Mogan
    @halkeye
    oh its totally oleg's too :P
    Marky Jackson
    @markyjackson-taulia
    Hehehe
    Gavin Mogan
    @halkeye
    oleg-nenashev: didn't hacktoberfest team have triage access so we could add labels globally? or just in certain repos?
    Oleg Nenashev
    @oleg-nenashev
    @halkeye Nope. Last year I was handling the most of requests, and I was just using my admin permissions. This year is a bit more tricky, because we did not plan for manual label management. I am not sure @MarkEWaite has time and permissions for that. If not, I will add the PRs scrub to my queue
    Oleg Nenashev
    @oleg-nenashev
    Oleg Nenashev
    @oleg-nenashev
    I cleaned up the queue of pull requests
    Gavin Mogan
    @halkeye
    yea i can help but i can't label or create labels
    thats why i was thinking triage role so labels can be added to a PR. then one of us can write a script that adds hacktoberfest-accepted label to each repo's label list
    Tim Jacomb
    @timja
    The only global role is owner :p
    Oleg Nenashev
    @oleg-nenashev
    Anyway, it is not a big deal to triage pull requests and put labels
    Gavin Mogan
    @halkeye
    ok
    Mads Dam Jakobsen
    @MadsJakobsen
    I have a question regarding a PR I am working on for "Hidden Parameter plugin": jenkinsci/hidden-parameter-plugin#6. The purpose of the PR is to resolve the failing checks that occur for the current PRs in the repository. I checked for the error that occur: org.jvnet.hudson.test.JellyTestSuiteBuilder$JellyTestSuite(org.jvnet.hudson.test.junit.FailedTest), I found several entries in Jira with suggestions to update pom.xml. The current version for the plugin is 1.541. I mainly worked with python, so I am not well-versed in structuring a pom.xml or mvn.

    After checking the documentation at https://www.jenkins.io/doc/developer/plugin-development/updating-parent/ and https://github.com/jenkinsci/plugin-pom, I decided to follow the statement:

    java.level=8 and jenkins.version>2.204.1 are expected to be used for most plugins.

    After updating the pom.xml and updating the jelly templates, the checks pass, but I am unsure of this is the right approach, by updating the pom it does increase the required Jenkins version significantly.

    Gavin Mogan
    @halkeye
    should I make a probot that approved people can add labels? !label hacktoberfest-accepted as a comment?
    might also be good for triaging so people can move via bot to different repos
    A. Jard
    @aHenryJard
    hello, I am with you today :) do I have to do something on the PR I will do to be in the hacktober fest ? a label ?
    I am having fun here right now jenkinsci/jenkins#4994
    2 replies
    I have another person with me, it's a newbie so I am helping to add french translations, I hope it's ok too
    Oleg Nenashev
    @oleg-nenashev
    @/all Hi all! Tomorrow we plan to have an online meetup to talk about contributing to the Jenkins project and its documentation : https://www.meetup.com/Jenkins-online-meetup/events/273785870/
    Vlad Silverman
    @vsilverman
    One of questions in today's meetup was about sharing "How-To Fix Terminology" Readme. It is shared at https://github.com/vsilverman/jenkins.meetup/blob/main/How-To-Fix-Terminology.md
    Ben Rich
    @richbg
    @MarkEWaite feel free to assign jenkins-infra/jenkins.io#3779 to me I’m working on it, should have a PR up soon
    Mark Waite
    @MarkEWaite
    @richbg you can make my life much easier if you'll comment on that issue that you'd like to work on it.
    1 reply
    Once you do that, then I can list it as assigned to you (and others can see you're working on it even before I assign it to you)
    Reethik Prasad
    @reethikprasad
    Do we get some special swags from Jenkins if my PR has passed the reviewed period and also got merged
    Marky Jackson
    @markyjackson-taulia
    For Hacktoberfest, the Jenkins project does not give swag but I would be happy to send you some stickers. If you want to DM me your address.
    Oleg Nenashev
    @oleg-nenashev
    Yes, no special edition swag this year
    A. Jard
    @aHenryJard
    For PR with Jira, should I move Jira status to review when it's ready to review ?
    Oleg Nenashev
    @oleg-nenashev
    would be nice
    A. Jard
    @aHenryJard
    ok both Jira are in review status now.
    I also wanted to do a bit of French translation but to be honest the discussion on having an external plugin has dropped my motivation on that, is it a strong direction ? Or can I still propose some properties update ?
    Mark Waite
    @MarkEWaite
    I think that properties updates are the more common way to approach it. A separate plugin really needs a team that is dedicated to the effort and willing to continue working on it. Given the choice between outdated French translations and updates to properties with a better French translation, I think the users will prefer the better translation through property updates.
    1 reply