Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Elijah Shackelford
    @eshack94
    Would someone mind adding the hacktoberfest topic label to the job-restrictions plugin (https://github.com/jenkinsci/job-restrictions-plugin)? I opened a PR to it just now for doc migration, but I don't think it will count without the label.
    Gavin Mogan
    @halkeye
    oh its totally oleg's too :P
    Marky Jackson
    @markyjackson-taulia
    Hehehe
    Gavin Mogan
    @halkeye
    oleg-nenashev: didn't hacktoberfest team have triage access so we could add labels globally? or just in certain repos?
    Oleg Nenashev
    @oleg-nenashev
    @halkeye Nope. Last year I was handling the most of requests, and I was just using my admin permissions. This year is a bit more tricky, because we did not plan for manual label management. I am not sure @MarkEWaite has time and permissions for that. If not, I will add the PRs scrub to my queue
    Oleg Nenashev
    @oleg-nenashev
    Oleg Nenashev
    @oleg-nenashev
    I cleaned up the queue of pull requests
    Gavin Mogan
    @halkeye
    yea i can help but i can't label or create labels
    thats why i was thinking triage role so labels can be added to a PR. then one of us can write a script that adds hacktoberfest-accepted label to each repo's label list
    Tim Jacomb
    @timja
    The only global role is owner :p
    Oleg Nenashev
    @oleg-nenashev
    Anyway, it is not a big deal to triage pull requests and put labels
    Gavin Mogan
    @halkeye
    ok
    Mads Dam Jakobsen
    @MadsJakobsen
    I have a question regarding a PR I am working on for "Hidden Parameter plugin": jenkinsci/hidden-parameter-plugin#6. The purpose of the PR is to resolve the failing checks that occur for the current PRs in the repository. I checked for the error that occur: org.jvnet.hudson.test.JellyTestSuiteBuilder$JellyTestSuite(org.jvnet.hudson.test.junit.FailedTest), I found several entries in Jira with suggestions to update pom.xml. The current version for the plugin is 1.541. I mainly worked with python, so I am not well-versed in structuring a pom.xml or mvn.

    After checking the documentation at https://www.jenkins.io/doc/developer/plugin-development/updating-parent/ and https://github.com/jenkinsci/plugin-pom, I decided to follow the statement:

    java.level=8 and jenkins.version>2.204.1 are expected to be used for most plugins.

    After updating the pom.xml and updating the jelly templates, the checks pass, but I am unsure of this is the right approach, by updating the pom it does increase the required Jenkins version significantly.

    Gavin Mogan
    @halkeye
    should I make a probot that approved people can add labels? !label hacktoberfest-accepted as a comment?
    might also be good for triaging so people can move via bot to different repos
    A. Jard
    @aHenryJard
    hello, I am with you today :) do I have to do something on the PR I will do to be in the hacktober fest ? a label ?
    I am having fun here right now jenkinsci/jenkins#4994
    2 replies
    I have another person with me, it's a newbie so I am helping to add french translations, I hope it's ok too
    Oleg Nenashev
    @oleg-nenashev
    @/all Hi all! Tomorrow we plan to have an online meetup to talk about contributing to the Jenkins project and its documentation : https://www.meetup.com/Jenkins-online-meetup/events/273785870/
    Vlad Silverman
    @vsilverman
    One of questions in today's meetup was about sharing "How-To Fix Terminology" Readme. It is shared at https://github.com/vsilverman/jenkins.meetup/blob/main/How-To-Fix-Terminology.md
    Ben Rich
    @richbg
    @MarkEWaite feel free to assign jenkins-infra/jenkins.io#3779 to me I’m working on it, should have a PR up soon
    Mark Waite
    @MarkEWaite
    @richbg you can make my life much easier if you'll comment on that issue that you'd like to work on it.
    1 reply
    Once you do that, then I can list it as assigned to you (and others can see you're working on it even before I assign it to you)
    Reethik Prasad
    @reethikprasad
    Do we get some special swags from Jenkins if my PR has passed the reviewed period and also got merged
    Marky Jackson
    @markyjackson-taulia
    For Hacktoberfest, the Jenkins project does not give swag but I would be happy to send you some stickers. If you want to DM me your address.
    Oleg Nenashev
    @oleg-nenashev
    Yes, no special edition swag this year
    A. Jard
    @aHenryJard
    For PR with Jira, should I move Jira status to review when it's ready to review ?
    Oleg Nenashev
    @oleg-nenashev
    would be nice
    A. Jard
    @aHenryJard
    ok both Jira are in review status now.
    I also wanted to do a bit of French translation but to be honest the discussion on having an external plugin has dropped my motivation on that, is it a strong direction ? Or can I still propose some properties update ?
    Mark Waite
    @MarkEWaite
    I think that properties updates are the more common way to approach it. A separate plugin really needs a team that is dedicated to the effort and willing to continue working on it. Given the choice between outdated French translations and updates to properties with a better French translation, I think the users will prefer the better translation through property updates.
    1 reply
    Oleg Nenashev
    @oleg-nenashev
    Added a response template for PR which are suspected to be Hacktoberfest ones: https://github.com/jenkinsci/jenkins/pull/4993#issuecomment-712090455
    Oleg Nenashev
    @oleg-nenashev
    I will clean up the labeling queue today
    Andrea Mussap
    @andreamussap_gitlab
    @oleg-nenashev @MarkEWaite can you please label this with hacktoberfest-accepted? jenkins-infra/jenkins-infra#1590
    Oleg Nenashev
    @oleg-nenashev
    @andreamussap_gitlab yes, still on my todo list
    Oleg Nenashev
    @oleg-nenashev
    Cleaned up the hacktoberfest pull requests queue. We are at 113 pull requests now: https://github.com/search?q=org%3Ajenkinsci+org%3Ajenkins-infra+org%3Ajenkins-zh+org%3Astapler+is%3Apr+created%3A%3E2020-09-30+label%3Ahacktoberfest-accepted+-label%3Aspam&type=issues . Not all pull requests have been marked for Hacktoberfest though, and likely there are many more in repos with hacktoberfest topic
    Mark Waite
    @MarkEWaite
    That is a great result. @oleg-nenashev do I need to be labeling each Hacktoberfest pull request with the Hacktoberfest label so that the query is workable? Many pull requests to jenkins.io and to jenkins-infra have not been labeled.
    Gavin Mogan
    @halkeye
    MarkEWaite: if the repo doesn't have the hacktoberfest topic, the PR needs hacktoberfest-accepted label. Outside of jenkins i've been doing hacktoberfest-accepted to be on the safe side
    Mark Waite
    @MarkEWaite
    To confirm, is it enough to label either as hacktoberfest or as hacktoberfest-accepted or do I need both labels?
    Gavin Mogan
    @halkeye
    i'm not 100% on the label hacktoberfest. Topic (repo) of hacktoberfest, or hacktoberfest-accepted label (pr), one or the other is fine
    yea according to the website, hacktoberfest label (pr) doesn't do anything
    Oleg Nenashev
    @oleg-nenashev
    @MarkEWaite hacktoberfest-accepted only as we discussed with you on Oct 5
    2 replies
    I relabeled a few PRs which had 'hacktoberfest'
    Gavin Mogan
    @halkeye
    yea, the nice thing about labeling everything with hacktoberest-accepted is ease of finding all of them
    Oleg Nenashev
    @oleg-nenashev
    Well, only those PRs where authors reference hacktoberfest explicitly
    A. Jard
    @aHenryJard

    I may be late to the party :) but this one was part of hacktober fest too and does not have a label jenkinsci/jenkins#4995

    And also I am trying to work on that as part as hacktober fest too (it seems that it's not that easy to me to work as much as I would like... it may not be finished in October )
    jenkinsci/jenkins#5008
    jenkinsci/jenkins#5025
    I try to work on them today, I will keep you updated :)

    Marky Jackson
    @markyjackson-taulia
    I added a label
    1 reply
    A. Jard
    @aHenryJard
    oh and I forgot this one too jenkinsci/jenkins#5009
    3 replies