by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 08:36
    sladyn98 review_requested #127
  • 08:36
    sladyn98 opened #127
  • 08:24
    sladyn98 review_requested #126
  • 08:24
    sladyn98 opened #126
  • 07:54
    sladyn98 review_requested #125
  • 07:54
    sladyn98 opened #125
  • 07:48
    sladyn98 synchronize #106
  • 07:44
    sladyn98 synchronize #106
  • 06:57

    sladyn98 on master

    Add Update Center Service Test … (compare)

  • 06:57
    sladyn98 closed #105
  • 06:32
    sladyn98 synchronize #105
  • 06:13
    sladyn98 synchronize #105
  • Aug 10 17:54
    sladyn98 synchronize #105
  • Aug 10 17:32
    kwhetstone commented #123
  • Aug 10 17:24
    sladyn98 commented #123
  • Aug 10 16:49
    martinda commented #123
  • Aug 10 12:58
    sladyn98 commented #106
  • Aug 10 12:54
    sladyn98 commented #106
  • Aug 10 12:44
    sladyn98 commented #121
  • Aug 10 12:43
    sladyn98 commented #119
Sladyn
@sladyn98
Hey @kwhetstone Its going great https://issues.jenkins-ci.org/browse/INFRA-2700
Opened an issue for the infra team to track progress.
Kristin Whetstone
@kwhetstone
Awesome!
Sladyn
@sladyn98
Sladyn
@sladyn98
Applied all suggestions on the blog post it is ready to go in IMO :+1:
Sladyn
@sladyn98
You have 58 PMD violations
Reduced it to 58. Need some help to go further
Findbugs PR also done
Working on adding wiremock tests
Sladyn
@sladyn98
@/all Meeting in 5 min
Kristin Whetstone
@kwhetstone
Hi all, I'm sorry I missed the meeting as my alarm didn't go off. The blogpost looks ready to be scheduled for work. @sladyn98 how is the testing going?
Sladyn
@sladyn98
Ive just begun working with wiremock so would have a PR out by tommorrow
Kristin Whetstone
@kwhetstone
awesome!
Ticket for docker repo hosting
Sladyn
@sladyn98
jenkinsci/custom-distribution-service#105: Added wiremock tests here. Kindly have a look
Sladyn
@sladyn98
@oleg-nenashev Are you available for a code review next week. The team would like some feedback on the code in general
Sladyn
@sladyn98
jenkinsci/custom-distribution-service#88 : Added readme for the multiple environments
jenkinsci/custom-distribution-service#105 : Coverage for this class is now 100%
Sladyn
@sladyn98
Fixed PMD warnings
Oleg Nenashev
@oleg-nenashev
I might be available next week, but not until Tuesday
Sladyn
@sladyn98
Sounds Cool. I will send a doodle
Martin d'Anjou
@martinda
Hi @kwhetstone, can you please finalise your review of jenkins-infra/jenkins.io#3557 when you have a chance?
Martin d'Anjou
@martinda
Hi @sladyn98 , I did a round of reviews on the open PRs. I would lower the priority of the hosting activities (e.g. helm chart) and focus on completing tests and getting PRs merged (complete existing PR rather than start new ones). The PMD has revealed issues with throwing Exceptions, this needs to be fixed. If you have any question, doubt or concern, please don't hesitate to bug me or Kristin. Thanks Sladyn.
Sladyn
@sladyn98
@martinda Yeah agreed
Martin d'Anjou
@martinda
@sladyn98 I pushed a commit to fix the indentation sladyn98/custom-distribution-service#2 This should complete the work on PMD.
Sladyn
@sladyn98
@martinda Thanks that should do it
Kristin Whetstone
@kwhetstone
@sladyn98 I'm looking at most of the PRs and a lot of them are still failing or needing to be rebased. Is there anything we can help you with?
Sladyn
@sladyn98
@kwhetstone Yeah the EC2 instance terminates abruptly causing the build to fail most of the tiems
Sladyn
@sladyn98
Sladyn
@sladyn98
jenkinsci/custom-distribution-service#88 : Rebased and tested this it works fine
Sladyn
@sladyn98
Sladyn
@sladyn98
Also I am not too sure what to do with the controller tests since the update center logic already has 💯 coverage
Oleg Nenashev
@oleg-nenashev

Linkedin blog post draft:

Custom Jenkins Distribution build service - phase 2 project update by Sladyn Nunes: working Jenkins WAR file generation, support for configuration sharing with the community, better plugin search and filtering, Docker compose file for self-hosted service deployments. https://www.jenkins.io/blog/2020/08/09/custom-distribution-service-phase-2/

PTAL @sladyn98 @kwhetstone @martinda

#jenkins #gsoc #packaging #customization #docker

3 replies
Oleg Nenashev
@oleg-nenashev
@sladyn98 FYI, there are several typos in https://www.jenkins.io/blog/2020/08/09/custom-distribution-service-phase-2/ . It would be great if you could fix them
Sladyn
@sladyn98
Sure +1
Martin d'Anjou
@martinda

Also I am not too sure what to do with the controller tests since the update center logic already has 💯 coverage

The "100% coverage" metric only means that the lines of code have been visited during execution. It says nothing about the data content. For example if a string variable is set to the wrong value, the coverage will still say 100%, but the string value will be wrong.

That's why testing for NotNull on strings and other variables often yields 100% coverage but hides mistakes like 2+2=5. The value 5 is not null so the test passes, but it's wrong.
Martin d'Anjou
@martinda
@sladyn98 you can merge #120 whenever you want, I just wanted to make sure you see it before merging.
@kwhetstone @sladyn98 should we do a react code review with an SME?
Sladyn
@sladyn98
@martinda Agreed Lets do the code review
Should I focus on working only on the controller tests or fix some of the bugs you opened @martinda
Kristin Whetstone
@kwhetstone
@martinda, @baymac is the mentor who knows a lot about react. Parichay, can you come to a meeting for a react code review?
Martin d'Anjou
@martinda
@kwhetstone do you remember anything about printing the content of the update center to the console? Does the code still need to do that? It's quite a bit of data to dump and one one would seriously read it. We're wondering how jenkinsci/custom-distribution-service#122 can be addressed.
Kristin Whetstone
@kwhetstone
@martinda I bet it was a console log from when the "update center" was a subset used in initial development. If anything could be logged, it should be the time it was last updated. I would definitely not dump the entire thing
Sladyn
@sladyn98
jenkinsci/custom-distribution-service#88 This requires a final check
Added more tests