Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Gevorg Bagratunyan
    @GevBagratunyan_twitter
    Please help to figure it out. Thanks in advance
    uhafner
    @uhafner:matrix.org
    [m]
    This channel is about learning to contribute to Jenkins, not new to using Jenkins. I recommend trying out the general channel (jenkinsci/jenkins) for help.
    Gevorg Bagratunyan
    @GevBagratunyan_twitter
    OK, thanks
    Martin Pokorny
    @mPokornyETM
    Hi I am new java need some help here. https://github.com/jenkinsci/lockable-resources-plugin/pull/359#discussion_r1001994880 I am not sure if I do that in correct way. 🤔 can somebody look there. Thx
    6 replies
    duc
    @replikvlt:matrix.org
    [m]
    Hello, I'm curious, why doesn't Jenkins come with a custom tool installer in Global Tools but instead just JDK and Maven?
    Perhaps I could contribute an installer for custom tool, which would improve automatic worker configuration, but I want to know if there is a good reason why it is not yet included?
    Mark Waite
    @MarkEWaite
    Global tool installers and customer tool installers are good for static agents and when carefully configured they can also be used with ephemeral (cloud) agents. If they are not carefully configured, ephemeral (cloud) agents with tool installers can place an unjustified load on the servers of the organization that is providing the tools. For example, if agents are used only once and then destroyed, then that agent needs to already include the tools it needs, pre-installed on the agent. If the tools are not preinstalled on the agent, then every agent that starts will download the tool it needs (100+ MB JDK as an example). That wastes time for the user and wastes bandwidth for the organization that provides the tool.
    halkeye
    @halkeye:g4v.dev
    [m]
    I thought generic zip installers were built in no?
    Mark Waite
    @MarkEWaite
    Generic zip installer for a JDK is available from the Oracle JDK installer and the Eclipse Temurin installer. I wasn't aware of them being available without at least one of those. Not sure on Maven
    replikvlt
    @replikvlt:matrix.org
    [m]
    Global tool installers and customer tool installers are good for static agents seems good to me
    In my current project workflow I have defined a JDK installer which installs from zip and few that use bash script and package manager, however JDK installer defines JAVA_HOME variables, wchich is undesirable when installing something other than JDK, and also checks for a few JDK installation specific files to verify it was installed successfully
    Also with this, suboptimal, approach when you need to use both your custom tool and JDK in the same step, it gets complicated because they both would create their JAVA_HOME and therefore redefine one another (roughly speaking)
    duc
    @replikvlt:matrix.org
    [m]

    All I want is something like the JDK installer using zip or bash script but without defining JAVA_HOME and with its own name in tools block e.g.

    tools {jdk 'whatever, custom 'emacs'}

    I've looked into plugins in hope to find something like that, but a few that provide that sort of functionality are either unmaintained or are not pipeline ready/compatible :(
    duc
    @replikvlt:matrix.org
    [m]
    I'm thinking about copying core/src/main/java/hudson/model/JDK.java into something like core/src/main/java/hudson/model/Tool.java and getting rid of all JDK specific things
    duc
    @replikvlt:matrix.org
    [m]
    of course handling all the other things required to make it work, but it's the general idea
    halkeye
    @halkeye:g4v.dev
    [m]
    oh looks like it got moved to an external plugin - https://plugins.jenkins.io/generic-tool/
    there's actually a lot of them. I don't think a new one is needed
    Łukasz Lesiak
    @lukasz-lesiak
    Hey, can anyone take a look at jenkinsci/bitbucket-branch-source-plugin#654
    Martin Pokorny
    @mPokornyETM
    @lukasz-lesiak Hi I hit there some comment, I do not use the plugin, so I am not really permitted for review. But there some some general things. You can accept or ignore it. Is up to you.
    Łukasz Lesiak
    @lukasz-lesiak
    @mPokornyETM Thank you for review. I've applied changes from most of your comments.
    Vandit Singh
    @Vandit1604
    hey can you only run tests using mvn test or there are other commands and ways to test before i create a PR. if there is a docuement for this please mention it as well
    Mark Waite
    @MarkEWaite

    There are several different ways that I run tests.

    While creating tests, it is common that I run the tests in my IDE so that I can confirm the statements that I'm trying to reach with the test are actually being reached. Breakpoints in the debugger are a convenient way to do that.

    While checking if a test result is repeatable, I run that single test with the command mvn -Dtest=ClassName@NameOfTest test.

    While checking if a test class is passing, I run all the tests in a test class with the command mvn -Dtest=ClassName test.

    While checking if the entire set of tests are passing, I run all the tests with the command mvn verify (because I like to know that static analysis checks like spotbugs are also passing).

    When I want to see code coverage reporting, I run all the tests with the command mvn -P enable-jacoco clean test jacoco:report.

    Vandit Singh
    @Vandit1604
    Okay Thanks so if i'm changing code in a file i can just use mvn -Dtest=ClassName@NameOfTest test where ClassName will be classname of the test for that OR class name of the files in which i changed something. Im sorry if that is something i should know im new to opensource and im trying to get to know how things work and the workflow followed at jenkins
    Mark Waite
    @MarkEWaite

    If I am working on the Jenkins docker plugin (up for adoption, good choice of a plugin to help), I run the DockerDisabledTest with the command mvn clean -Dtest=DockerDisabledTest verify.

    Plugin is at https://github.com/jenkinsci/docker-plugin

    Vandit Singh
    @Vandit1604
    @MarkEWaite i want to start contributing to a plugin. what would be a good place to start with good first issues
    1 reply
    Martin Pokorny
    @mPokornyETM
    @MarkEWaite it will be cool, when new contributors has filled some skill page. The regular contributors has chance to contact him for new project. Or general a contributor list with skills and link to github link. Maybe it is fine idea for new GSoC.
    2 replies
    halkeye
    @halkeye:g4v.dev
    [m]

    someone could easily make a "I'm interesting in these topics" type page, and the page would respond with some projects. seems like a pretty simple static website to me. Let people update a yaml or json document if they want their project to be listed.

    its not something i'd work on, but if @iqbalrohail wanted to make it, i don't think its a bad idea

    Rohail Iqbal
    @iqbalrohail
    @halkeye:g4v.dev sure I would working on it
    Rohail Iqbal
    @iqbalrohail
    Could you guide more on what should I'll be working on ? Like I should make a list of Jenkins projects for new constributors right and redirect them to the project repositories
    11 replies
    halkeye
    @halkeye:g4v.dev
    [m]
    @iqbalrohail: it's not a bad idea. It seems like a huge undertaking. 99.9% of Jenkins project is java and maven. I'm not sure where you would get a list of activities though.
    Rohail Iqbal
    @iqbalrohail
    @halkeye:g4v.dev with the activities I mean that let's say if someone make a PR to any repo than it's it's activity , we can add time stamps of activities as well , like who accepted that PR and when , hope so I am clear on this ...
    Nick
    @NickWemekamp
    I have a fix for a bug in Jenkins (see my last comment in: https://issues.jenkins.io/browse/JENKINS-68999) and am willing to make a PR for it. But maybe someone can review my proposed changes before I make a PR. Because I don't know how my proposed changes would affect other plugins
    halkeye
    @halkeye:g4v.dev
    [m]
    @NickWemekamp: that's what a pr is. You propose changes and other people can review it.
    Nick
    @NickWemekamp
    @halkeye:g4v.dev Yes makes sense :)
    Vandit Singh
    @Vandit1604
    can someone review this PR
    Martin Pokorny
    @mPokornyETM
    There is similar pr jenkinsci/conditional-buildstep-plugin#49 maybe you shall merge your changes in the #49. And then let review only #49. I can't approve it. Because I am not code owner. But the changes LGTM
    Mark Waite
    @MarkEWaite
    Reviewed and merged. Thanks for the pull request @Vandit1604
    Vandit Singh
    @Vandit1604
    Hey all, i was working on this issue for past few weeks but i was unable to reproduce it. so i wanted to know does this issue still persists as i tried all the things i could think of but i couldn't recreate the java.lang.ClassCastException.
    Martin Pokorny
    @mPokornyETM
    I think the issue can be closed. There are too less information and requester doesn't answer.
    Penchal
    @Pnchal
    Hi
    Im getting "Cannot resolve symbol 'Messages' " error when im trying HelloWorldBuilder plugin.
    can someone suggest
    Penchal
    @Pnchal
    image.png
    Ulli Hafner
    @uhafner:matrix.org
    [m]
    The messages are generated during the build: run mvn verify in your console and after that import the project into IntelliJ
    If not done automatically: mark the folder target/generated-sources as a source folder in IntelliJ.
    Penchal
    @Pnchal
    Thanks @uhafner:matrix.org