Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Tim Jacomb
    @timja
    How to rebuild this? https://hub.docker.com/r/jenkins/core-pr-tester hasn't been updated in 7 month.
    Alex Earl
    @slide
    I don't see it on trusted.ci, so it must have been pushed manually by someone?
    There is this, but I don't think ci.j.io has creds to push to the Jenkins org on dockerhub https://ci.jenkins.io/job/Core/job/core-pr-tester/
    Yeah, it doesn't look like it pushes, just tags
    ah, there are builds on dockerhub, but since the source hasn't changed, it hasn't been build
    Tim Jacomb
    @timja
    ah ok, I think it was intended that is runs more often as it's supposed to mimic recent core and have the core layers pre-cached
    and that's not happening any more because lots of dependency changes in the last few months
    what's the best way to fix?
    Alex Earl
    @slide
    @timja that I don't know
    Gavin Mogan
    @halkeye
    probably ask batmat or infra people to give it a nudge on docker hub
    Tim Jacomb
    @timja
    nudged on irc
    Olblak
    @olblak
    @timja I triggered the build from docker hub but I couldn't find a quick and easy to define a crontask
    Tim Jacomb
    @timja

    Yup, oleg and I discussed after and looks like one approach would be to change it to :

    FROM jenkins/jenkins:2.205

    and then have dependabot updating it

    possibly even with automerge enabled for dependabot on that repo?
    so no human intervention needed?
    Oleg Nenashev
    @oleg-nenashev
    yup
    Jim Crowley
    @james-crowley
    @slide For the junit plugin you mentioned, are you just going to swap them out in the bats tests?
    I am not familiar with bats, so I am kind of loss when looking at the test cases
    Alex Earl
    @slide
    @james-crowley That's what I am looking at doing, removing the maven-plugin and switching to using junit
    I am on a business trip the rest of this week, so I am not sure if I will get it done this week
    Mark Waite
    @MarkEWaite
    @james-crowley that's the idea that I was considering . I like the suggestion of junit from @slide . The tests in that section of the code are focused on the plugin upgrade process, not on a specific plugin. The test chose a specific plugin ('maven') and that plugin's internal availability has changed inside Jenkins. The idea is to change to a different specific plugin that hasn't been through that recent change in Jenkins.
    Alex Earl
    @slide
    I have one test left failing and I am not sure why right now
    Mark Waite
    @MarkEWaite
    That is wonderful @slide . Is your branch on a public repository in case Jim or others can assist with guesses and further diagnosis?
    Alex Earl
    @slide
    Not yet, I need to push it to a branch
    Jim Crowley
    @james-crowley
    @slide That is amazing! What test was it? Let me know when you get a chance to push it. No rush.
    @slide Were you the one who made the bats unit tests for Jenkins?
    Alex Earl
    @slide
    No, it definitely wasn't me
    I think it was Carlos (https://github.com/carlossg)
    Mark Waite
    @MarkEWaite
    Reminder that there today's Platform SIG meeting is cancelled. We'll meet in two weeks, Dec 19, 2019, at the usual time. Meeting agenda for the Dec 19, 2019 meeting is at https://docs.google.com/document/d/1bDfUdtjpwoX0HO2PRnfqns_TROBOK8tmP6SgVhubr2Y/edit#heading=h.mw7poain942t .
    Jim Crowley
    @james-crowley
    @slide Do you need anything special to utilize Windows Docker Images? I am revamping the Docker test suite on Adopt, and need to add Windows support. But have never touched Docker + Windows
    Alex Earl
    @slide
    @james-crowley You have to have a windows machine with docker support
    Jim Crowley
    @james-crowley
    oh boy, this should be fun. I'll have to track down a Windows machine. :)
    Tim Jacomb
    @timja
    use the cloud :D
    that's what i always do for the few times i ever have to touch windows
    Jim Crowley
    @james-crowley
    @timja Good suggestion. I might reach back out to the Adopt team and see if I can use one of their existing machines.
    Alex Earl
    @slide
    GitHub Actions support docker on the Windows machines
    Jim Crowley
    @james-crowley
    @slide Hopefully some of the j9 team will assist you in the windows nano server. Looks like they bumped the priority of the issue up. No rush on your end, I know your busy this week.
    Alex Earl
    @slide
    Here is my WIP PR for the test failures jenkinsci/docker#910
    Jim Crowley
    @james-crowley
    :thumbsup:
    Jim Crowley
    @james-crowley
    Submitted a PR for Adopt to add CentOS and ClefOS support, AdoptOpenJDK/openjdk-docker#253
    Alex Earl
    @slide
    :+1:
    Alex Earl
    @slide
    ok, the "clean work directory" is not working correctly for some reason
    on the docker stuff
    Jim Crowley
    @james-crowley
    @slide You talking abou your PR, jenkinsci/docker#910 ?
    Jim Crowley
    @james-crowley
    @MarkEWaite I know you mentioned you have a good test pipeline for Jenkins. The Adopt team is using Jenkins as one of their test. They are building it with Maven and running mvn --batch-mode surefire:test -Denforcer.fail=false. Is there a better thrasher or Java test with Jenkins we can do? The point is just to make sure there is no bugs or major issues with AdoptOpenJDK.
    Here is the full snippet
    echo "Build jenkins by using mvn \"mvn clean install -pl war -am -DskipTests\"" && \
    mvn --batch-mode clean install -pl war -am -DskipTests -Denforcer.fail=false
    
    echo "Building jenkins completed"
    
    echo "Run jenkins test phase alone with cmd: \"mvn surefire:test\"" && \
    mvn --batch-mode surefire:test -Denforcer.fail=false
    set +e
    echo "Executing jenkins tests alone completed"
    find ./ -type d -name 'surefire-reports' -exec cp -r "{}" /testResults \;
    Alex Earl
    @slide
    @james-crowley yes
    if I do an ls as part of the clean workspace, it seems to work better
    Alex Earl
    @slide
    I'm not sure why it worked before