Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Kristin Whetstone
@kwhetstone
Do we want to merge in #21 ? It's pretty much all approved with examples. The documentation can get out there right now
Oleg Nenashev
@oleg-nenashev
@gautamabhishek46 do you need me on the call today? If no, I will probably skip it if you do not mind
@/all also https://groups.google.com/forum/#!topic/jenkinsci-dev/aDdWsy2fxME from @abayer
Oleg Nenashev
@oleg-nenashev
Ahh, we moved it to Thursday
Martin d'Anjou
@martinda
Ahh, me too got confused
I was there in the hangout waiting like a lost kid
Abhishek Gautam
@gautamabhishek46
@grandvizier @oleg-nenashev will you be available today ?
@martinda and @kwhetstone are in the call.
grandvizier
@grandvizier
Yeah, sorry, I'll try to call in now
Ok, no, 5 more minutes
grandvizier
@grandvizier
wanted to add this link here for easier finding
https://issues.jenkins-ci.org/secure/RapidBoard.jspa?rapidView=441&view=planning&selectedIssue=JENKINS-51941&epics=visible&selectedEpic=JENKINS-52452
it's of the scrum board for phase 3, with the priority of the tasks ordered - should be helpful @gautamabhishek46 to determine what to work on
Abhishek Gautam
@gautamabhishek46
Yesterday we decided to change the name of "Jenknsfile.yaml" to "spray.yaml" (simple pull request as yaml, suggestion of @martinda)
Oleg Nenashev
@oleg-nenashev
hmm, ok
I would rather prefer build.yml or so, but as you wish
Martin d'Anjou
@martinda
The name change is driven by @abayer's post to the mailing list, i.e. the need to future proof and not interfere with a potential future core Pipeline YAML support.
We came up with a list of different suggestions, ranging from funny to ordinary, pray.yaml (Pull-Request As Yaml), spray.yaml (simple pull-request as yaml), sprp.yaml (simple pull-request plugin), etc.
build.yml works too
Martin d'Anjou
@martinda
I feel we should avoid generic names or broad names. The file will work with the plugin, so it makes sense to name it after the plugin. This way we lower the possibility of clash with future plugins, future core features and future build systems.
In any case, the name should be configurable for cases where the default name is not possible.
Kristin Whetstone
@kwhetstone
Hey all, I know we've had some discussions in the past about having the code reviewed by a list of known approvers. It looks like there's a sort of baked-in feature in GitHub which could be useful to look at https://help.github.com/articles/about-codeowners/
Really specific to just GitHub, but pretty cool.
Abhishek Gautam
@gautamabhishek46
@kwhetstone thanks
Martin d'Anjou
@martinda
@gautamabhishek46 how are things going? What are you working on today?
Abhishek Gautam
@gautamabhishek46
Hi, @martinda , Things are not good. I am a bit stressed from last 2-3 days. From Saturday applications for different companies started flowing in my college for placements, and the online tests are going to start from tomorrow morning.
I looked at the the class on friday but can't able to figure out how to use it.
I launched Jenkins instance on google cloud for debugging the plugin and tried to set up remote debug but I was unsuccessful in that.
Abhishek Gautam
@gautamabhishek46
Also there will an online test each day this week.
grandvizier
@grandvizier
hmm, I'm not sure how to help with the remote debugging - I'm guessing that you don't have any way to reach your local instance externally - your ISP doesn't provide you with an external IP address that you can provide to Github for forwarding hook events??
that class is used to register your plugin to github, so that your Jenkins instance will be able to receive the webhook events - that class is pretty straight forward in that is all it does
then, for example, there is an event subscriber that will act upon the events from github
https://github.com/jenkinsci/github-branch-source-plugin/blob/master/src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestGHEventSubscriber.java
with the onEvent action you'd then be able to get the repository info from the meta data that you had wanted before in your first attempt
Martin d'Anjou
@martinda
@gautamabhishek46 https://hangouts.google.com/hangouts/_/wxzbmoao6nhfhp66i4pxmfg5jme
Martin d'Anjou
@martinda
@/all anyone else joining the call?
Abhishek Gautam
@gautamabhishek46
@martinda are you in the room ?
Martin d'Anjou
@martinda
@gautamabhishek46 yes and so is Kristin
Martin d'Anjou
@martinda
@gautamabhishek46 please post the doodle links here. Thanks.
Kristin Whetstone
@kwhetstone
Man, there's a lot of action in terms of forking this plugin! Maybe we should also add a link to Jenkins Jira in the README so people can see the progress as well as future planned tasks?
Also, I know for those doodle surveys, some of them are for timeslots that are fast approaching.... Is there a chosen time for those meetings?
Kristin Whetstone
@kwhetstone
Lastly, (maybe :) ) just for testing out the GitHub hooks and you're looking for an external IP address, you should check out https://ngrok.com/ It's a really simple way to setup a connection from your machine. I use the command line tool if I just need something real quick, and spin it down when I'm done.
Oleg Nenashev
@oleg-nenashev
@gautamabhishek46 https://wiki.jenkins.io/display/JENKINS/Defining+a+new+extension+point
Oleg Nenashev
@oleg-nenashev
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/authorizing-access-to-an-instance.html
@gautamabhishek46 https://stackoverflow.com/questions/21065922/how-to-open-a-specific-port-such-as-9090-in-google-compute-engine
grandvizier
@grandvizier
quick search for alternatives to ngrok: Serveo, PageKite
Martin d'Anjou
@martinda
@kwhetstone @oleg-nenashev PR #23 is awaiting your approval. IMO it is a trivial PR so very little to review.
I should have talked about this at the meeting, but do we need all 4 mentors to approve all the PRs? I don't think so at least not for PR #23
So I would propose that when TWO mentors agree to merge the PR, the other reviewers are not required.
Oh, I think it is already configured like that... sorry.
Kristin Whetstone
@kwhetstone
@martinda I rereviewed it. It should be ok to merge now.
Martin d'Anjou
@martinda
@/all Capturing an action item following our meeting with Andrew earlier today https://issues.jenkins-ci.org/browse/JENKINS-52843
Abhishek Gautam
@gautamabhishek46
@/all While running tests in am getting below exception.