Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Martin d'Anjou
@martinda
build.yml works too
I feel we should avoid generic names or broad names. The file will work with the plugin, so it makes sense to name it after the plugin. This way we lower the possibility of clash with future plugins, future core features and future build systems.
In any case, the name should be configurable for cases where the default name is not possible.
Kristin Whetstone
@kwhetstone
Hey all, I know we've had some discussions in the past about having the code reviewed by a list of known approvers. It looks like there's a sort of baked-in feature in GitHub which could be useful to look at https://help.github.com/articles/about-codeowners/
Really specific to just GitHub, but pretty cool.
Abhishek Gautam
@gautamabhishek46
@kwhetstone thanks
Martin d'Anjou
@martinda
@gautamabhishek46 how are things going? What are you working on today?
Abhishek Gautam
@gautamabhishek46
Hi, @martinda , Things are not good. I am a bit stressed from last 2-3 days. From Saturday applications for different companies started flowing in my college for placements, and the online tests are going to start from tomorrow morning.
I looked at the the class on friday but can't able to figure out how to use it.
I launched Jenkins instance on google cloud for debugging the plugin and tried to set up remote debug but I was unsuccessful in that.
Abhishek Gautam
@gautamabhishek46
Also there will an online test each day this week.
grandvizier
@grandvizier
hmm, I'm not sure how to help with the remote debugging - I'm guessing that you don't have any way to reach your local instance externally - your ISP doesn't provide you with an external IP address that you can provide to Github for forwarding hook events??
that class is used to register your plugin to github, so that your Jenkins instance will be able to receive the webhook events - that class is pretty straight forward in that is all it does
with the onEvent action you'd then be able to get the repository info from the meta data that you had wanted before in your first attempt
Martin d'Anjou
@martinda
Martin d'Anjou
@martinda
@/all anyone else joining the call?
Abhishek Gautam
@gautamabhishek46
@martinda are you in the room ?
Martin d'Anjou
@martinda
@gautamabhishek46 yes and so is Kristin
Martin d'Anjou
@martinda
@gautamabhishek46 please post the doodle links here. Thanks.
Kristin Whetstone
@kwhetstone
Man, there's a lot of action in terms of forking this plugin! Maybe we should also add a link to Jenkins Jira in the README so people can see the progress as well as future planned tasks?
Also, I know for those doodle surveys, some of them are for timeslots that are fast approaching.... Is there a chosen time for those meetings?
Kristin Whetstone
@kwhetstone
Lastly, (maybe :) ) just for testing out the GitHub hooks and you're looking for an external IP address, you should check out https://ngrok.com/ It's a really simple way to setup a connection from your machine. I use the command line tool if I just need something real quick, and spin it down when I'm done.
Oleg Nenashev
@oleg-nenashev
grandvizier
@grandvizier
quick search for alternatives to ngrok: Serveo, PageKite
Martin d'Anjou
@martinda
@kwhetstone @oleg-nenashev PR #23 is awaiting your approval. IMO it is a trivial PR so very little to review.
I should have talked about this at the meeting, but do we need all 4 mentors to approve all the PRs? I don't think so at least not for PR #23
So I would propose that when TWO mentors agree to merge the PR, the other reviewers are not required.
Oh, I think it is already configured like that... sorry.
Kristin Whetstone
@kwhetstone
@martinda I rereviewed it. It should be ok to merge now.
Martin d'Anjou
@martinda
@/all Capturing an action item following our meeting with Andrew earlier today https://issues.jenkins-ci.org/browse/JENKINS-52843
Abhishek Gautam
@gautamabhishek46
@/all While running tests in am getting below exception.
java.nio.channels.ClosedSelectorException
    at sun.nio.ch.SelectorImpl.keys(SelectorImpl.java:68)
    at org.jenkinsci.remoting.protocol.IOHub.getThreadNameBase(IOHub.java:426)
    at org.jenkinsci.remoting.protocol.IOHub.access$200(IOHub.java:69)
    at org.jenkinsci.remoting.protocol.IOHub$IOHubSelectorWatcher.run(IOHub.java:536)
    at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
    at java.lang.Thread.run(Thread.java:748)
Oleg Nenashev
@oleg-nenashev
It is the agent termination trace. Could you please proveide the full stacktrace?
Abhishek Gautam
@gautamabhishek46
Although all tests are successfully passed.
full stack trace.
=== Starting env(io.jenkins.plugins.sprp.impl.EnvironmentTest)
   0.166 [id=13]    INFO    o.jvnet.hudson.test.WarExploder#explode: Picking up existing exploded jenkins.war at /mnt/CC0091D90091CB3A/workspace/OpenSource/jenkinsOrg/simple-pull-request-job-plugin/target/jenkins-for-test
   1.088 [id=13]    INFO    o.jvnet.hudson.test.JenkinsRule#createWebServer: Running on http://localhost:35823/jenkins/
   2.560 [id=21]    INFO    jenkins.InitReactorRunner$1#onAttained: Started initialization
   2.589 [id=20]    INFO    jenkins.InitReactorRunner$1#onAttained: Listed all plugins
   5.338 [id=19]    INFO    jenkins.InitReactorRunner$1#onAttained: Prepared all plugins
   5.346 [id=21]    INFO    jenkins.InitReactorRunner$1#onAttained: Started all plugins
   6.819 [id=23]    INFO    jenkins.InitReactorRunner$1#onAttained: Augmented all extensions
   6.850 [id=26]    INFO    jenkins.InitReactorRunner$1#onAttained: Loaded all jobs
   7.142 [id=25]    INFO    jenkins.InitReactorRunner$1#onAttained: Completed initialization
   7.406 [id=13]    INFO    jenkins.model.Jenkins#cleanUp: Stopping Jenkins
   7.430 [id=53]    WARNING    h.u.ExceptionCatchingThreadFactory#uncaughtException: Thread Computer.threadPoolForRemoting [#2] terminated unexpectedly
java.nio.channels.ClosedSelectorException
    at sun.nio.ch.SelectorImpl.keys(SelectorImpl.java:68)
    at org.jenkinsci.remoting.protocol.IOHub.getThreadNameBase(IOHub.java:426)
    at org.jenkinsci.remoting.protocol.IOHub.access$200(IOHub.java:69)
    at org.jenkinsci.remoting.protocol.IOHub$IOHubSelectorWatcher.run(IOHub.java:536)
    at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
    at java.lang.Thread.run(Thread.java:748)
WARN: The method class org.apache.commons.logging.impl.SLF4JLogFactory#release() was invoked.
WARN: Please see http://www.slf4j.org/codes.html#release for an explanation.
   7.677 [id=13]    INFO    jenkins.model.Jenkins#cleanUp: Jenkins stopped
=== Starting checkCustomSection(io.jenkins.plugins.sprp.impl.CustomSectionGeneratorTest)
   0.019 [id=58]    INFO    o.jvnet.hudson.test.JenkinsRule#createWebServer: Running on http://localhost:39033/jenkins/
   0.088 [id=65]    INFO    jenkins.InitReactorRunner$1#onAttained: Started initialization
   0.098 [id=71]    INFO    jenkins.InitReactorRunner$1#onAttained: Listed all plugins
   0.313 [id=70]    INFO    jenkins.InitReactorRunner$1#onAttained: Prepared all plugins
   0.316 [id=67]    INFO    jenkins.InitReactorRunner$1#onAttained: Started all plugins
   0.650 [id=64]    INFO    jenkins.InitReactorRunner$1#onAttained: Augmented all extensions
   0.661 [id=64]    INFO    jenkins.InitReactorRunner$1#onAttained: Loaded all jobs
   0.782 [id=68]    INFO    jenkins.InitReactorRunner$1#onAttained: Completed initialization
   1.094 [id=58]    INFO    jenkins.model.Jenkins#cleanUp: Stopping Jenkins
   1.162 [id=58]    INFO    jenkins.model.Jenkins#cleanUp: Jenkins stopped
Oleg Nenashev
@oleg-nenashev
@gautamabhishek46 Just ignore that, this is a known issue in Mock agent termination in the test framework
Abhishek Gautam
@gautamabhishek46
:+1:
Oleg Nenashev
@oleg-nenashev
There should be ticket somewhere, but it may take a while to find it
Abhishek Gautam
@gautamabhishek46
@oleg-nenashev Thanks, I was just wondering if I should worry about this.
Oleg Nenashev
@oleg-nenashev
@gautamabhishek46 Hi, could you please respond to https://doodle.com/poll/wkfw9ynysu5n3tuq ?
Oleg Nenashev
@oleg-nenashev
Also @kwhetstone @martinda ^
Oleg Nenashev
@oleg-nenashev
@gautamabhishek46 how is it going on your side? Any help needed?
Abhishek Gautam
@gautamabhishek46
In the last meet it suggested that I should start working on blog and project report and hence I have started to work on them
Oleg Nenashev
@oleg-nenashev
Blog and project report will unlikely take more than 1 day alltogether, right?
maybe not
grandvizier
@grandvizier
I don't think I can make the call today. It's 37° (98F) and there's no air conditioning in our apartment.