Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Tim Jacomb
    @timja
    easier to debug locally imo without having to use docker, you can update jelly files and groovy and no restart required
    Zbynek Konecny
    @zbynek
    image.png
    image.png
    @uhafner @FelixQueiruga_twitter it seems the layout conflicts discussed in https://groups.google.com/forum/#!searchin/jenkinsci-dev/layout$20bootstrap|sort:date/jenkinsci-dev/ysovVQgmqsc/Uq_LL9kcAAAJ happened again, this time for footer.
    Tim Jacomb
    @timja
    is that only on pages where warnings-ng has overridden the layout @zbynek ?
    Zbynek Konecny
    @zbynek
    yes, exactly
    (technically not warnings-ng but bootstrap4-api)
    Ullrich Hafner
    @uhafner
    Hmm, seems that I need to update the layout in bootstrap plugin as well. Hopefully the new version is backward compatible with the 2.222 changes
    I should try to find some spare time to tackle https://issues.jenkins-ci.org/browse/JENKINS-61326
    Félix Queiruga
    @FelixQueiruga_twitter
    FYI there's 1 more change to layout commenting out YUI code for buttons. I don't think it will affect warnings-ng too much but I'm not really sure
    Wadeck Follonier
    @Wadeck

    Just watched the recording, the revisted style for buttons seems really nice. Great job :)

    Concerning the yui-button CSS class, if we are not proposing a new CSS class without legacy luggage at this point, we will never do it and thus keep the yui stuff around even if there is no longer any yahoo stuff. I propose you to keep the yui-button CSS class for backward compatibility that's nice, but also add new CSS class for new stuff / new code. Those new classes will be used by the Jelly template to avoid generating legacy yui-xxx.
    If you name the UI revamp, with something more fancy than "v2", an abbreviation could be used to prefix such new classes. This will ease the maintenance of existing code.

    9 replies
    Sladyn
    @sladyn98
    Tried running the debugger again. Got this warning before it errored out on intellij
    WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireMavenVersion failed with message:
    3.5.4+ required to use Incrementals.
    Screenshot from 2020-04-22 17-24-11.png
    Ullrich Hafner
    @uhafner
    Yes, you need to use a more recent Maven version. Your test is using 3.3.9, current version is 3.6.3.
    Sladyn
    @sladyn98
    @uhafner that worked.. awesome thanks :) . Let me try getting that ancestor list now :cry:
    Sladyn
    @sladyn98
    I moved the generateBreadcrumbs function to Functions.java where most of the views are generated,
    and the line in jelly where it is called is <j:forEach var="anc" items="${h.generateBreadCrumbs()}">
    My generateBreadCrumbs function just returns a ancestor list and does nothing fancy for now.
    List/*<AncestorImpl>*/ ancestors = currentRequest.ancestors;
    but the function just does not get called I tried putting a breakpoints to analyze but it still does not get called so those breakpoints never get hit:(
    1 reply
    Gavin Mogan
    @halkeye
    jsa34
    @jsa34
    image.png
    Hello, just thought I would post on here I noticed with the latest release the button fonts look different on the plugins update page:
    Using CentOS (Linux) system fonts
    Tim Jacomb
    @timja
    do you like that / not ?
    (the buttons were reworked in the last release
    jsa34
    @jsa34
    I like the new buttons, but the two buttons next to each other that are almost identical, with same button styling but different fonts looks jarring
    Tim Jacomb
    @timja
    thanks for the feedback :)
    jsa34
    @jsa34
    No worries - the "Check now" seems to be the only button I have come across so far that doesn't seem to be using the Arial font, which has led to this:
    image.png
    vs
    image.png
    Didn't know if this was intended or not
    Tim Jacomb
    @timja
    it probably has some special styling on it
    unintentionally now
    Félix Queiruga
    @FelixQueiruga_twitter
    Great catch @jsa34 . So basically buttons are not inheriting the body font-family, we need to add buttons to this line https://github.com/jenkinsci/jenkins/blob/3b85c0a877d97c4c8b5b24605974cce52223a4b0/war/src/main/less/base/style.less#L65
    It's not happening for the "Check Now" button because it's actually a hyperlink under the hood.
    Can you please create a ticket on issues.jenkins-ci.org? This is important in case we need to do some sort of backporting. Feel free to also create the PR with the solution yourself
    @timja the searchbox on the update manager is also using a different font, Roboto
    Tim Jacomb
    @timja
    is that because its using the same font as the header ?
    or is it because the header search was using that font at the time and it changed?
    Félix Queiruga
    @FelixQueiruga_twitter
    The second one
    Tim Jacomb
    @timja
    :thumbsup:
    jsa34
    @jsa34
    @FelixQueiruga_twitter will do so now :)
    Félix Queiruga
    @FelixQueiruga_twitter
    :clap:
    Ullrich Hafner
    @uhafner
    @zbynek @FelixQueiruga_twitter Maybe we should add a boolean property in layout.jelly, whether to load BS3 grid or not… Then I do not patch the bootstrap library for each new layout change. I don’t think that I find spare time for https://issues.jenkins-ci.org/browse/JENKINS-61326 until semester end.
    1 reply
    Félix Queiruga
    @FelixQueiruga_twitter
    mmm yeah, that may be the pragmatic option
    Daniel Beck
    @daniel-beck
    Yall need to check out the plugin manager in 2.234, the popularity sorting is really nice :)
    Also, the tooltips for help buttons are great!
    Ullrich Hafner
    @uhafner
    Popularity? A real one or the fake one from the number of installations?
    Daniel Beck
    @daniel-beck
    fake one
    still useful to see the most installed plugins on the top of the list
    Especially since Available tab now only shows plugins once you've started typing
    It was basically impossible to find Git plugin before, now it's right there
    It's using a numeric value served from the UC generator, so we can adjust things, e.g. consider the slope over recent months, or consider "API Plugins" to be popularity = 0, etc.