Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Ulli Hafner
    @uhafner:matrix.org
    [m]
    Do we have some error logging when symbols do not work and are shown as a cross? I tried to use a custom symbol in an action: https://github.com/jenkinsci/code-coverage-api-plugin/pull/453/files
    Alexander Brandes
    @NotMyFault
    No(t yet), the symbol format is symbol-name plugin-artifactId, if one is missing or wrong, the cross is displayed
    Ulli Hafner
    @uhafner:matrix.org
    [m]
    No, that is not possible, jelly is rendered on the server side. You need to implement that part on the client side using JS.
    2 replies
    Ulli Hafner
    @uhafner:matrix.org
    [m]
    Yes exactly. You can have a look into the table.js file of the data tables plug-in
    Ulli Hafner
    @uhafner:matrix.org
    [m]
    When I am switching a theme from light to dark (using the MacOS display toggle) then Jenkins automatically switches the theme in the browser. How can I catch a corresponding event in JS that indicates that Jenkins changed the theme so that I can redraw the ECharts canvas with the new colors?
    1 reply
    Ulli Hafner
    @uhafner:matrix.org
    [m]
    Yes, I found those pointers as well. But if Jenkins does not also switch the theme then handling those OS events only in one Jenkins component is wrong. Then I have charts in black but the rest still is light. So I need to catch a corresponding Jenkins event: when Jenkins switches the theme, then I need to update my charts. So OS toggle -> Jenkins toggle -> Component toggle . Do we have those events?
    Tim Jacomb
    @timja
    I have some WIP for this but haven't finished it
    not specifically for this but more exposing more info about the selected theme
    to make it easier to hook other libraries in
    Ulli Hafner
    @uhafner:matrix.org
    [m]
    Yes exactly, that binds the proxy with the Java class
    halkeye
    @halkeye:g4v.dev
    [m]
    I think https://community.jenkins.io/t/is-automatic-installation-of-loading-plugin-extensions-normal/3549 might be a bug of some sort. Should I ask for a bug to get created
    (enter on search shouldn't install)
    Daniel Beck
    @daniel-beck
    Is the naming scheme of CSS classes documented somewhere? Asking because I thought classes for use in plugins are prefixed jenkins-!- like in https://weekly.ci.jenkins.io/design-library/Colors/ or https://weekly.ci.jenkins.io/design-library/Spacing/ ; but https://weekly.ci.jenkins.io/design-library/Buttons/ is only jenkins-. When is ! added, and when is it not?
    Tim Jacomb
    @timja
    jenkinsci/credentials-plugin#364 in case anyone has any feedback
    @daniel-beck no not that I know of, I raised an issue about it here: jenkinsci/design-library-plugin#58
    Daniel Beck
    @daniel-beck
    @timja thanks!
    Daniel Beck
    @daniel-beck
    What's the expectation for plugins that use config-disableBuild (now) incorrectly? The UI is very weird when in a config form, and it's not possible to enable affected jobs through the main config form anymore once disabled. Should this control render its output conditionally based on whether it's in an app bar or not?
    halkeye
    @halkeye:g4v.dev
    [m]
    Tim Jacomb
    @timja
    @halkeye:g4v.dev what are you trying to do to make it button like?
    i.e. what's wrong with it atm?
    halkeye
    @halkeye:g4v.dev
    [m]
    i donno, the PR is like a year old, and preferably i don't want to use YUI if i don't have to. I think I copied it from the ec2 plugin at the time.
    Tim Jacomb
    @timja
    makeButton is a function you can call on it if its being added dynamically but you shouldn't need to
    halkeye
    @halkeye:g4v.dev
    [m]
    I think its just a standard button on the cloud agents page to create a new agent manually
    Tim Jacomb
    @timja
    halkeye
    @halkeye:g4v.dev
    [m]
    awesome~
    halkeye
    @halkeye:g4v.dev
    [m]
    any examples of new windows/popups or modals or anything? Right now filling the select takes like a minute because there are so many image options, and I want to make it a plain text box with a popup to select via select/autocomplete/whatever
    i will have to use https://weekly.ci.jenkins.io/design-library/TextBox/ for the other stuff though
    that page is spitting out TypeError: e.getAttribute is not a function though
    Tim Jacomb
    @timja
    credentials plugin uses the yui dialog
    pretty yuck using
    nothing modern has been done yet afaik
    halkeye
    @halkeye:g4v.dev
    [m]
    i might just do window.open or something, i think most people will know an id or slug, and only a few would want to search. We will see
    halkeye
    @halkeye:g4v.dev
    [m]
    apparently I wanted button to trigger a menu
    Ulli Hafner
    @uhafner:matrix.org
    [m]

    I'm using Bootstrap for dialogs, it works quite well.

    Are you planning to add a button as a new empty row? This looks like an uncommon UI pattern.

    Tim Jacomb
    @timja
    it's weird but ec2 plugin already does it
    Ulli Hafner
    @uhafner:matrix.org
    [m]
    Hmm, actions that create new items (or work on multiple rows) should be placed outside a table
    halkeye
    @halkeye:g4v.dev
    [m]
    i can certainly move it outside the table, but the ec2 version triggers a yui menu (I think) that has a list of clouds
    I'm wondering if it should be added to core, so there's not a ec2 specific one, and a do specific one, if someone has a hybrid setup
    hervelemeur
    @hervelemeur:matrix.org
    [m]
    on the last jenkins weekly, when going to "manage the plugins", the list is first displayed with the same sort order as returned by the backend (I presume), then suddenly it's being sorted, this "jump" is quite noticeable. Has it been previously reported?
    Tim Jacomb
    @timja
    not aware of that, are you able to take a video that shows the problem @hervelemeur:matrix.org ?
    hervelemeur
    @hervelemeur:matrix.org
    [m]
    let me check
    hervelemeur
    @hervelemeur:matrix.org
    [m]
    Tim Jacomb
    @timja
    I see can you file an issue for it please? and yeah appears to be the result of client side sorting it.
    interestingly on the available plugins page the client side sorting isn't applied on page load, it will sort if you click it but the column that has sorting applied won't be used on load if that makes sense
    hervelemeur
    @hervelemeur:matrix.org
    [m]
    another issue related to page load: jenkins-infra/plugin-site#1240
    Tim Jacomb
    @timja
    yeah i've seen that before
    hervelemeur
    @hervelemeur:matrix.org
    [m]
    https://issues.jenkins.io/browse/JENKINS-69588 not sure about its title, don't hesitate to change it
    Tim Jacomb
    @timja
    can you label it with ux
    i can't login to Jira