Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Daniel Beck
    @daniel-beck
    Is the naming scheme of CSS classes documented somewhere? Asking because I thought classes for use in plugins are prefixed jenkins-!- like in https://weekly.ci.jenkins.io/design-library/Colors/ or https://weekly.ci.jenkins.io/design-library/Spacing/ ; but https://weekly.ci.jenkins.io/design-library/Buttons/ is only jenkins-. When is ! added, and when is it not?
    Tim Jacomb
    @timja
    jenkinsci/credentials-plugin#364 in case anyone has any feedback
    @daniel-beck no not that I know of, I raised an issue about it here: jenkinsci/design-library-plugin#58
    Daniel Beck
    @daniel-beck
    @timja thanks!
    Daniel Beck
    @daniel-beck
    What's the expectation for plugins that use config-disableBuild (now) incorrectly? The UI is very weird when in a config form, and it's not possible to enable affected jobs through the main config form anymore once disabled. Should this control render its output conditionally based on whether it's in an app bar or not?
    halkeye
    @halkeye:g4v.dev
    [m]
    Tim Jacomb
    @timja
    @halkeye:g4v.dev what are you trying to do to make it button like?
    i.e. what's wrong with it atm?
    halkeye
    @halkeye:g4v.dev
    [m]
    i donno, the PR is like a year old, and preferably i don't want to use YUI if i don't have to. I think I copied it from the ec2 plugin at the time.
    Tim Jacomb
    @timja
    makeButton is a function you can call on it if its being added dynamically but you shouldn't need to
    halkeye
    @halkeye:g4v.dev
    [m]
    I think its just a standard button on the cloud agents page to create a new agent manually
    Tim Jacomb
    @timja
    halkeye
    @halkeye:g4v.dev
    [m]
    awesome~
    halkeye
    @halkeye:g4v.dev
    [m]
    any examples of new windows/popups or modals or anything? Right now filling the select takes like a minute because there are so many image options, and I want to make it a plain text box with a popup to select via select/autocomplete/whatever
    i will have to use https://weekly.ci.jenkins.io/design-library/TextBox/ for the other stuff though
    that page is spitting out TypeError: e.getAttribute is not a function though
    Tim Jacomb
    @timja
    credentials plugin uses the yui dialog
    pretty yuck using
    nothing modern has been done yet afaik
    halkeye
    @halkeye:g4v.dev
    [m]
    i might just do window.open or something, i think most people will know an id or slug, and only a few would want to search. We will see
    halkeye
    @halkeye:g4v.dev
    [m]
    apparently I wanted button to trigger a menu
    Ulli Hafner
    @uhafner:matrix.org
    [m]

    I'm using Bootstrap for dialogs, it works quite well.

    Are you planning to add a button as a new empty row? This looks like an uncommon UI pattern.

    Tim Jacomb
    @timja
    it's weird but ec2 plugin already does it
    Ulli Hafner
    @uhafner:matrix.org
    [m]
    Hmm, actions that create new items (or work on multiple rows) should be placed outside a table
    halkeye
    @halkeye:g4v.dev
    [m]
    i can certainly move it outside the table, but the ec2 version triggers a yui menu (I think) that has a list of clouds
    I'm wondering if it should be added to core, so there's not a ec2 specific one, and a do specific one, if someone has a hybrid setup
    hervelemeur
    @hervelemeur:matrix.org
    [m]
    on the last jenkins weekly, when going to "manage the plugins", the list is first displayed with the same sort order as returned by the backend (I presume), then suddenly it's being sorted, this "jump" is quite noticeable. Has it been previously reported?
    Tim Jacomb
    @timja
    not aware of that, are you able to take a video that shows the problem @hervelemeur:matrix.org ?
    hervelemeur
    @hervelemeur:matrix.org
    [m]
    let me check
    hervelemeur
    @hervelemeur:matrix.org
    [m]
    Tim Jacomb
    @timja
    I see can you file an issue for it please? and yeah appears to be the result of client side sorting it.
    interestingly on the available plugins page the client side sorting isn't applied on page load, it will sort if you click it but the column that has sorting applied won't be used on load if that makes sense
    hervelemeur
    @hervelemeur:matrix.org
    [m]
    another issue related to page load: jenkins-infra/plugin-site#1240
    Tim Jacomb
    @timja
    yeah i've seen that before
    hervelemeur
    @hervelemeur:matrix.org
    [m]
    https://issues.jenkins.io/browse/JENKINS-69588 not sure about its title, don't hesitate to change it
    Tim Jacomb
    @timja
    can you label it with ux
    i can't login to Jira
    too slow
    hervelemeur
    @hervelemeur:matrix.org
    [m]
    label added
    Mark Waite
    @MarkEWaite
    UX SIG starts in 45 minutes at https://zoom.us/j/91788301376?pwd=ekh0NWUvNCs1UVNaaGp2SjZydVMxZz09
    Agenda in the google doc
    halkeye
    @halkeye:g4v.dev
    [m]

    Kinda sharing to transfer computers and kinda because I think y'all might be interested

    https://www.reddit.com/r/javascript/comments/xdurwp/visual_testing_101_design_development_workflow

    Daniel Beck
    @daniel-beck
    @janfaracik Re your recent demo, I was kinda surprised you kept the "all view" with its horrible columns, any thoughts about replacing that with something smarter? Seems to me that building a better default view would be a fairly straightforward way to make the default experience of Jenkins a lot better. I think Blue Ocean did a lot right there, no reason to not do that with the classic UI.
    1 reply
    (Same with the views that exist in multibranch folders (Branches + PRs), it probably wouldn't take much for things to look better than that…)
    Jan Faracik
    @janfaracik
    I definitely want to do more with the 'Dashboard' page, what would you all find useful on there?
    For anyone that wants to see the latest work on the prototype, it's up at https://jenkins-redesign.vercel.app
    halkeye
    @halkeye:g4v.dev
    [m]
    @janfaracik: the hover labels are unreadable to me in firefox linux
    hervelemeur
    @hervelemeur:matrix.org
    [m]
    I don't have this issue (FF 104.0.2)
    Tim Jacomb
    @timja
    Same issue for me on Chrome macOS light mode
    dark mode looks good though