Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 03:41
    ShenJack synchronize #28
  • Aug 20 16:36
    ShenJack synchronize #28
  • Aug 20 15:53
    ShenJack opened #28
  • Aug 18 08:34
    ShenJack opened #27
  • Aug 15 13:10

    jeffpearce on dev

    Implement Chinese Holiday Prese… (compare)

  • Aug 15 13:10
    jeffpearce closed #26
  • Aug 14 16:44
    ShenJack reopened #26
  • Aug 14 16:44
    ShenJack closed #26
  • Aug 13 04:47
    ShenJack synchronize #26
  • Aug 13 04:44
    ShenJack synchronize #26
  • Aug 13 04:02
    ShenJack synchronize #26
  • Aug 08 13:21
    ShenJack synchronize #26
  • Aug 08 11:26
    ShenJack synchronize #26
  • Aug 07 03:12
    ShenJack synchronize #26
  • Aug 07 02:59
    ShenJack synchronize #26
  • Aug 06 16:40
    ShenJack synchronize #26
  • Aug 06 16:27
    ShenJack synchronize #26
  • Aug 06 15:46
    ShenJack synchronize #26
  • Aug 06 11:29
    ShenJack opened #26
  • Aug 05 15:22

    jeffpearce on revert-25-build-script

    (compare)

ShenJack
@ShenJack
This blocked me for a whole day
Thanks to the community ❤
Jeff Pearce
@jeffpearce
Yeah, it's a good engineering skill to know when to ask for help. Too soon, and it looks like you didn't try very hard, too late and you are just wasting time
I think you made the right balance by raising the concern here yesterday
ShenJack
@ShenJack
The solution is awesome. Thanks Jeff, I still got a lot to learn XD
ShenJack
@ShenJack
@jeffpearce I'm in the skype group now
Jeff Pearce
@jeffpearce
On my way!
Jeff Pearce
@jeffpearce
@/all I deployed the latest working hours dev branch (as of yesterday) to http://ec2-34-218-233-192.us-west-2.compute.amazonaws.com:8080/working-hours/ so people can play with the UI
Martin d'Anjou
@martinda
@jeffpearce can you share the credentials please?
Jeff Pearce
@jeffpearce
@martinda try user guest password password
ShenJack
@ShenJack
@jeffpearce There's some error like, the webapp's request has been treated as cross site request, maybe we need to disable the config in the global security settings.
BTW, are you running server just by using hpi:run?
Jeff Pearce
@jeffpearce
I installed Jenkins via these instructions: https://docs.aws.amazon.com/whitepapers/latest/jenkins-on-aws/installation.html
Then installed the plugin via the Advanced tab in the plugin management
Where are you seeing the cross side scripting error?
Jeff Pearce
@jeffpearce
I do see this in the system log:
WARNING hudson.security.csrf.CrumbFilter doFilter No valid crumb was included in request for /jenkins/working-hours/list-time-ranges by jeffpearce. Returning 403.
Sounds like a different problem, but might be related
ShenJack
@ShenJack
@jeffpearce So you build the plugin and upload the hpi file to install?
I'm resolve conflicts, would submit a PR soon.
ShenJack
@ShenJack
jenkinsci/working-hours-plugin#23
Jeff Pearce
@jeffpearce

@jeffpearce So you build the plugin and upload the hpi file to install?

Yep!

ShenJack
@ShenJack
@jeffpearce Github is down now XD.
Jeff Pearce
@jeffpearce
Hi @ShenJack . The changes look good to me, but the build failed
ShenJack
@ShenJack
@jeffpearce Yeah, got it, I'm fixing the tests now
ShenJack
@ShenJack
@jeffpearce I'm trying to deploy the plugin on my cloud server, but the hpi file is too large, approximately 800MB, have you met this problem?
ShenJack
@ShenJack
Maybe because I'm using mvn package XD
Jeff Pearce
@jeffpearce
I used mvn install
I can deploy to mine tomorrow if you’re still blocked
ShenJack
@ShenJack
@jeffpearce It's done, at http://api.shenjack.cn:8080/working-hours/
username:guest
password:password
I'll add it to the slides.
But we still need to optimize the plugin's size, I'll try then.
ShenJack
@ShenJack
@jeffpearce My slides for Code Phase 2 https://docs.google.com/presentation/d/11W5Esq64hZU0lBoCpqkliVUC_8vJnJVuz2I5jQAFx1Q/edit?usp=sharing
Jeff Pearce
@jeffpearce
Can you give me access to add comments? I might have a couple suggestions :-)
ShenJack
@ShenJack
@jeffpearce It's ok now
Jeff Pearce
@jeffpearce
Hi @ShenJack the content looks really great - I just made some minor suggestions around formatting
Martin d'Anjou
@martinda
Croatia stat holiday is today... very convenient for the demo!
Jeff Pearce
@jeffpearce
@ShenJack wrt https://github.com/jenkinsci/working-hours-plugin/pull/24/files. Have you merged the latest jenkinsci:dev branch back into your ShenJack:alpha-release branch?
I feel like I've already reviewed some of these changes :-)
ShenJack
@ShenJack
@jeffpearce Oops, I missed, I've updated that.
ShenJack
@ShenJack
@jeffpearce Are you going to add something to the JWDW presentation, or should I add some? I see that you want a new page to show the date picker.
ShenJack
@ShenJack
@jeffpearce The link for asking UI feedback https://groups.google.com/forum/#!topic/jenkinsci-dev/eAzrhGX6Vdk
Jeff Pearce
@jeffpearce
I saw that - thanks!
If you have time to add info about the date picker, I'd appreciate it. That's pretty interesting, since you can't do that with jelly afaik
ShenJack
@ShenJack
@jeffpearce The build-script PR pass the merge test, now you can merge it.
ShenJack
@ShenJack
I just shared a repo about the boilerplate at https://github.com/ShenJack/ReactBoilerplateforJenkinsPlugin
I'll add more things to it.
@jeffpearce I'm in the skype room now