Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Dec 19 2019 10:28
    GrahamCampbell commented #113
  • Dec 19 2019 07:20
    zwfec edited #113
  • Dec 19 2019 04:59
    zwfec edited #113
  • Dec 19 2019 04:58
    zwfec opened #113
  • Dec 01 2019 00:08
    GrahamCampbell closed #50
  • Sep 03 2019 21:16
    svenluijten closed #108
  • Aug 05 2019 15:18
    sandfoxme commented #112
  • Aug 05 2019 15:01
    sandfoxme opened #112
  • Apr 09 2019 10:24
    BenMorel opened #111
  • Dec 25 2018 23:07
    jmichaelterenin closed #110
  • Dec 25 2018 22:54
    GrahamCampbell commented #110
  • Dec 25 2018 21:47
    jmichaelterenin edited #110
  • Dec 25 2018 20:03
    jmichaelterenin edited #110
  • Dec 25 2018 19:55
    jmichaelterenin opened #110
  • Jun 20 2018 19:24
    GrahamCampbell commented #109
  • Jun 20 2018 19:23
    GrahamCampbell commented #109
  • Jun 20 2018 19:19
    tarampampam commented #109
  • Jun 20 2018 16:27
    GrahamCampbell commented #109
  • Jun 20 2018 11:00
    tarampampam opened #109
  • May 23 2018 06:38
    svenluijten opened #108
Jeremy Lindblom
@jeremeamia
There's no way that can be right
Graham Campbell
@GrahamCampbell
The integration tests cover quite a bit on their own
Jeremy Lindblom
@jeremeamia
Oh, well, that's probably true. I don't like to count on that for my official code coverage metric though. It might not matter that much for a release thoguh
Graham Campbell
@GrahamCampbell
I'm still working on a few things
don't release just yet, lol
Jeremy Lindblom
@jeremeamia
No, I won't today
Graham Campbell
@GrahamCampbell
would it be possible to get it out on monday?
Jeremy Lindblom
@jeremeamia
By Monday 11:59 PM?
Graham Campbell
@GrahamCampbell
yeh :)
Jeremy Lindblom
@jeremeamia
yeah
Graham Campbell
@GrahamCampbell
awesome :)
Jeremy Lindblom
@jeremeamia
Going offline for a while, but I have Gitter on my phone if you have questions
Graham Campbell
@GrahamCampbell
k
Jeremy Lindblom
@jeremeamia
I just added you as a collaborator. Merge away!
Graham Campbell
@GrahamCampbell
awesome!
i don't think codeclimate is processing code coverage correctly at all
i'd recommend using scrutinizer and ditching code climate actually
Jeremy Lindblom
@jeremeamia
They are. Look at my makefile.
Graham Campbell
@GrahamCampbell
oh right, you're only pushing unit tests
it's a shame we have to run the tests twice in order to do that
phpunit should be smart enough so that you can only collect coverage from certain suites
Jeremy Lindblom
@jeremeamia
Might be able to configure that in phpunit.xml. Not a big deal. Can look at that later. Been trying out Code Climate, because my friend is a developer evangelist there.
Graham Campbell
@GrahamCampbell
Right.
Jeremy Lindblom
@jeremeamia
@GrahamCampbell jeremeamia/super_closure#43
Graham Campbell
@GrahamCampbell
i don't think adding this signing thing is a good idea for 2.0
i think we should probably wait for feedback on it and put it in 2.1
Graham Campbell
@GrahamCampbell
i'm going to bed now
email me if there's anything you need
Jeremy Lindblom
@jeremeamia
Oh yeah, I forget we live on different sides of the world. :smile:
Graham Campbell
@GrahamCampbell
i'll might be able to respond early tomorrow morning
(0645 GMT)
or something
Jeremy Lindblom
@jeremeamia
Thanks for your help. I'll probably tag a 2.0 without the signing at some point
Graham Campbell
@GrahamCampbell
great :)
Anthony Ferrara
@ircmaxell
word
also: really? Yet another chat medium?
Jeremy Lindblom
@jeremeamia
Ha ha ha
but you can do markdown in here
Thanks for feedback/advice on the PR. Super helpful!
Anthony Ferrara
@ircmaxell
you can do markdown in here as well
Jeremy Lindblom
@jeremeamia
Lars Strojny
@lstrojny
hey
Graham Campbell
@GrahamCampbell
@jeremeamia just to keep you up to speed, Laravel 5.0 will launch on Feb 2/3 rather than tomorrow
Taylor wants a launch at the start of a week instead of towards the end of one
and the package stuff isn't quite polished enough to be ready for tomorrow
Jeremy Lindblom
@jeremeamia
cool
Jeremy Lindblom
@jeremeamia
hey @lstrojny :smile:
Delespierre
@bdelespierre
hello, kudos for the lib @jeremeamia :)
Thomas Albrighton
@thattomperson
Morning all

quick question
is there a way to get super_closure to ignore $this in a closure that i can pass in later

I have a class that has some closures in a property and a __sleep method that serializes them, but if one of them has a reference to $this it gets stuck in a loop