Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Julien Goux
    @jgoux
    haha I had a lot of fun merging all the logos together ^^
    Tarkan Anlar
    @tarkanlar
    :)
    one more thing did you consider svg support since it is getting more popular
    for icons and other stuff i use svg
    Julien Goux
    @jgoux
    hmm yes I could
    Is there any specific task to do on them ?
    Right now I blindly copy the assets/ folder to /build or /dist
    so if they're in the assets folder they will be copied as well
    I'm looking forward angular-material, very neat stuff
    But still in early development
    Tarkan Anlar
    @tarkanlar
    i minify svgs and copy there is a good article on css https://www.liquidlight.co.uk/blog/article/working-with-svgs-in-sprites/
    Julien Goux
    @jgoux
    ok I could add a svg minifier filter before copying the assets
    Tarkan Anlar
    @tarkanlar
    yeah angular material will be really great. i think it is time to start building something with angular material although it is early
    Julien Goux
    @jgoux
    I need some advices ^^
    How would you handle tasks if someone choose "css" ?
    For preprocessors I have a "main" file, but for CSS I don't know what people wants to do xD
    Because there is a notion of order with plain CSS
    I think I'll just let them add the css files into the index and then concat+minify it
    Tarkan Anlar
    @tarkanlar
    Actually i am not very good at gulp but i think concat + minify and move to folder would be enough for plain css
    Julien Goux
    @jgoux
    The CSS task is really hard because it's a totally different workflow
    I don't know if I'll support it in the next version
    Julien Goux
    @jgoux
    ok, in fact I can import css like a preprocessor :D
    Tarkan Anlar
    @tarkanlar
    btw will there maybe testing )
    Julien Goux
    @jgoux
    Hello
    I've update the "dev" branch so you can start testing it and make suggestions/PR
    This is the branch I want to turn into v1.0.0 :)
    Thanks for your support everyone
    Gabo Esquivel
    @gaboesquivel
    cool I’ll check it out
    one thing, I’d remove the “notice” part in the readme … since it’s just a boilerplate generator… you run it and boom! ready to go.. you won’t use it anymore in your project… there are no sub-generators for module, filters, etc … so changes won’t affect any project that was started with previous version
    Julien Goux
    @jgoux
    Yes, when I wrote it I wanted to add sub-generators, maybe in the future. I'll remove it for now ;)
    done :D
    I've updated all the dependencies to their last version so I'm sure it will break somewhere
    I have to rewrite the tests as the structure change ^^
    Gabo Esquivel
    @gaboesquivel
    k, I’ll PR node-sass option.. it’s faster.. if you are not using compass gem then node-sass will work for you in most cases
    actually I would make that default… and ruby sass / compass optional
    btw gitter is really cool! just discoreved today when I saw the link on your project
    Julien Goux
    @jgoux
    Yes ! Issues suck to discuss about the whole direction of a project. I prefer a chat approach :D
    I wanted to use ruby-sass as it supports the lastest version of sass, but node-sass would be easier to set up you're right.
    So a third option in the styles won't hurt ;)
    Gabo Esquivel
    @gaboesquivel
    it’s 11:40am here… after lunch I’ll work on the generator… one thing I’d deffinitevely want is to use john papa’s style guide for naming files, structuring code..
    Gabo Esquivel
    @gaboesquivel
    hey @jgoux checkout my pull request for tests fixes, I’m now working on getting sourcesmaps to work with ruby-sass and then integrating node-sass option
    they are pretty basic tests, just checking file creation … not checking file content yet
    Gabo Esquivel
    @gaboesquivel

    gulp-ruby-sass (╯°□°)╯︵ ┻━┻

    I replaced that for node-sass and got sourcemaps to work https://github.com/gaboesquivel/generator-angulpify/tree/feature-node-sass , this depends on my previous PR, so I’ll wait until you have time to review the first one

    Julien Goux
    @jgoux
    Will check it this WE, sorry I'm quite busy these days ! Anyway, thanks for the work !!! :)
    Gabo Esquivel
    @gaboesquivel
    k cool
    Robert Buchanan
    @ioneyed
    I cannot seem to find it and I looked through the gulp task (I could have overlooked it) but does this particular generator have commands to generate services, components, etc?
    Julien Goux
    @jgoux
    @ioneyed No it haven't sorry