Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Gabriela de Queiroz
    @gdequeiroz
    Hello there
    Jim Hester
    @jimhester
    Hi! I added the chat link to the readme
    Branko Kovac
    @brankokovac
    Hello!
    Matthew Henderson
    @MHenderson
    Hi
    Erle Holgersen
    @erleholgersen
    Hello!
    Navdeep Gill
    @navdeep-G
    Hi everyone :)
    Adanvr
    @adanvr
    Hello!
    Matthew Henderson
    @MHenderson
    I found a couple of issues and tagged them with the docs tag! Hope I didn't break anything ...
    Jim Hester
    @jimhester
    Great thanks, you did perfect!
    Jim Hester
    @jimhester
    Just a reminder if you woudl like to collaborate please add your name in a new reply to jimhester/lintr#318 and I can add you as an official collaborator
    B.
    @chucheria
    Hi! :)
    Jim Hester
    @jimhester
    :wave:
    Jim Hester
    @jimhester
    So if people are looking for a place to start but are not familiar with the lintr codebase I think going through the open issues and adding an issue label is a good place. Just determining if an issue is a feature request, bug or documentation issue is very useful
    A more moderate task would be to review a few of the smaller open PRs, e.g. jimhester/lintr#239, jimhester/lintr#170
    Jim Hester
    @jimhester
    A advanced task would be to review jimhester/lintr#236, however this is very important for the CRAN release as the object usage linter is one of the ones that is much slower in devel lintr than in the CRAN release
    Jim Hester
    @jimhester
    You can also find any open issue and send a PR to fix it of course!
    Navdeep Gill
    @navdeep-G
    Thx for all the info @jimhester ! Very helpful to get up and running
    Quick q, I am assuming all of us should still fork the repo? In other projects I usually just clone and work from there, checkout a new branch, PR, wait for review, etc. Is that the case here?
    Jim Hester
    @jimhester
    Yeah you can use the same workflow here
    Navdeep Gill
    @navdeep-G
    Great, ty!
    Hope to get up and running soon :)
    Jim Hester
    @jimhester
    :+1:
    Dragoș Moldovan-Grünfeld
    @dragosmg
    :wave:
    Gabriela de Queiroz
    @gdequeiroz
    I have a question regarding the object_length_linter. It looks like the default value is 20. But I'm getting: "Variable and function names should not be longer than 30 characters." Am I missing something here?
    Jim Hester
    @jimhester
    Are you sure you didn't change the default value, in a .lintr file or in your editor configuration?
    Gabriela de Queiroz
    @gdequeiroz
    @jimhester this is what I have on my .lintr 
    linters: with_defaults(line_length_linter(120))
exclusions: list("inst/doc/creating_linters.R" = 1, "inst/example/bad.R", "tests/testthat/exclusions-test")
    I'm using RStudio.
    This came up when I was testing the issue #315
    Gabriela de Queiroz
    @gdequeiroz
    It looks like the function default is 20 (https://github.com/jimhester/lintr/blob/3312afafafd673aa7ec74231b39d83038508023c/R/object_name_linters.R#L182) but the default for calling it is 30 (https://github.com/jimhester/lintr/blob/87658ec425ca5cb2c733444ab6beef45dbb31cfe/R/zzz.R#L96)
    Is this expected @jimhester?
    Jim Hester
    @jimhester
    Ah, yes we should probably make them consistent, probably changing the default argument to 30 makes sense
    Dragoș Moldovan-Grünfeld
    @dragosmg
    Hiya. I did a bit of work on issue 325. Should I submit a pull request? What's the practice - do I need to assign that to anyone?
    Jim Hester
    @jimhester
    Yes, please submit a PR for it
    Dragoș Moldovan-Grünfeld
    @dragosmg
    :thumbsup: