lintr/Lobby

Navdeep Gill

@navdeep-G

Hi everyone :)

Adanvr

@adanvr

Hello!

Matthew Henderson

@MHenderson

I found a couple of issues and tagged them with the docs tag! Hope I didn't break anything ...

Jim Hester

@jimhester

Great thanks, you did perfect!

Jim Hester

@jimhester

Just a reminder if you woudl like to collaborate please add your name in a new reply to jimhester/lintr#318 and I can add you as an official collaborator

@chucheria

Hi! :)

Jim Hester

@jimhester

:wave:

Jim Hester

@jimhester

So if people are looking for a place to start but are not familiar with the lintr codebase I think going through the open issues and adding an issue label is a good place. Just determining if an issue is a feature request, bug or documentation issue is very useful

A more moderate task would be to review a few of the smaller open PRs, e.g. jimhester/lintr#239, jimhester/lintr#170

Jim Hester

@jimhester

A advanced task would be to review jimhester/lintr#236, however this is very important for the CRAN release as the object usage linter is one of the ones that is much slower in devel lintr than in the CRAN release

Jim Hester

@jimhester

You can also find any open issue and send a PR to fix it of course!

Navdeep Gill

@navdeep-G

Thx for all the info @jimhester ! Very helpful to get up and running

Quick q, I am assuming all of us should still fork the repo? In other projects I usually just clone and work from there, checkout a new branch, PR, wait for review, etc. Is that the case here?

Jim Hester

@jimhester

Yeah you can use the same workflow here

Navdeep Gill

@navdeep-G

Great, ty!

Hope to get up and running soon :)

Jim Hester

@jimhester

:+1:

Dragoș Moldovan-Grünfeld

@dragosmg

:wave:

Gabriela de Queiroz

@gdequeiroz

I have a question regarding the object_length_linter. It looks like the default value is 20. But I'm getting: "Variable and function names should not be longer than 30 characters." Am I missing something here?

Jim Hester

@jimhester

Are you sure you didn't change the default value, in a .lintr file or in your editor configuration?

Gabriela de Queiroz

@gdequeiroz

@jimhester this is what I have on my .lintr

linters: with_defaults(line_length_linter(120))
exclusions: list("inst/doc/creating_linters.R" = 1, "inst/example/bad.R", "tests/testthat/exclusions-test")

I'm using RStudio.

This came up when I was testing the issue #315

Gabriela de Queiroz

@gdequeiroz

It looks like the function default is 20 (https://github.com/jimhester/lintr/blob/3312afafafd673aa7ec74231b39d83038508023c/R/object_name_linters.R#L182) but the default for calling it is 30 (https://github.com/jimhester/lintr/blob/87658ec425ca5cb2c733444ab6beef45dbb31cfe/R/zzz.R#L96)

Is this expected @jimhester?

Jim Hester

@jimhester

Ah, yes we should probably make them consistent, probably changing the default argument to 30 makes sense

Dragoș Moldovan-Grünfeld

@dragosmg

Hiya. I did a bit of work on issue 325. Should I submit a pull request? What's the practice - do I need to assign that to anyone?

Jim Hester

@jimhester

Yes, please submit a PR for it

Dragoș Moldovan-Grünfeld

@dragosmg

:thumbsup:

Evan Van Dam

@evandam

Hi all! I was wondering if anyone know's when we can expect to see the next release of lintr in CRAN? I'm currently working on a Jenkins pipeline for an R application and having checkstyle_output would be great to have!

Russ Hyde

@russHyde

I'm going to do a bit of labelling of the open issues.

Jim Hester

@jimhester

@russHyde awesome, thanks!

Russ Hyde

@russHyde

I noticed there is a couple of issues that appear to already have been resolved, eg, #149

jimhester/lintr#149

arekbee

@arekbee

when I can expect to fix the buidl errors for master branch ? https://travis-ci.org/jimhester/lintr/builds/491369124

Jim Hester

@jimhester

They are now fixed (jimhester/lintr@e65804d)

Russ Hyde

@russHyde

Hi @jimhester . I noticed that lintr is mentioned on this awesome-list for static analysis tools: https://github.com/mre/awesome-static-analysis . It's stated that lintr is proprietary software: "©️ stands for proprietary software. All other tools are Open Source." I questioned the author about this, thinking, since lintr is on an MIT license it was open source, here mre/awesome-static-analysis#234 . Would you be able to comment on that issue, please.

arekbee

@arekbee

hi @jimhester, could you approve me pull-req jimhester/lintr#360 please or I should do something more?

Russ Hyde

@russHyde

Hi all / @jimhester , I'm doing a talk at Edinburgh R users group on lintr and one of my tools. Do you pronounce it "Lint R" or "Linter"? Are there any particular stumbling blocks for beginners when they first use lintr? (Apologies if this is the wrong venue for non-issues)

Jim Hester

@jimhester

I think either pronunciation is fine, I think when I first wrote it I pronounced it more as "linter", but these days I tend to say "lint R", since that is how I now say other packages like "dply-R", "tidy-R", "knit-R" etc.

I don't really know of any particular stumbling blocks, but if you come up with some let me know!

Russ Hyde

@russHyde

Thanks

Russ Hyde

@russHyde

Looks like it's been a busy day; there's about 20 less issues than yesterday

Jim Hester

@jimhester

CRAN is making me do a lintr release for a regression in R-devel, so I decided I should work on getting the devel version on CRAN

benoit

@BenoitLondon

Hi is there any doc on how to use all new linters? I understand I have to use with_defaults( <list all linters not in defaults>) ?

Also the new linter space between right parenthesis and curly brace is nice for if () {but not so much for function(){}as Rstudio diagnostics complains for ifs but not for functions

benoit

@BenoitLondon

aka paren_brace_linter

benoit

@BenoitLondon

could it have an option to disable for function definitions?

also the undesirable function there is

$ifelse
[1] "use an if () {} else {} block"

Where communities thrive

People

Repo info

Activity