Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Rick Hanlon II
    @rickhanlonii
    key=[a,b] is not really a defined way to do arrays in query params
    which is what it's testing. It tests that that string is output for multi (encoded to ascii)
    Daniel Holmes
    @jaitaiwan
    And the array parameters won’t always be the same way around either...
    Rick Hanlon II
    @rickhanlonii
    in more explicit terms, it tests for 'multi': '%5B%27FOO%27%2C+b%27BAR%27%5D'
    Daniel Holmes
    @jaitaiwan
    So maybe we change the test to validate that it’s a valid multi string ?
    I mean
    That it can be decoded and the correct values etc are there.
    Rick Hanlon II
    @rickhanlonii
    multi string?
    Daniel Holmes
    @jaitaiwan
    I mean that its encoded correctly
    But that’s overkill hey… cause that’d be testing the url encode which is pointless
    Rick Hanlon II
    @rickhanlonii
    i don't think that the python3 version can be decoded properly
    Daniel Holmes
    @jaitaiwan
    Well lets kill it then.
    Rick Hanlon II
    @rickhanlonii
    compare the expected to the actual:
    %5B%27FOO%27%2C+%27BAR%27%5D
    %5Bb%27FOO%27%2C+b%27BAR%27%5D
    the difference is the "b"s that are put there by str([b'FOO', b'BAR])
    Daniel Holmes
    @jaitaiwan
    I don’t even know why it would do that
    Rick Hanlon II
    @rickhanlonii
    and i don't think that it can be decoded. let me try
    i think it's a urllib bug
    Daniel Holmes
    @jaitaiwan
    What versions does it exist in?
    on that line elt equals [b'FOO', b'BAR']
    which, to string is: '[b\\'FOO\\', b\\'BAR\\']'
    hence the extra b's
    Daniel Holmes
    @jaitaiwan
    print(str([b'FOO',b'BAR'])) equals [b'FOO', b'BAR']
    Shouldn’t it be ['FOO', 'BAR']
    oh wait no
    Rick Hanlon II
    @rickhanlonii
    not in python 3
    Daniel Holmes
    @jaitaiwan
    the utf vs ascii stuff has really confuzzled me haha
    Rick Hanlon II
    @rickhanlonii
    same lol
    i think we remove the multi key and ship it
    Daniel Holmes
    @jaitaiwan
    Saweet
    Which means we will have 2.0 ready before I’ve even finished 1.9 readme changes haha
    Rick Hanlon II
    @rickhanlonii
    lol
    so it goes
    i should investigate why this test passes
    Daniel Holmes
    @jaitaiwan
    It’s not even valid...
    The url should be:
    multi[]=par1, multi[]=par2
    At least that’s my understanding
    Rick Hanlon II
    @rickhanlonii
    yeah
    that's what i thought too
    seems like we can ship and deal with issue as they arise
    Daniel Holmes
    @jaitaiwan
    I also remember someone complaining about getting all the values from the url when a variable is specified multiple times
    Rick Hanlon II
    @rickhanlonii
    yeah, that's probably it
    Daniel Holmes
    @jaitaiwan
    We should at least change it so it fits URL spec
    Rick Hanlon II
    @rickhanlonii
    any preference on which fork we go with for py3?
    we're not breaking any backwards compatibility so i'd be inclined to open an issue and fix in a minor release
    if only because it's been years waiting for a py3 release
    if you're keen on getting it in though, i'm not fussed
    Daniel Holmes
    @jaitaiwan
    Fair enough… We could do a dual release… So release py3 with 1.9.1 and also 1.10
    Ugh