Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Rick Hanlon II
    @rickhanlonii
    I got distracted putting in joestump/python-oauth2#206
    Just going to take some notes
    • Questions (e.g. joestump/python-oauth2#140)
    • Oauth 2.0
    • Features (joestump/python-oauth2#82)
    • Popular APIs broken (joestump/python-oauth2#24)
    Rick Hanlon II
    @rickhanlonii
    @jaitaiwan isn't this done? joestump/python-oauth2#187
    since 1.9 was released?
    Daniel Holmes
    @jaitaiwan
    I don't think so
    I think we definitely did update the readme but I think we were missing references to the Twitter stuff etc
    Do you remember ?
    Rick Hanlon II
    @rickhanlonii
    Hm
    let's close that issue as done and open a different one for adding/improving examples
    Daniel Holmes
    @jaitaiwan
    Sounds goos
    Rick Hanlon II
    @rickhanlonii
    @jaitaiwan @joestump can we update the betterdiff to not care about line length?
    Daniel Holmes
    @jaitaiwan
    But but but... Vim
    :P
    Rick Hanlon II
    @rickhanlonii
    :c
    i think we should all join hands across the world and agree that in 2016 80 characters is crazy
    Daniel Holmes
    @jaitaiwan
    Hahaha
    I personally like it because I can have three columns open at once in sublime.
    But I think it's just a matter of adding a configure file to the repo
    Rick Hanlon II
    @rickhanlonii
    makes sense
    Daniel Holmes
    @jaitaiwan
    I haven't seen stumpy around on Skype or here so I'm not sure he'll be much help
    Rick Hanlon II
    @rickhanlonii
    closing issues that it hasn't reviewed triggers a review
    @jaitaiwan I'm keen on working on joestump/python-oauth2#39 next
    organizing that gigantic __initi__.py file will help with a lot of future issues
    Daniel Holmes
    @jaitaiwan
    Definitely
    The other thing I think is that code coverage isn't 100% like the readme claims
    Rick Hanlon II
    @rickhanlonii
    oh good point
    we should tackle the coverage before the refactor
    Rick Hanlon II
    @rickhanlonii
    ok i categorized all issues and I think i have a good handle on what's out there
    I'm thinking roadmap is:
    • 100% test coverage
    • Refactor/organize
    • Bug fix
    • Add features
    Daniel Holmes
    @jaitaiwan
    I like it. Specifically what features are you thinking? Should we narrow that down?
    Daniel Holmes
    @jaitaiwan
    I was thinking maybe refactor before test coverage because it might be a bit of double handling otherwise
    Rick Hanlon II
    @rickhanlonii
    it may be a bit of doubling, but i think that's a good thing for preventing regression
    with pycharm refactoring is easy ;)
    Daniel Holmes
    @jaitaiwan
    I’ve heard of pycharm before but actually had no clue what it is
    lol
    Rick Hanlon II
    @rickhanlonii
    and i was thinking first adding aguments/parameters, then working on oauth2
    oh it's an IDE from JetBrains
    Daniel Holmes
    @jaitaiwan
    Gotcha… built on Java?
    Rick Hanlon II
    @rickhanlonii
    yeah
    Daniel Holmes
    @jaitaiwan
    Gotta say... that's kinda funny. I've used sublime for the longest time because it's built on python. We need an IDE level thing that's open source and built on python with ALL the features.
    Rick Hanlon II
    @rickhanlonii
    i think python would be too slow to do what pycharm does
    it does a stupid amount of indexing and static analysis
    Daniel Holmes
    @jaitaiwan
    Alright so, what do you want me to work on, and what do you want to tackle?