by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Daniel Holmes
    @jaitaiwan
    The other thing I think is that code coverage isn't 100% like the readme claims
    Rick Hanlon II
    @rickhanlonii
    oh good point
    we should tackle the coverage before the refactor
    Rick Hanlon II
    @rickhanlonii
    ok i categorized all issues and I think i have a good handle on what's out there
    I'm thinking roadmap is:
    • 100% test coverage
    • Refactor/organize
    • Bug fix
    • Add features
    Daniel Holmes
    @jaitaiwan
    I like it. Specifically what features are you thinking? Should we narrow that down?
    Daniel Holmes
    @jaitaiwan
    I was thinking maybe refactor before test coverage because it might be a bit of double handling otherwise
    Rick Hanlon II
    @rickhanlonii
    it may be a bit of doubling, but i think that's a good thing for preventing regression
    with pycharm refactoring is easy ;)
    Daniel Holmes
    @jaitaiwan
    I’ve heard of pycharm before but actually had no clue what it is
    lol
    Rick Hanlon II
    @rickhanlonii
    and i was thinking first adding aguments/parameters, then working on oauth2
    oh it's an IDE from JetBrains
    Daniel Holmes
    @jaitaiwan
    Gotcha… built on Java?
    Rick Hanlon II
    @rickhanlonii
    yeah
    Daniel Holmes
    @jaitaiwan
    Gotta say... that's kinda funny. I've used sublime for the longest time because it's built on python. We need an IDE level thing that's open source and built on python with ALL the features.
    Rick Hanlon II
    @rickhanlonii
    i think python would be too slow to do what pycharm does
    it does a stupid amount of indexing and static analysis
    Daniel Holmes
    @jaitaiwan
    Alright so, what do you want me to work on, and what do you want to tackle?
    Rick Hanlon II
    @rickhanlonii
    if you want to write the tests, i can work on the refactor
    or if you want to start looking into some of the bugs i can do the tests/refactor
    Rick Hanlon II
    @rickhanlonii
    fair?
    Daniel Holmes
    @jaitaiwan
    Yeah man. What would you prefer?
    Rick Hanlon II
    @rickhanlonii
    i'm happy to do the tests+refactor
    Daniel Holmes
    @jaitaiwan
    Ok then. I’m on to bug fixes. Shall we identify a top 5?
    Rick Hanlon II
    @rickhanlonii
    sgtm
    theres 18 bugs open
    @jaitaiwan i would probably start with going through and trying to verify the bugs first
    Daniel Holmes
    @jaitaiwan
    On it
    Daniel Holmes
    @jaitaiwan
    @rickhanlonii got completely caught up this week with work and the next week isn’t looking much better. I’m hoping the coming weekend will open an oportunity to really dig in deep and get it smashed over a day or so
    Rick Hanlon II
    @rickhanlonii
    @jaitaiwan no worry, i'm going to start tomorrow
    Daniel Holmes
    @jaitaiwan
    Cool cool
    Rick Hanlon II
    @rickhanlonii
    @jaitaiwan can you remove betterdiff from the repo?
    i'm all for linting, but having a bot comment on the pull request is really noisy
    Rick Hanlon II
    @rickhanlonii
    @jaitaiwan nvm, i got it
    ugh, no that didn't work.
    Rick Hanlon II
    @rickhanlonii
    turning it off here: doesn't work
    Daniel Holmes
    @jaitaiwan
    paging @joestump
    Rick Hanlon II
    @rickhanlonii
    @jaitaiwan @joestump I talked to Justin at betterdiff and they're adding a feature where if there are more than X issues it will just leave a single comment rather than commenting on every line
    i think that will work really well for us so I told him we'll keep it
    I also fixed the linting issues on joestump/python-oauth2#206
    Daniel Holmes
    @jaitaiwan
    Great!
    Chip Wolf ‮
    @ChipWolf
    Anyone kicking about to help me debug something quickly?
    Daniel Holmes
    @jaitaiwan
    Hey guys! If you’re around at all, I’m currently at PyConAU in the sprints phase of the project. If you’re keen on popping in and giving us a hand remotely that would be great.
    Aim is to get the project back on track by addressing the newer issues of the past few months and to smash out some pull requests.
    Love your assistance!
    Daniel Holmes
    @jaitaiwan
    Or...
    Do we say that there are better alternatives to this oauth library and shut it down in favour of another fork
    ?