Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jun 22 2016 16:02
    johncarl81 synchronize #196
  • Jun 22 2016 16:02

    johncarl81 on LibraryR

    Added getInnerClass Added RBridge and Transfuse sup… Added auto-service and 13 more (compare)

  • Jun 22 2016 15:14

    johncarl81 on inherits_fix

    (compare)

  • Jun 22 2016 15:09

    dbachelder on master

    Fixes inheritance checking when… Conslidated inheritance checking Added tests and 1 more (compare)

  • Jun 22 2016 15:09
    dbachelder closed #201
  • Jun 22 2016 14:40
    dbachelder commented #196
  • Jun 22 2016 14:39
    dbachelder commented #201
  • Jun 21 2016 21:19

    johncarl81 on master

    Updated Glitter badge orientati… (compare)

  • Jun 21 2016 21:18

    johncarl81 on master

    Updated Glitter badge orientati… (compare)

John Ericksen
@johncarl81
The build successfully runs multiple times and all parcelable code is generated and in place
can you guys show me how its failing for you or give me a procedure to follow?
Andrius Semionovas
@neworld

To clarify, I am talking about gradle incremental, not java/kotlin incremental. In my case, I am using kotlin with kapt. Kotlin compiler is never up-to-date, if generated classes was changed. I absolutelly understand, this is issue of kotlin, not parceler. But solution would be very helpful.

P.S. Dagger and Butterknife doesn't have that problem. They just don't generate date.

John Ericksen
@johncarl81
Can you help me understand with a simple example project?
Andrius Semionovas
@neworld
if you build every minute, kotlin and java compilers are never up-to-date
John Ericksen
@johncarl81
Awesome, I'll check out shortly
Andrius Semionovas
@neworld
If you build two times in the same minute, all further build are up-to-date. This is kotlin issue
The problem is, our main project build more than 1min and no chance to build in same minute
Thanks for your time
BTW, I could try make PR, if you agree it is correct solution.
John Ericksen
@johncarl81
I think I'm able to reproduce the problem... basically slows down the build, right?
John Ericksen
@johncarl81
@neworld, I created a version of Parceler that doesnt add the @Generated annotation, unfortunately kapt still runs Parceler
you're running gradle with just ./gradlew build right?
Andrius Semionovas
@neworld
@johncarl81, yes. We have tons of modules in our huge project, and module with parcelite is very first.
Andrius Semionovas
@neworld

Incremental works not very nice:

  • The first build is always compiled
  • The second build is recompiled because kapt in the first build added class
  • Further builds are recompiled because kapt produces not the same code

It means, even without date, the second build is never up-to-date. Only further builds could be up-to-date. That change would save few hours of total build time in our company each day.

John Ericksen
@johncarl81
Would you like to verify removing the Generated annotation solves your build issue?
(there may be another culprit)
Andrius Semionovas
@neworld
yes, sure
John Ericksen
@johncarl81
Do you know how to include maven central snapshots?
Andrius Semionovas
@neworld
No
I can't find url for maven central snapshots
John Ericksen
@johncarl81
here it is:
maven {
    url "https://oss.sonatype.org/content/repositories/snapshots/"
}
currently deploying
under 1.1.7-SNAPSHOT
Andrius Semionovas
@neworld
It works as expected. Third and further builds are up to date.
I tested on big project, with >50 entities with parcelite
Will this change be included in 1.1.7?
John Ericksen
@johncarl81
Awesome. Yeah I'll include this in 1.1.7
Btw, is parcelite = parceler?
Andrius Semionovas
@neworld
Thanks! It will save ~25sec, or 30% each build
yeah, parceler
John Ericksen
@johncarl81
Btw, coincidentally someone just posted a PR on auto value to add @Generated
Somewhat unrelated though
Andrius Semionovas
@neworld
I suppose, AutoValue always added Generated annotation:
But they don't add date
Date is issue of incremental, not @Generated by itself
John Ericksen
@johncarl81
Yup, I saw that too.
John Ericksen
@johncarl81
fyi @neworld johncarl81/transfuse#205
and: johncarl81/parceler#245
Jani
@ljani
Hey. Has anyone faced problems with Jack's annotationProcessor? It works fine most of the time, but once in a while I get an error, but it is always solved by full rebuild cycle:
"Unable to find generated Parcelable class for com.example.MyDto, verify that your class is configured properly and that the Parcelable class com.example.MyDto$$Parcelable is generated by Parceler."
I'm only doing debug builds so the problem shouldn't be proguard
Jani
@ljani
For example:
I launched my app at 9:33
The generated class exists in build\generated\source\apt\debug\com\example with a timestamp of 9:19
(Sorry, hit enter accidentally)
I have not changed the dto class, only the fragment
John Ericksen
@johncarl81
I have heard of a couple of issues with Jack, but I have not been able to reproduce them first hand
any way you can produce a consistently failing example?
Jani
@ljani
@johncarl81 I could try. It's failing quite often for me.. Let me check if I can find an example and try to run it a few times and see if it fails
Jani
@ljani
@johncarl81 success. Here's what I did:
git clone https://github.com/ljani/parceler.git
cd parceler/examples/gradle
git checkout c790ffb5b344202f3adfb38ac13ec4c78be281af # (master~)
# Install. I'm using IDEA 2016.3 and I just clicked the "play" button next to "gradleParceler" build configuration
# Test the app, use some random message
git checkout 746a95fe61f962a5113818fbc391ef4a642ad12c # (master)
# Again, click the "play" button
# Test the app, with another message. It should fail when you click submit.
# Here's the exception: http://pastebin.com/mpQqJmSC
Whoops, I didn't know gitter supported markdown