Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Aug 09 12:14
    dzmitrybeinia opened #2616
  • Aug 04 19:42
    jryan128 opened #2615
  • Aug 04 11:33
    madskaddie opened #2614
  • Jul 29 15:55

    jknack on 2.x

    Add FUNDING/sponsor file (compare)

  • Jul 25 13:28
    jknack closed #2611
  • Jul 25 13:28

    jknack on 2.x

    App should return 400 code if f… Merge pull request #2612 from e… (compare)

  • Jul 25 13:28
    jknack closed #2612
  • Jul 25 13:28
    jknack milestoned #2612
  • Jul 22 17:26
    agentgt commented #2613
  • Jul 22 16:02
    agentgt edited #2613
  • Jul 22 15:53
    agentgt commented #2613
  • Jul 22 15:40
    agentgt opened #2613
  • Jul 22 06:27
    extbe synchronize #2612
  • Jul 21 20:26
    extbe opened #2612
  • Jul 21 18:32
    extbe commented #2611
  • Jul 21 15:06
    jknack commented #2611
  • Jul 21 15:03
    extbe commented #2611
  • Jul 21 14:50
    jknack commented #2611
  • Jul 21 13:05
    agentgt commented #2611
  • Jul 21 11:29
    extbe edited #2611
Nguyen Huu Tuan
@snowyukischnee
another question
in the mvc controller, how can i define a filter
i cant find it anywhere inside the mvc api section
Edgar Espina
@jknack
well yea, we don’t have that type of composition/isolation yet
the way it works is like every other route
so if you need a filter for a controller:
decorator(next -> ctx -> …);

mvc(Controller.class);
so that route run before all controller routes
Nguyen Huu Tuan
@snowyukischnee
oh
Edgar Espina
@jknack
yea, controller methods are “expanded” as lambda routes by APT proccessor
pipeline works exactly the same
Nguyen Huu Tuan
@snowyukischnee
so i might switch to router
i've worked with expressjs before
Edgar Espina
@jknack
yea it is similar
Nguyen Huu Tuan
@snowyukischnee
and this router look similar
Edgar Espina
@jknack
1.x was identical
2.x is similar not identical
Nguyen Huu Tuan
@snowyukischnee
i've not look into the 1.x yet
Edgar Espina
@jknack
sequential pipeline is identical
Nguyen Huu Tuan
@snowyukischnee
i just discover this framework yesterday
Edgar Espina
@jknack
except that a pipeline is executed over a matched route
in 1.x pipeline is always executed, no matter if there is a matching route handler at the end or not
Nguyen Huu Tuan
@snowyukischnee
you mean in 2.x only the match routes are executed?
Edgar Espina
@jknack
yes
Nguyen Huu Tuan
@snowyukischnee
@jknack does use(Router) is the same with mount(Router), since i've look into the source code and see that the use method would call the mount method
however, if i using jooby-openapi to generate api spec, the mount() will not work and use() works
Edgar Espina
@jknack
good catch
we need to fix this
Nguyen Huu Tuan
@snowyukischnee
@jknack also jooby-openapi do not generate the example i defined using annotation
reddierocket
@reddierocket
Can someone send me a link on how to set up TLS 1.2 or 1.3 with Jooby 2 using Netty? I'm not finding anything in my searches, but someone ran a security scan and using ssl was a vulnerability that was cited, with a recommendation to use TLS 1.2 or greater. Thanks.
Emmanuel Oga
@EmmanuelOga
did you see this? https://jooby.io/#server-ssl
Nguyen Huu Tuan
@snowyukischnee
Hi, how can I enable http2 support for jooby 2.x
Johannes Beranek
@JohannesBeranek
Hi, is there some kind of css and/or js minification for Jooby 2.x? Only found asset aggregator for the Jooby 1.x asset module, but nothing so far for Jooby 2 :(
Mészáros István
@imeszaros
@JohannesBeranek No for 2.x as far as i know.
@jknack i discovered a problem with Netty 4.1.52 and SSL. The cause is not yet identified. I created an issue here: netty/netty#10720 I'll make a PR if something has to be done on our side.
Edgar Espina
@jknack
@snowyukischnee no support for http 2 yet
@JohannesBeranek there is an integration module for node: https://jooby.io/modules/node (we moved away from any custom done in Java)
@imeszaros Odd, let me know how it goes
Mészáros István
@imeszaros
@jknack TL;DR: had to upgrade to newer openjdk because older releases (we used 11.0.2) had problems with TLS 1.3 which was enabled by default since Netty 4.1.52
Edgar Espina
@jknack
do you know how to enable TLS1.2 or 1.3 in netty?
Mészáros István
@imeszaros
I made a copy of io.jooby.netty.Netty to be able to specify a list of protocols to the constructor of io.netty.handler.ssl.JdkSslContext where I excluded TLS 1.3
Edgar Espina
@jknack
I would like to move https to his own module
and probably add more options like setting TLS version
that will give us: jooby-{server}-https
all these integrated with ServiceLoader API
same for http2
Mészáros István
@imeszaros
good idea, especially the ability to be able to configure the protocol
what happens if someone configures jooby to use https but uses a server for http only?
Edgar Espina
@jknack
don’t follow