Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Evaldo Bratti
    @evaldobratti
    hi there
    Joshua Duffy
    @joshuaduffy
    Hi Evaldo!
    Joshua Duffy
    @joshuaduffy
    I'm going to do some more work on the documentation today
    http://dota2api.readthedocs.org/en/latest/index.html - I added some information around the responses returned and created a basic tutorial
    Evaldo Bratti
    @evaldobratti
    nice!
    I was thinking on put this on the tests too, but it's really hard work
    maybe later, after improve coverage of the other parts of the api we should create more asserts on tests to show the response
    i'm going to work until 10pm today -.-
    we're doing some overtime on the company I work
    then, i don't know if i'm going to work on the api today
    :(
    Joshua Duffy
    @joshuaduffy
    It's fine don't worry :) Thanks for everything, you've been a massive help!
    I'm going to write some tests next, I just added in some logging, to help us debug :)
    Look in the init.py for how I'm using the logging module
    I have been working late all week :( I start working away as well in two week (I do consulting... so annoying sometimes!)
    Joshua Duffy
    @joshuaduffy
    I am home. So can work on everything now! Want to get lots done before I'm working away!
    king110.pl
    @king110
    is there support for GetMatchHistoryBySequenceNum comming anytime soon?
    Joshua Duffy
    @joshuaduffy
    Hey, it returns the same as Get_,match_history - but we can arrange adding it if you lie?
    like*
    king110.pl
    @king110
    Well the Steam API Get_match_history ( start_at_match_id=XXX ) is broken and always gives out the latest match history (http://dev.dota2.com/showthread.php?t=127390). so to go through old matched the best option is GetMatchHistoryBySequenceNum.
    Evaldo Bratti
    @evaldobratti
    just pushed a branch to test parser, can someone take a look at this? :smile:
    Joshua Duffy
    @joshuaduffy
    Merged! :)
    Joshua Duffy
    @joshuaduffy
    I've added get_match_history_by_seq_num() - Updated the API and documentation
    Evaldo Bratti
    @evaldobratti
    Cool!
    I was thinking in improving the parser to include not only item/heroes names, but the url's to images as well.
    We already have the name item that api requires, as http://cdn.dota2.com/apps/dota2/images/items/blink_lg.png
    Joshua Duffy
    @joshuaduffy
    Yeah, seems like a good thing to include. I think with doing something like that we should make a start on returning objects instead of dictionaries too? Thoughts?
    Evaldo Bratti
    @evaldobratti
    I don't know if there is a lot of changes we can make from the json's objects, we could just make a python object equivalent to the json object, se we can access fields in a object way instead of map way. That would be good I think. The problem is to parse the response to correct objects :worried:
    Joshua Duffy
    @joshuaduffy
    Yeah will be a lot of work, I've made a start on it however :) Should take a few weeks but the response object will be either a Match, or a list of matches, a user etc.
    then we can have objects like heroes & players within the match
    Evaldo Bratti
    @evaldobratti
    Just pushed a branch with parser of a match
    Currently it's just parsing a match if the root of the result is a match with all informations
    there are tests failing because of that
    but it's just a start
    maybe we can work on the same branch
    Evaldo Bratti
    @evaldobratti
    get match and get match history are parsed, I think
    there are the other responses, as get items, get heroes, leagues etc
    Evaldo Bratti
    @evaldobratti
    I'll work again during the week
    Joshua Duffy
    @joshuaduffy
    Hey, same, working lates at the moment, so not much time, but hopefully next week I will have :)
    Evaldo Bratti
    @evaldobratti
    "scoreboard":{
    "duration":2335.81787109375,
    "roshan_respawn_timer":0,
    "radiant":{
    "score":19,
    "tower_state":1796,
    "barracks_state":51,
    "picks":[ ... ],
    "bans":[ ... ],
    "players":[ ... ],
    "abilities":[ ... ],
    "abilities":[ ... ],
    "abilities":[ ... ],
    "abilities":[ ... ],
    "abilities":[ ... ]
    },
    this is part of the result of live league games
    the problem is "abilities" repeating 5 times (1 per player I think), but they are in same level of object "scoreboard"
    when you get json['scoreboard']['abilities'] it only get the last abitilities object
    I couldn't find anything yet reporting this issue