Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Joshua Duffy
    @joshuaduffy
    Merged! :)
    Joshua Duffy
    @joshuaduffy
    I've added get_match_history_by_seq_num() - Updated the API and documentation
    Evaldo Bratti
    @evaldobratti
    Cool!
    I was thinking in improving the parser to include not only item/heroes names, but the url's to images as well.
    We already have the name item that api requires, as http://cdn.dota2.com/apps/dota2/images/items/blink_lg.png
    http://cdn.dota2.com/apps/dota2/images/items/blades_of_attack_lg.png
    http://cdn.dota2.com/apps/dota2/images/heroes/antimage_lg.png
    Evaldo Bratti
    @evaldobratti
    http://cdn.dota2.com/apps/dota2/images/heroes/bane_lg.png
    http://dev.dota2.com/showthread.php?t=58317
    Joshua Duffy
    @joshuaduffy
    Yeah, seems like a good thing to include. I think with doing something like that we should make a start on returning objects instead of dictionaries too? Thoughts?
    Evaldo Bratti
    @evaldobratti
    I don't know if there is a lot of changes we can make from the json's objects, we could just make a python object equivalent to the json object, se we can access fields in a object way instead of map way. That would be good I think. The problem is to parse the response to correct objects :worried:
    Joshua Duffy
    @joshuaduffy
    Yeah will be a lot of work, I've made a start on it however :) Should take a few weeks but the response object will be either a Match, or a list of matches, a user etc.
    then we can have objects like heroes & players within the match
    Evaldo Bratti
    @evaldobratti
    Just pushed a branch with parser of a match
    Currently it's just parsing a match if the root of the result is a match with all informations
    there are tests failing because of that
    but it's just a start
    maybe we can work on the same branch
    Evaldo Bratti
    @evaldobratti
    get match and get match history are parsed, I think
    there are the other responses, as get items, get heroes, leagues etc
    Evaldo Bratti
    @evaldobratti
    I'll work again during the week
    Joshua Duffy
    @joshuaduffy
    Hey, same, working lates at the moment, so not much time, but hopefully next week I will have :)
    Evaldo Bratti
    @evaldobratti
    "scoreboard":{
    "duration":2335.81787109375,
    "roshan_respawn_timer":0,
    "radiant":{
    "score":19,
    "tower_state":1796,
    "barracks_state":51,
    "picks":[ ... ],
    "bans":[ ... ],
    "players":[ ... ],
    "abilities":[ ... ],
    "abilities":[ ... ],
    "abilities":[ ... ],
    "abilities":[ ... ],
    "abilities":[ ... ]
    },
    this is part of the result of live league games
    the problem is "abilities" repeating 5 times (1 per player I think), but they are in same level of object "scoreboard"
    when you get json['scoreboard']['abilities'] it only get the last abitilities object
    I couldn't find anything yet reporting this issue
    https://wiki.teamfortress.com/wiki/WebAPI/GetLiveLeagueGames shows nothing about 'scoreboard' object
    it's strange :worried:
    Evaldo Bratti
    @evaldobratti
    oh god, just found it
    http://dev.dota2.com/showthread.php?t=156783
    it's a bug
    well have to hack the json
    Joshua Duffy
    @joshuaduffy
    I'll take a look at this on the weekend!
    Nice find!
    Joshua Duffy
    @joshuaduffy
    Apologies, haven't had the time to do this yet! Will look at this very soon though :)
    Evaldo Bratti
    @evaldobratti
    no problem :)
    just pushed a commit with url support for items and heroes
    there are some types that could be improved, like leagueid turning into league_id, more 'pythonic'
    and we could convert some booleans values, like 0 turning to false and so on
    but it takes time to review all responses to find out what to convert
    Joshua Duffy
    @joshuaduffy
    Yeah it does!
    I'm working quite a lot at the moment too, finding it hard to make the time, hopefully in the coming weeks I can change that though :)
    Evaldo Bratti
    @evaldobratti
    no problem
    I started to work in another app that will use dota2api, but the pip install is not working, it's not installing the requests lib
    no wonder why :worried:
    Evaldo Bratti
    @evaldobratti
    I was trying to find the error behind the pip install, and discovered that is not working only on a virtual environment
    when it's being installed on system wide, it works nicely
    Joshua Duffy
    @joshuaduffy
    Yeah I'm not sure why the dependency doesn't install :/
    In the setup.py I defined it as a dependency but it doesn't seem to pick it up!