in my experience Yarn is way more stable with its lockfile format, for example
Timmy Willison
@timmywil
that's pretty much why I use yarn
Michał Gołębiowski-Owczarek
@mgol
me too :D
Timmy Willison
@timmywil
that everything?
Michał Gołębiowski-Owczarek
@mgol
plus, the thing between OSes is that e.g. fsevents is an optional package and only works on macOS so it's skipped on Windows. That means it doesn't get to package-lock when npm is run on Windows
so Windows-based contributors would be unable to update dependencies, etc.
@timmywil there's one PR where I need @gibson042's input
I'm not sure what to think of it with the new information
Michał Gołębiowski-Owczarek
@mgol
and the underlying issue is nodes inside of <template/> have the document fragment as their ownerDocument and that has a nulldocumentElement
Timmy Willison
@timmywil
wait, wouldn't the nodeType be 9?
in that case
I mean 11
I wonder if we could check for 11
Michał Gołębiowski-Owczarek
@mgol
nodeType is 9
Timmy Willison
@timmywil
it's 9 on the document fragment and has no document element?
Michał Gołębiowski-Owczarek
@mgol
yup
Timmy Willison
@timmywil
that's stupid
lol
Richard Gibson
@gibson042
it seems like we generally want to catch the document fragment in the general case, but keep traversing up when it corresponds with a <template>
_
Timmy Willison
@timmywil
I shame this fragment
@gibson042 sounds about right
I'm surprised the nodeType is 9
Michał Gołębiowski-Owczarek
@mgol
right, it's weird...
how to know we're inside of a template element, though?
Timmy Willison
@timmywil
anyway, I guess there are other creative ways to accomplish what gibson said
Michał Gołębiowski-Owczarek
@mgol
so that optimization got in but was accidentally reverted
so what we currently have on Sizzle won't break jQuery tests
therefore, this issue is not critical
Timmy Willison
@timmywil
ok, I'm not sure the answer yet, but not breaking tests is good
I think that's all for today. Thanks all!
Michał Gołębiowski-Owczarek
@mgol
thank you!
@gibson042 do you want to have a look at jquery/sizzle#453 before merging?
Richard Gibson
@gibson042
yes please
Michał Gołębiowski-Owczarek
@mgol
cool
see you!
Timmy Willison
@timmywil
I meant to say this earlier but no meeting today. I be on holiday.
Michał Gołębiowski-Owczarek
@mgol
We can still meet without Timmy if there are enough people. I have a few topics and this might be my last meeting before a break as my wife is due in a few days.
Michał Gołębiowski-Owczarek
@mgol
@/all anyone available for a meeting?
Michał Gołębiowski-Owczarek
@mgol
OK, I guess not. :)
Michał Gołębiowski-Owczarek
@mgol
(oh, there's a national holiday today in the US, that explains a lot)
Dave Methvin
@dmethvin
Sorry but I have another meeting at noon. Mention me on anything and I will catch up later