Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Michał Gołębiowski-Owczarek
    @mgol
    I can report a Firefox issue
    Timmy Willison
    @timmywil
    cool
    jquery/jquery-mousewheel#202 I'm not really comfortable with the proposed workarounds here.
    Michał Gołębiowski-Owczarek
    @mgol
    I see. My (&, I assume, Dave's) idea was that it's not core but a plugin so we can allow a less ideal & temporary API here. But I understand the push against it as well.
    Timmy Willison
    @timmywil
    side note: I thought the mousewheel plugin would be EOL soon considering modern browser support for wheel
    Michał Gołębiowski-Owczarek
    @mgol
    especially that wheel events are one of the main reason for scroll jank
    hmm
    I think it has a bit more features than just normalizing events. But I'm not sure how important they are
    it'd be good to have Dave for this discussion here :)
    Timmy Willison
    @timmywil
    good point
    ok, we'll ask him next time we see him
    any reason we can't use offsetWidth/Height for documentElement?
    just to make it consistent that we don't use client
    Michał Gołębiowski-Owczarek
    @mgol
    offset* includes border, padding & scrollbars, client* only padding of those
    I think we're getting clientWidth specifically to include scrollbars, aren't we?
    Timmy Willison
    @timmywil
    yea
    so client must include those as well?
    Michał Gołębiowski-Owczarek
    @mgol
    sorry, to not include scrollbars
    so that you get full available document width for your layout purposes
    if I remember it correctly
    Timmy Willison
    @timmywil
    alright, well it sounds like we can close this issue without changes then
    Michał Gołębiowski-Owczarek
    @mgol
    yea
    Timmy Willison
    @timmywil
    +1
    so weird
    Michał Gołębiowski-Owczarek
    @mgol
    haha
    Timmy Willison
    @timmywil
    but I guess what IE doesn't like is coercing the value
    Michał Gołębiowski-Owczarek
    @mgol
    any idea how to avoid repeating the same comment multiple times?
    Timmy Willison
    @timmywil
    err, wait
    Michał Gołębiowski-Owczarek
    @mgol
    well, == works and it's the one that coerces... only === crashes
    Timmy Willison
    @timmywil
    backwards
    okay, no idea
    Michał Gołębiowski-Owczarek
    @mgol
    they must have some weird internal casting that does more than the standard mandates
    and === probably reaches into some private parts which == avoids in their implementation
    but that's completely backwards to how it should work :D
    Timmy Willison
    @timmywil
    I guess the only way would be to dry it up into an internal function
    which I'd be fine with
    but I also don't care that much
    Michał Gołębiowski-Owczarek
    @mgol
    I tried that but that adds 20 bytes :O
    Timmy Willison
    @timmywil
    oof
    Michał Gołębiowski-Owczarek
    @mgol
    implementation in mgol/jquery@53d0840
    Timmy Willison
    @timmywil
    that's not worth it
    Michał Gołębiowski-Owczarek
    @mgol
    we'll need to backport to Sizzle as well. I'm afraid there may be many more comparisons to the document there
    OK, I'll land it & submit a Sizzle backport PR
    Timmy Willison
    @timmywil
    those might be consolidated to setDocument
    Michał Gołębiowski-Owczarek
    @mgol
    often documents are compared to know if setDocument needs to be called
    so it happens outside
    Timmy Willison
    @timmywil
    ok