These are chat archives for jruby-gradle/jruby-gradle-plugin

28th
Apr 2015
Christian Meier
@mkristian
Apr 28 2015 14:56
@ysb33r @rtyler #110 is green and comes with a small integration-test
R. Tyler Croy
@rtyler
Apr 28 2015 14:57
YAY!
rtyler @rtyler takes a look
Charles Oliver Nutter
@headius
Apr 28 2015 17:11
Just a reminder if it hasn't happened yet...CFP for Eurucamp/JRubyConf.EU is closing soon and they both want more talks
R. Tyler Croy
@rtyler
Apr 28 2015 17:17
yeah, that's on my TODO for today, finish that damned thing up
Charles Oliver Nutter
@headius
Apr 28 2015 17:20
excellent!
R. Tyler Croy
@rtyler
Apr 28 2015 18:05
@/all I'm thinking about releasing jruby-gradle base plugin 0.1.16 with @mkristian's fixes, any objections?
Schalk W. Cronjé
@ysb33r
Apr 28 2015 18:06
lemme have a quick look
R. Tyler Croy
@rtyler
Apr 28 2015 18:06
running integration tests and tinkering locally first
Schalk W. Cronjé
@ysb33r
Apr 28 2015 18:08
we’ll haev to ensure the README is up to date before release
and CHANGELOG.md must be updated as well
I don’t have time this week, so it’s up to you
rtyler @rtyler nods
Schalk W. Cronjé
@ysb33r
Apr 28 2015 18:14
just apply this little diff to JRubyPrepareJars.groovy
diff --git a/src/main/groovy/com/github/jrubygradle/JRubyPrepareJars.groovy b/src/main/groovy/com/github/jrubygradle/JRubyPrepareJars.groovy
index fe9201b..a88a216 100644
--- a/src/main/groovy/com/github/jrubygradle/JRubyPrepareJars.groovy
+++ b/src/main/groovy/com/github/jrubygradle/JRubyPrepareJars.groovy
@@ -3,6 +3,7 @@ package com.github.jrubygradle
 import com.github.jrubygradle.internal.JRubyExecUtils
 import groovy.transform.PackageScope
 import org.gradle.api.DefaultTask
+import org.gradle.api.Incubating
 import org.gradle.api.Project
 import org.gradle.api.file.FileCollection
 import org.gradle.api.tasks.InputFiles
@@ -18,6 +19,7 @@ import org.gradle.api.tasks.TaskAction
  * @author R Tyler Croy
  * @author Christian Meier
  */
+@Incubating
 class JRubyPrepareJars  extends DefaultTask {

     /** Target directory for JARs {@code outputDir + "/jars"}
@@ -65,7 +67,7 @@ class JRubyPrepareJars  extends DefaultTask {
         }

         // TODO use synch but need a different place to create the Jars.lock
-        project.copy() {
+        project.copy {
             from files
             include '**/*.jar'
             exclude '**/jruby-complete*.jar’
it adds @Incubating to the class and removes the () from the project.copy call.
R. Tyler Croy
@rtyler
Apr 28 2015 18:19
heh, okay
Christian Meier
@mkristian
Apr 28 2015 18:19
what is the difference when there is no {} - only lay evaluation ?
Schalk W. Cronjé
@ysb33r
Apr 28 2015 18:19
None, it just reads better
R. Tyler Croy
@rtyler
Apr 28 2015 18:20
:)
Christian Meier
@mkristian
Apr 28 2015 18:20
:)
Christian Meier
@mkristian
Apr 28 2015 18:29
@ysb33r did you see my comment about shadowJar for the jar-plugin. things will not really really work anymore when shadowJar shadows all the embedded jars from jruby-complete.jar or the jars collected from the gem dependencies. so I doubt it is worth keeping it in.
Schalk W. Cronjé
@ysb33r
Apr 28 2015 18:30
Let;s take it out - mention it in the README - and see if anyone complains :)
Schalk W. Cronjé
@ysb33r
Apr 28 2015 20:07
Hey I’m just wondering about the bintray push. Is it still auto-synced to the portal? I'm about to test another plugin with the new gradle plubish plugin
R. Tyler Croy
@rtyler
Apr 28 2015 21:15
if you create a new plugin, you're supposed to push directly to their maven repo
existing plugins are supposed to sync nowadays
the 0.1.16 is their for example @ysb33r