These are chat archives for jruby-gradle/jruby-gradle-plugin

6th
May 2015
R. Tyler Croy
@rtyler
May 06 2015 14:36
appveyor bug eh? I'm glad you're taking the windows testing thing off my plate
@ysb33r is there any way to create an appveyor build that runs on PRs?
rtyler @rtyler feels like we've talked about this before
Schalk W. Cronjé
@ysb33r
May 06 2015 14:37
I thought they’ve added that support now
R. Tyler Croy
@rtyler
May 06 2015 14:38
do you mind if I cut a new release with the new JRuby version, I want to see if I can fix #115 sometime after that
(@shiv123 works with me)
Schalk W. Cronjé
@ysb33r
May 06 2015 14:39
Yip, do that. I’ve got a PR I want to push after that release as well. (BTW #115 might be better resolved inside jar rather than base).
R. Tyler Croy
@rtyler
May 06 2015 14:40
taking a quick look at #113 locally to see if it's something simple real quick just in case
Schalk W. Cronjé
@ysb33r
May 06 2015 14:40
There is a TODO list for jar -> jruby-gradle/jruby-gradle-jar-plugin#40
R. Tyler Croy
@rtyler
May 06 2015 14:40
I saw
R. Tyler Croy
@rtyler
May 06 2015 15:03
alright, 0.1.17 cut
Schalk W. Cronjé
@ysb33r
May 06 2015 16:19
gradle.rb generation on WIndows is broken - definitely
Christian Meier
@mkristian
May 06 2015 16:22
about code generation: I think better I sure jrubyExec can work just fine without any code generation. I did not add it to my PR since it was not part of mandate ;)
Schalk W. Cronjé
@ysb33r
May 06 2015 16:22
:)
Christian Meier
@mkristian
May 06 2015 16:23
maybe it worth to keep jrubyExec and runnable more uniform - regarding on how jruby gets executed
Schalk W. Cronjé
@ysb33r
May 06 2015 16:25
JRubyExec tasks are not supposed to do any code generation by themselves
Christian Meier
@mkristian
May 06 2015 16:26
the gradle.rb is generated !? when is it used ?
Schalk W. Cronjé
@ysb33r
May 06 2015 16:27
It is a convenience file - ask @rtyler about it
R. Tyler Croy
@rtyler
May 06 2015 16:30
it's used for folks that want to do things like, throw binding.pry statements or debugger statements into their jruby execution
it allows you to run a ruby command without having the gradle parent process for the cases where gradle gets in the way
Christian Meier
@mkristian
May 06 2015 16:33
so you are saying that there are cases where forking jruby via "java -jar jruby-complete.jar" is not enough and then you can use gradle.rb
cases with "stdin" involved ?
R. Tyler Croy
@rtyler
May 06 2015 16:45
@mkristian more or less, yes
it's only meant for convenience, it just creates a shell script which will exec jruby-complete with the same classpath that a JRubyExec task would use
Schalk W. Cronjé
@ysb33r
May 06 2015 17:19
DO you want it disabled for Windows or is it suppose to work under Windows (Theoreticallly)?
R. Tyler Croy
@rtyler
May 06 2015 17:59
@ysb33r might as well make it work under windows, I just can't test it
Schalk W. Cronjé
@ysb33r
May 06 2015 18:26
I’ll have a look
Trying to work two issues [1] gradle.rb [2] integrating gradleTest
Schalk W. Cronjé
@ysb33r
May 06 2015 18:57

mmm… it seems that adding

sourceCompatibility = 1.6
targetCompatibility = 1.6

is not working correctly. Totally confused now.

R. Tyler Croy
@rtyler
May 06 2015 19:30
beats the hell out of me :-!
Schalk W. Cronjé
@ysb33r
May 06 2015 19:40
And there’s me preaching to the world that, that is the way to keep compatibility. It’s like WTF, dude??
Schalk W. Cronjé
@ysb33r
May 06 2015 20:11
anyways back to grade.rb. It’s not actually a ruby file, just a shell script
Schalk W. Cronjé
@ysb33r
May 06 2015 20:27
I am going to work around the problem for now - the Windows fix will be more than a 30min job. I am adding an @IgnoreIf into the integration test which will skip it on Windows. The task needs to be expanded to generate a .cmd file when it runs under Windows.
rtyler @rtyler nods
Schalk W. Cronjé
@ysb33r
May 06 2015 20:51
Just waiting for Appveyor and Travis to complete, before I create the PR
Schalk W. Cronjé
@ysb33r
May 06 2015 21:26
Grrr… Appveyor is taking ages. Over an hour since I pushed, and it is still queued.
PR is at #117
Merge at your leisure if you’re happy with it.
rtyler @rtyler takes a looksee