These are chat archives for jruby-gradle/jruby-gradle-plugin

7th
May 2015
Schalk W. Cronjé
@ysb33r
May 07 2015 13:32
@mkristian Any further changes to your PR? I would like to merge it tonight.
Christian Meier
@mkristian
May 07 2015 13:34
@ysb33r will go through the TODO list before tonight
Schalk W. Cronjé
@ysb33r
May 07 2015 13:37
@mkristian No need to complete anything on the TODO list before the merge. We can still work on it afterwards. But if there is anything in there you can get done, then sure I’ll wait for it.
@rtyler I did JRubyExec refactor for #118 over a croissant and h/c at the coffee shop. Just need to do project.jrubyexec now.
R. Tyler Croy
@rtyler
May 07 2015 14:28
heh, that sounds like a nice morning @ysb33r
Schalk W. Cronjé
@ysb33r
May 07 2015 14:29
yah, the bad thing about being freelance is not always knowing where the next money is coming from. The great thing is having the freedom just to do stuff like that :sparkles:
R. Tyler Croy
@rtyler
May 07 2015 14:30
heh
I was kind of surprised to come across some of the older things in the project
"But! Schalk says not to do this!"
Schalk W. Cronjé
@ysb33r
May 07 2015 14:31
LOL! we all have things in the past we have done in a way we know of a better way :)
R. Tyler Croy
@rtyler
May 07 2015 14:32
the initScript in the jar plugin follows a similar deprecated pattern, but I've been thinking about just pushing for a "1.0" API
Schalk W. Cronjé
@ysb33r
May 07 2015 14:37
I think that after ruby-mains we can probably 1.0 base & jar
Christian Meier
@mkristian
May 07 2015 14:52
I am about to file an issue with jrubyExec - with jruby-9.0.0.0.pre2 the script can not require 'yaml' since the classpath does not include snakeyaml-1.14.jar. some problem I can construct with jline-2.1.jar and probably soon other jars
R. Tyler Croy
@rtyler
May 07 2015 14:53
@mkristian we already have that issue filed
#113
at least that sounds like that is the issue!
Christian Meier
@mkristian
May 07 2015 14:54
sorry I did not know. but I would like to fix this
rtyler @rtyler takes a look at the internal backlog
Schalk W. Cronjé
@ysb33r
May 07 2015 15:04
I assume snakeyaml is a requirement only with jruby 9000?
Christian Meier
@mkristian
May 07 2015 15:17
from 9.0.0.0.pre2 psych is default gem and this gem has snakeyaml embedded. dito jline-2.1.jar which gets embedded with stdlib used by readline. and there is at least one more jruby-extension which uses an external jar which would be better to be moved into stdlib as embedded external jar
Schalk W. Cronjé
@ysb33r
May 07 2015 15:19
If I understand this right, then I would suggest that instead of fixing the code for the sake of a jruby pre-release we just put out a note in the README that if you are playing with pre2 to put snakeyaml in the dependency list and give an example.
(the jruby-gradle README that is)
Christian Meier
@mkristian
May 07 2015 15:21
there is no need for adding any jar dependencies including bouncy-castle, just run prepareJRuby and let JARS_HOME point to the directory where the jars got installed. this will work for ALL jruby
Schalk W. Cronjé
@ysb33r
May 07 2015 15:24
if that is the case, what needs fixing?
so jruby get require its embedded jars again
the bouncy-castle becomes obsolete unless you want another version then the one from jruby
the classpath for executing just need the jruby-complete.jar file
and you might want to configure jarsDir in the same manner a gemDir
Christian Meier
@mkristian
May 07 2015 19:42
@ysb33r I did some changes on the README but I wanted to have it in its own commit since I am not the right person to write "text"
also see my comment on jruby-gradle/jruby-gradle-jar-plugin#40
the rest I was not sure how to do it so I left it as is
Schalk W. Cronjé
@ysb33r
May 07 2015 21:21
Cool. Will look at it tonight when I get home.
On gitter for android atm
Schalk W. Cronjé
@ysb33r
May 07 2015 23:46
@rtyler refactoring taking a bit longer - I found a nice way (I think) to share more code between project.jrubyexec and JRubyExec.