These are chat archives for jruby-gradle/jruby-gradle-plugin

29th
Jul 2015
R. Tyler Croy
@rtyler
Jul 29 2015 05:02
welp, found my issue breaking the integration tests pretty easily tihs morning
much easier with fresh eyes
R. Tyler Croy
@rtyler
Jul 29 2015 06:12
only to die on another test
gahh
R. Tyler Croy
@rtyler
Jul 29 2015 06:39
@ysb33r it looks like my tests are failing because private objects in traits and in classes are two different things O_O
the trait setting this.gemWorkDir is different than what will be returned inside of getGemWorkDir() inside JRubyExecAbstractTask
R. Tyler Croy
@rtyler
Jul 29 2015 06:49
@ysb33r I'm not seeing the value in these traits, the more I dig into this, why shouldn't JRubyExecDelegate just extend from JRubyExecAbstractTask?
and all that trait functionality move over?
Schalk W. Cronjé
@ysb33r
Jul 29 2015 07:21
What I would be concerned about is that JRubyExecDelegate inherits a bunch of task stuff that is not applicable
R. Tyler Croy
@rtyler
Jul 29 2015 07:32
right right
@ysb33r so here's what I'm thinking after taking a walk
@ysb33r .JRubyExecTraits has all the functionality for dealing with the gem dir and dependencies, JRubyExecAbstractTask goes away
R. Tyler Croy
@rtyler
Jul 29 2015 12:34
@ysb33r I'm deeper than I wanted to get, but I found #157, and I think I'm going to have to do some more surgery in JRubyExec
I'm thinking that perhaps configuration should be a non-optional parameter, and the jrubyExec$$Foo should go away
Schalk W. Cronjé
@ysb33r
Jul 29 2015 12:44
Remind me what $$Foo does
R. Tyler Croy
@rtyler
Jul 29 2015 12:54
that was just an isolated Configuration
so I've got a compromise that preserves the existing behavior that we have while fixing #157 and reducing overall complexity
by default, JRubyExec tasks use the jrubyExec configuration
if you try to configure jrubyVersion, and configuration == DEFAULT_JRUBYEXEC_CONFIG then we throw an error explaining that you must provide a configuration for isolation purposes (and your own safety really)
(if you want all jrubyExecs to have their own version, setting jruby.execVersion is the right path)
R. Tyler Croy
@rtyler
Jul 29 2015 14:26
WOOHOOO, I have this mostly working!
now time to clean up!
Schalk W. Cronjé
@ysb33r
Jul 29 2015 14:29
right then, so you tomorrow
I’m staying in the Wyndham hotel somewhere in Potsdam
R. Tyler Croy
@rtyler
Jul 29 2015 14:30
during the day @mkristian and i will probably be working at betahaus again
not sure yet though
Schalk W. Cronjé
@ysb33r
Jul 29 2015 14:30
what is betaHaus?
R. Tyler Croy
@rtyler
Jul 29 2015 14:30
coworking space in kreuzberg
I'm still cleaning out the unnceessary stuff from JRubyExec but all the integration tests are now passing
Schalk W. Cronjé
@ysb33r
Jul 29 2015 14:33
Let me know. Flight lands 1005 at TXL. I can hang around in city before goign to hotel. I think I can only check-in at 3pm anyway.
R. Tyler Croy
@rtyler
Jul 29 2015 14:34
will you email me your phone number? I'll text you in the morning
Schalk W. Cronjé
@ysb33r
Jul 29 2015 16:10
how long does it take form the airport to Hauptbahnhof?
R. Tyler Croy
@rtyler
Jul 29 2015 16:33
20ish minutes
depending on whether you have to wait for the bus or not @ysb33r
R. Tyler Croy
@rtyler
Jul 29 2015 17:19
hooray lots of redundant code nuked from project.jrubyexec
Schalk W. Cronjé
@ysb33r
Jul 29 2015 21:05
Looking fwd to see that tomorrow