These are chat archives for jruby-gradle/jruby-gradle-plugin

30th
Jul 2015
R. Tyler Croy
@rtyler
Jul 30 2015 09:16
so JRubyExec allows for executing "jrubyArgs '-S', 'rspec'"
making the script property not mandatory
which I think is a bad API to keep
Christian Meier
@mkristian
Jul 30 2015 09:39
JRubyExec allows to execute -e 'puts 123' - how do you distinguish this from a script/file execution ? adding a inlineSCript property then you can ensure either one is set.
R. Tyler Croy
@rtyler
Jul 30 2015 09:39
if you pass in: jrubyArgs '-e', '"puts 'hello'"' then that should still work
but right now there is a test that allows you to define this task:
task rspec(type: JRubyExec) {
  jrubyArgs '-S', 'rspec'
}
which I want to disallow, so you would have to make:
task rspec(type: JRubyExec) {
  script 'rspec'
}
Schalk W. Cronjé
@ysb33r
Jul 30 2015 09:42
We've been here before...
R. Tyler Croy
@rtyler
Jul 30 2015 09:42
I know, it feels familiar :P
Schalk W. Cronjé
@ysb33r
Jul 30 2015 09:43
I wouldn't worry too much about it
R. Tyler Croy
@rtyler
Jul 30 2015 09:43
you would like to keep that functionality?
I think we can keep it, I want to add an error condition though if '-S' is present, but no script is available for #152 for example
which I think I can do if jrubyArgs.size() == 1 and there's not an inline script
Christian Meier
@mkristian
Jul 30 2015 09:45
I would keep the jrubyArgs parsing simple
R. Tyler Croy
@rtyler
Jul 30 2015 09:45
actually, that's probably not a bad solution for my discomfort with jrubyArgs vs. script
Schalk W. Cronjé
@ysb33r
Jul 30 2015 09:45
I'm happy to give script authors good rope to work, with some safeguards. If they choose to hang themselves ... let it be so
R. Tyler Croy
@rtyler
Jul 30 2015 09:45
heh
@ysb33r I'm conflicted, since when script authors hang themselves at Lookout, I'm the one that suffers :P
Christian Meier
@mkristian
Jul 30 2015 09:48
do see any suffering as long we do not mess up the args, like adding a second -S or so
R. Tyler Croy
@rtyler
Jul 30 2015 09:57
fwiw this commit resolves #152 jruby-gradle/jruby-gradle-plugin@cd222c3
R. Tyler Croy
@rtyler
Jul 30 2015 20:37
@ysb33r stlil awake per chance?