These are chat archives for jruby-gradle/jruby-gradle-plugin

13th
Aug 2015
Schalk W. Cronjé
@ysb33r
Aug 13 2015 05:40
Keeping it in it's own config makes sense.
R. Tyler Croy
@rtyler
Aug 13 2015 15:18
@ysb33r yeah that's the direction I've headed, been working that out still though
the callbacks still need to be present though
Schalk W. Cronjé
@ysb33r
Aug 13 2015 16:29

let me give you some context on a decision I made at the start of these plugins:

I thought at the time that we should have a defaultVersion and an execVersion. The reason was that I thought we would use ‘defaultVersionto assemble/compile against andexecVersion` to run scripts with. I also wanted to be able to run scripts uing different versions of jruby if necessary. I also thought assembly would be used more that script execution

So over time usage patterns arose. Most people were using JRubyExec rather than building stuff. It is only when we tackled JRubyJar with earnest that assembly became a factor again.

Also most people are using defaultVersion and execVersion set to the same version.

Now I am beginning to think that we should merge the two properties and mark one as deprecated. A person that wants to use a different jruby for script always have the option to set it in the JRubyExec configuration.
Christian Meier
@mkristian
Aug 13 2015 16:41
@ysb33r +1 for merging the two properties
Schalk W. Cronjé
@ysb33r
Aug 13 2015 16:47
@rtyler Does TestKit run the compatibility tests in the cloud?
Christian Meier
@mkristian
Aug 13 2015 16:47
@rtyler ther gradle.rb file just needs jruby-complete on the classpath all other jars will be managed by jars/setup - another example where the configuration mixes some dependencies used for the classpath and some not used for the classpath but by jruby itself via jars/setup
R. Tyler Croy
@rtyler
Aug 13 2015 17:02
@ysb33r what do you mean "in the cloud?"
R. Tyler Croy
@rtyler
Aug 13 2015 20:09
@ysb33r want to take a lookt at #188?
rtyler @rtyler is feelin' merge happy
Blane Dabney
@raelik
Aug 13 2015 20:11
@ysb33r also +1 for merging defaultVersion and execVersion
R. Tyler Croy
@rtyler
Aug 13 2015 20:16
@raelik huh?
Schalk W. Cronjé
@ysb33r
Aug 13 2015 20:25
@rtyler I was just wondering whether it works the same as for gradleTest whereby everything is done local with distributions of whether it sends your build into the Gradleware cloud to run against various Gradle versions
R. Tyler Croy
@rtyler
Aug 13 2015 20:26
@ysb33r everything is local
AFAICT
Schalk W. Cronjé
@ysb33r
Aug 13 2015 20:27
@rtyler so there was a piece of code in th PR that utilises json. What was that for?
R. Tyler Croy
@rtyler
Aug 13 2015 20:29
yeah, that's where it's created I liked to where its used
gradletestkit doesn't manage the classpaths for you yet
Schalk W. Cronjé
@ysb33r
Aug 13 2015 20:30
EMI but why do you need JSON for that?
R. Tyler Croy
@rtyler
Aug 13 2015 20:30
it's not super necessary, just an easy way to format a string that I can interpolate into the buildFile later on :P
Blane Dabney
@raelik
Aug 13 2015 20:32
This message was deleted
Ooops
Schalk W. Cronjé
@ysb33r
Aug 13 2015 20:32
@rtyler Can;t just use pure Groovy?
Blane Dabney
@raelik
Aug 13 2015 20:32
@rtyler I was just letting Schalk know I agreed with merging the two properties.
R. Tyler Croy
@rtyler
Aug 13 2015 20:33
@ysb33r it is using pure Groovy?
what do you mean :smile:
Schalk W. Cronjé
@ysb33r
Aug 13 2015 20:33
@rtyler nm
R. Tyler Croy
@rtyler
Aug 13 2015 20:36
alright, I think I'm about to say "fuck testkit"
it looks like they're utilizing a different groovy version outside of my ability to modify or pin
groovy.lang.GroovyRuntimeException: Conflicting module versions. Module [groovy-all is loaded in version 2.3.10 and you are trying to load version 2.3.3
at org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:509)
at org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:77)
at org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:71)
at org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:53)
at org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.<init>(MetaClassRegistryImpl.java:110)
at org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.<init>(MetaClassRegistryImpl.java:71)
at groovy.lang.GroovySystem.<clinit>(GroovySystem.java:33)
 groovy.lang.GroovyRuntimeException: Conflicting module versions. Module [groovy-all is loaded in version 2.3.10 and you are trying to load version 2.3.3
                at org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:509)
                at org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:77)
                at org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:71)
                at org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:53)
                at org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.<init>(MetaClassRegistryImpl.java:110)
                at org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.<init>(MetaClassRegistryImpl.java:71)
                at groovy.lang.GroovySystem.<clinit>(GroovySystem.java:33)
from within an invocation of GradleRunner
OH RIGHT, but nebula plugins don't work on later than 2.2
grrrrrrrrrrrrrrr
rtyler @rtyler smashes the keyboard
Blane Dabney
@raelik
Aug 13 2015 20:42
@rtyler It's kinda funny seeing the notifications for your frustrations pop-up while I watch the talk you gave at JRubyConf.EU :P
R. Tyler Croy
@rtyler
Aug 13 2015 20:42
heh
take a drink every time I touch my head
it's a good way to get drunk
rtyler @rtyler facepalms
Blane Dabney
@raelik
Aug 13 2015 20:42
I'll die of alcohol poisoning
R. Tyler Croy
@rtyler
Aug 13 2015 20:43
:beers:
Schalk W. Cronjé
@ysb33r
Aug 13 2015 20:43
i didn’t notice
R. Tyler Croy
@rtyler
Aug 13 2015 20:43
when I watched afterwards, I certainly did
Blane Dabney
@raelik
Aug 13 2015 20:44
There's a bit of head touching, I was exaggerating a bit
R. Tyler Croy
@rtyler
Aug 13 2015 20:45
always room for improvement I suppose :)
@ysb33r this is the saddest code I've written all week integrationTestCompile files(gradleTestKit().resolve().findAll { File f -> !f.name.matches(/groovy-all-(.*).jar/) } )
but it works
:crying_cat_face:
Schalk W. Cronjé
@ysb33r
Aug 13 2015 20:51
what are you trying to achieve ?
R. Tyler Croy
@rtyler
Aug 13 2015 20:51
building for 2.0 compat while using 2.6 features
PR updated
let's see if this sucker passes
Schalk W. Cronjé
@ysb33r
Aug 13 2015 20:54
my head’s flat now, don’t think I can write it shorter for you
R. Tyler Croy
@rtyler
Aug 13 2015 20:55
no worries
I'm sufficiently happy with this now, the way Gradle handles its own dependency tree is:
  1. hidden entirely from the user
  1. freakin' nuts
rtyler @rtyler runs gradleTest locally
R. Tyler Croy
@rtyler
Aug 13 2015 20:58
I need a 16GB laptop, ETOOMANYJVMS
@ysb33r @raelik I'll throw a deprecation warning in on jruby.execVersion when I get back to updating #189
R. Tyler Croy
@rtyler
Aug 13 2015 21:29
#188 is green, any objections to me merging?