These are chat archives for jruby-gradle/jruby-gradle-plugin

29th
Sep 2015
Schalk W. Cronjé
@ysb33r
Sep 29 2015 08:06
but I think I need to go the org.gradle.api.internal.artifacts.repositories.transport.RepositoryTransport route to get it work. @ysb33r once gave me some pointers and those are exactly the ones I will need
That was what I was thinking
rtyler @rtyler wabves
Schalk W. Cronjé
@ysb33r
Sep 29 2015 15:07
I don’t have much time to look at this as I need to prepare presnetations and workshops for Bangalore where I am next week.
rtyler @rtyler nods
R. Tyler Croy
@rtyler
Sep 29 2015 15:34
@mkristian let me know what I can help with today, otherwise I'll be tinkering more with shrinkwrap
Christian Meier
@mkristian
Sep 29 2015 15:36
right now I just need to see how the "s3" protocol stuff is implemented in gradle and copy these. the "file" protocol is handle in special case but it would be very close to what I need.
guess you can tinker with shrinkwrap
R. Tyler Croy
@rtyler
Sep 29 2015 15:36
heh, hokay
Christian Meier
@mkristian
Sep 29 2015 15:36
is there already a solution with not fiddling with the extension classloader ?
R. Tyler Croy
@rtyler
Sep 29 2015 15:37
no not yet, neither the gradle nor jboss community has been terribly helpful on IRC :/
R. Tyler Croy
@rtyler
Sep 29 2015 17:58
WOOT!
I think I've solved the jrubydir issue
utilizing the transformer support in the shadow plugin
I've basically proven that this will work separate from the plugin, now I need to see if we can utilize just the ShadowCopyAction from the shadow plugin in the jar plugin
R. Tyler Croy
@rtyler
Sep 29 2015 19:13
found a bug in the groovy compiler
just my luck
Christian Meier
@mkristian
Sep 29 2015 19:26
@rtyler great that you found a way to fix those .jrubydir files :)
R. Tyler Croy
@rtyler
Sep 29 2015 20:01
@mkristian I did, if I could only get it to compile though :)
@mkristian let me gist you my experiment build.gradle
Christian Meier
@mkristian
Sep 29 2015 20:01
ok
that adds the .jrubydir files at jar generation time
the problem I'm having is that the ShadowCopyAction unzips the nested jars, so I've got to override that a bit
Christian Meier
@mkristian
Sep 29 2015 20:08
looks good. next step is to remove the temp dir and do this in memory. which is possible now
R. Tyler Croy
@rtyler
Sep 29 2015 20:09
well, I've got to get this code into the plugin first ;)
THEN we can talk about optimizations :)
Christian Meier
@mkristian
Sep 29 2015 20:10
sure
R. Tyler Croy
@rtyler
Sep 29 2015 20:10
this does bring the shadow plugin as a runtime dependency, unfortunately
but we might be able to work with john to get this code separated into a lbirary at some point
Christian Meier
@mkristian
Sep 29 2015 20:12
reuse existing code sounds OK
R. Tyler Croy
@rtyler
Sep 29 2015 20:13
unfrotunately due to this compiler bug I found I do have to copy and paste a bunch :()
Christian Meier
@mkristian
Sep 29 2015 20:15
if you put the code into its own groovy file. does it produce the same error ? nothing too fancy what you are doing
R. Tyler Croy
@rtyler
Sep 29 2015 20:16
@mkristian the compiler error is with 100% groovy, no gradle context
Christian Meier
@mkristian
Sep 29 2015 20:16
oh :(
R. Tyler Croy
@rtyler
Sep 29 2015 20:18
@mkristian pull request coming your way shortly
plz stand by
R. Tyler Croy
@rtyler
Sep 29 2015 20:27
@mkristian #244 is there and I still need to update some code in JRubyJarCopyAction with documentation and details, but I wanted to get that there for you to look at ASAP
Christian Meier
@mkristian
Sep 29 2015 20:38
this already avoid the unpacking of nested jars - does it ?
R. Tyler Croy
@rtyler
Sep 29 2015 20:41
yes, it avoids it
that's why the JRUbyJarCopyAction is copy pasted, because I couldn't subclass to override that behavior because of the compiler bug
Christian Meier
@mkristian
Sep 29 2015 20:42
I see
R. Tyler Croy
@rtyler
Sep 29 2015 21:19
GAHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHh
that Gradle 2.2 fuck up of the Jar bytecodes is causing me quite a bit of grief now