These are chat archives for jruby-gradle/jruby-gradle-plugin

1st
Oct 2015
Blane Dabney
@raelik
Oct 01 2015 00:04
Just an observation, it's all up on jcenter and is working
R. Tyler Croy
@rtyler
Oct 01 2015 02:53
@raelik what do you mean on github?
rtyler @rtyler pushes the tag
R. Tyler Croy
@rtyler
Oct 01 2015 13:59
@ysb33r @mkristian I'm thinking of releasing a 1.1.4 to include the .jrubydir bug fixes
since we've got a lot more work to do before 1.2.0
Schalk W. Cronjé
@ysb33r
Oct 01 2015 14:43
That 1.1.4 is a complex fix I see
R. Tyler Croy
@rtyler
Oct 01 2015 14:47
indeed
Christian Meier
@mkristian
Oct 01 2015 15:03
I think it is worth including the .jrubydir fix as it is subtle bug and hard to find when your app gets bitten by it
R. Tyler Croy
@rtyler
Oct 01 2015 15:05
I've cherry picked #248 with that
I cna release from the office once I get in if it looks good
i've got this long standing branch which brings lots of codenarc rules in
we've got a rather messy codebase here since @mkristian and I learned roovy with it :p
Schalk W. Cronjé
@ysb33r
Oct 01 2015 15:07
I would like to clean up that code you brought in sometime - not quite so happy re-adding the Shadow dependency just because of that. However, it fixes the issue for now, for 1.1.4 shoudl go out I guess.
R. Tyler Croy
@rtyler
Oct 01 2015 15:08
@ysb33r I agree with you, unfrotunately this is a very missing API in Gradle's core classes IMO
I think the right long term solution is for a library to be made for mutating Jar's on the fly with these private APIs
that shadow and jruby-gradle could both use
I think it can also be cut down a lot more
R. Tyler Croy
@rtyler
Oct 01 2015 15:41
@ysb33r are you okay with me merging #248?
rtyler @rtyler understands you're busy
Schalk W. Cronjé
@ysb33r
Oct 01 2015 15:54
Yip
Christian Meier
@mkristian
Oct 01 2015 17:35
@ysb33r @rtyler I try to understand what is going on. so gradle does already uses all those schemes configured via META-INF/services files when resolving the jruby-gradle-base jar. it does not look like gradle looks for this services inside plugins.
Schalk W. Cronjé
@ysb33r
Oct 01 2015 17:52
@mkristian AFAIK as long as the jar is on the class path, then then service loader should be able to pick it up. No need to do some special in the plugin apply to force gradle to load the service.
Christian Meier
@mkristian
Oct 01 2015 17:53
but it is a plugin "classpath" not the application classpath which contains gradle. I push the current code since it is easier to point to
so it is this file https://github.com/mkristian/jruby-gradle-plugin/blob/mavengem/jruby-gradle-base-plugin/src/main/resources/META-INF/services/org.gradle.internal.service.scopes.PluginServiceRegistry which tells gradle where to find the MavenGemResourcesPluginServiceRegistry and all those Resource and ResourceConnector, etc
but I am not sure if gradle does look for those PluginServiceRegistry inside a plugin jar
Schalk W. Cronjé
@ysb33r
Oct 01 2015 18:48
I'll have a look, but it might be worthwhile to take this issue to the gradle-dev mailing list.
Christian Meier
@mkristian
Oct 01 2015 18:48
just posted it on the forum. will do the mailing list as well
R. Tyler Croy
@rtyler
Oct 01 2015 22:29
omg codenarc is inconsistent
R. Tyler Croy
@rtyler
Oct 01 2015 22:44
so annoying trying to fix these style woes just to deal with an inconsistent result from codenarc :/
R. Tyler Croy
@rtyler
Oct 01 2015 23:08
sometimes codenarc also just hangs and takes 400% CPU
rtyler @rtyler grumbles