These are chat archives for jruby-gradle/jruby-gradle-plugin

19th
Sep 2016
Schalk W. Cronjé
@ysb33r
Sep 19 2016 13:11

I've also now run into a more critical issue in the jar build:

Caused by: java.lang.NoClassDefFoundError: org/apache/tools/zip/ZipOutputStream
    at com.github.jrubygradle.jar.JRubyJar.getInternalCompressor(JRubyJar.groovy:314)
    at com.github.jrubygradle.jar.JRubyJar_Decorated.getInternalCompressor(Unknown Source)
    at com.github.jrubygradle.jar.JRubyJar.createCopyAction(JRubyJar.groovy:304)

and

Caused by: java.lang.ClassNotFoundException: org.apache.tools.zip.ZipOutputStream
    at java.net.URLClassLoader$1.run(URLClassLoader.java:372)
    at java.net.URLClassLoader$1.run(URLClassLoader.java:361)
Christian Meier
@mkristian
Sep 19 2016 13:13
is it using a different version of some dependencies ?
Schalk W. Cronjé
@ysb33r
Sep 19 2016 13:22

It probably is and I suspect it is something related to it being built with Gradle 3.0/3.1, which is part of my eventual PR. Having said that the issue happens with Gradle 2.8 onwards and therefore probably related to certain parts of the Grsdle API no longer being exposed.

Also I know that John has said that a number of later Gradle releases have broken Shadow and he had to implement some fixes.

Maybe what I can do is to look at what the functionality is here and see if I can come up with a solution.
Schalk W. Cronjé
@ysb33r
Sep 19 2016 13:35
@mkristian Do you actually need the whole of the Shadow plugin or just the bits you have copy-pasted?
Christian Meier
@mkristian
Sep 19 2016 14:08
yes, @rtyler used shadow as blueprint
Schalk W. Cronjé
@ysb33r
Sep 19 2016 14:22
Should I remove the compile dependency on Shadow?
Schalk W. Cronjé
@ysb33r
Sep 19 2016 14:36
Leaving that question open for the moment, I just need to mention that the issue I am seeing is due to Ant not being available on the classpath. Not sure yet whether it is just am issue with the test or whether we'll see this issue in the field. Will get there eventually to test.
Christian Meier
@mkristian
Sep 19 2016 14:56
we might need the shadow dependency - I am really not sure here. oh this zip stuff comes from ant - thought ant is integral to gradle
Schalk W. Cronjé
@ysb33r
Sep 19 2016 14:58
True, but it is taking the Ant dependency from Shadow's transitive dependencies. I have fixed that now - was a spelling error. However now stuck at
Caused by: java.lang.ClassNotFoundException: org.objectweb.asm.commons.Remapper
    at java.net.URLClassLoader$1.run(URLClassLoader.java:372)
    at java.net.URLClassLoader$1.run(URLClassLoader.java:361)
Missing Remapper.
Christian Meier
@mkristian
Sep 19 2016 15:00
it this related to jruby ? with jruby we put those asm library into their own package org.jruby.org.objectweb.asm to avoid conflicts but sometimes problem pop up with wrong jruby builts
Schalk W. Cronjé
@ysb33r
Sep 19 2016 15:02
my codebase is effectively latest jrubygradle release with my gradleTest changes
Christian Meier
@mkristian
Sep 19 2016 15:03
should be fine as all come from released versions then - just needed to mention it.
Schalk W. Cronjé
@ysb33r
Sep 19 2016 15:10
I might have solved the problem (maybe only temporarily)
Schalk W. Cronjé
@ysb33r
Sep 19 2016 15:20
Looks like I have everything to build and test now and passing from Gradle 2.0-3.1. Just need to fix the documentation build.
Schalk W. Cronjé
@ysb33r
Sep 19 2016 16:19
I've done PR #283
R. Tyler Croy
@rtyler
Sep 19 2016 18:47
@ysb334 "Gradle 1.0-beta4" do you mean GradleTest 1.0 or what?