These are chat archives for jruby-gradle/jruby-gradle-plugin

5th
May 2019
Schalk W. Cronjé
@ysb33r
May 05 10:28
Finished all the unittests yesterday and now working through the integration tests in base.
Cleaned up a lot of stuff so far. Can also run and debug the integration tests in IntelliJ (Well at least the ones I can converted already).
Schalk W. Cronjé
@ysb33r
May 05 10:42
image.png
Typical functional test now running with a lots of verbose output
Schalk W. Cronjé
@ysb33r
May 05 16:30
@rtyler #347: a present for you
R. Tyler Croy
@rtyler
May 05 16:39
presents, I love presents!
Schalk W. Cronjé
@ysb33r
May 05 16:41
There is still a failing test or so; will look into that now, but that is a relatively big PR to look at.
R. Tyler Croy
@rtyler
May 05 16:43
it's a codenarc thing, which I was just fixing
I'm going to push a commit to your branch, and then we should be good to go
R. Tyler Croy
@rtyler
May 05 16:50
somehow I keep upgrading machines, but these tests still seem to take foever :P
R. Tyler Croy
@rtyler
May 05 17:03
@ysb33r do you have any thoughts on the contents of https://github.com/jruby-gradle/jruby-gradle-plugin/milestone/27 ?
Schalk W. Cronjé
@ysb33r
May 05 17:24
@rtyler I could probably add some more to that milestone

somehow I keep upgrading machines, but these tests still seem to take foever

I just invested in a 32GB i7 laptop

R. Tyler Croy
@rtyler
May 05 17:26
nice!
I'm chugging along with this Dell 13" XPS from last year, it's mostly doing well :)
because of my height, I need a 13" laptop in order to be able to use it on the train or bus :P
Schalk W. Cronjé
@ysb33r
May 05 17:36
I also have a 13" (bought it from slimbook.es)
BTW I am going to push a second PR shortly, just with codenarc cleanup. Among things I have added a nicety whereby you can run ./gradlew -i codenarcMain codenarcTest codenarcIntTest in the IntelliJ terminal and it provides you with clickable links to where the issues are in source code
R. Tyler Croy
@rtyler
May 05 17:39
neat
so this is you right now I presume? https://slimbook.es/images/new/katana-2/katana-2-01.jpg
I get emails for build failures regularly :P
Schalk W. Cronjé
@ysb33r
May 05 18:06
I did not order the Katana, I have the Pro2 13" with QHD didsplay
R. Tyler Croy
@rtyler
May 05 18:08
I am contacting the maintainers of rubygems.org to see if we can convince them to host a rubygems-servlets docker container for us or something
Schalk W. Cronjé
@ysb33r
May 05 18:15
:+1:
I'm looking at your #348 issue now
R. Tyler Croy
@rtyler
May 05 18:19
oky, I'm working on #319
Schalk W. Cronjé
@ysb33r
May 05 18:21
Yeah, throw out 1.7. We did it a while ago in Asciidoctor land and it saves huge swaths of pain.
Schalk W. Cronjé
@ysb33r
May 05 18:30
@rtyler I left a comment on #348. There is no real issue there, just make the single change that I suggested and the test shall pass.
Schalk W. Cronjé
@ysb33r
May 05 20:45
For some reasons the appveyor builds are not showing up in my portal
I guess the only solution will be to run it locally in a VM
R. Tyler Croy
@rtyler
May 05 21:56
that's weird, they're under your account
because appveyor is weird, I get email notifications for build failures on your other projects too :P
Schalk W. Cronjé
@ysb33r
May 05 21:57
It is the only project on Appveyor that I have for which it happens
R. Tyler Croy
@rtyler
May 05 21:59
wacky