@headius, better reproduction with a non-1-line stacktrace at the updated https://gist.github.com/fidothe/5247bb8236e6dcd42d6bbc1d1b63ad2f
Will file an issue. Not sure there's a simpler reproduction than to clone my project and grab the external JAR, alas.
@fidothe Thank you!
@donv It seems like jruby-complete jars started snapshotting again 🤷♂️
@headius @enebo I don't know if anyone is tackling #5905, but it looks like something I could tackle in a reasonable time. Looking the code over, it seems fairly straightforward. The main thing I don't really understand is the role of RubyString's
gsubFast - the only use of that I can find is in RubyDate.java, which uses a Regexp, so it's not directly affected by behaviour that uses a string pattern arg.
Yeah gsub fast may not be used by this logic...but I suppose it could be?
I think I linked the MRI commit that made this optimization in that bug, so that would be a good rough template to follow (even though this logic isn't a line-for-line port)
is this expected behavior?
I've been setting up my machine for hacking on #5905, and I have a couple of questions. just running
mvn complains about the .polyglot.pom.rb, ./mvnw is fine, and ./mvnw -Pbootstrap runs fine, but ./mvn still complains after. (This is on JDK 1.8 on macOS 10.14) Is this expected? I ran jruby -S rake spec:ruby:fast which reported 3 failures and 2 errors (Signal.list redefines CLD with CHLD if defined FAILED, plus some networking stuff that seems like it might be a platform thing). I can see that's not happening in the last Travis build. Is that expected/a problem?
for MRI Ruby
So that looks like a bug
I wish notifications worked on here
@fidothe What's the complain? I think you might be hitting a recent Maven bug :-(
3.6.4 or something broke polyglot maven
I think if you delete pom.rb it will work fine since we keep the pom.xml up to date too
@fidothe takari/polyglot-maven#200
Looks like it's probably just a bug in Exception#inspect
can you file it please?
I hate to bail on gitter but it's interfering with work now
logs from test runs on both 1.8u131 and 1.8u222 here: https://gist.github.com/fidothe/dc10bee69950dbe69ca35fb46b68f8dd
I'm trying to patch a Jenkins plugin this way: http://dpaste.com/2NNQW49 However, the following results in
My first question is: which way is the correct way? With the
GitParameterPluginAvailable always set to false. Instead, if I prepend the java class name with Java. I get the following backtrace: http://dpaste.com/1SX9VK9My first question is: which way is the correct way? With the
Java. prefix or without it?
To close the loop here, not much difference;
include Java would trigger require 'java' if it had not already been loaded, but in all recent JRuby versions it's already there. The difference comes in where you actually include; whatever module you include Java into will gain some peculiar side effects of our module/package logic that lives in the Java module.
Recommendation is to avoid
include Java now, and use require 'java' only as future-proofing in case we don't load it by default some day.
I gave them an example piece of code, I guess I also need to generate an example app 🙄
hopefully this is enough
Friendly reminder for folks still here... we will continue to monitor, but Gitter has not been maintained and notifications are unreliable (I don't get them at all). We've moved our official chat room to Matrix, since it's active, FOSS, and bridges very well to IRC. You can join us via https://matrix.to/#/#jruby:matrix.org