Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 16:49
    mistergibson opened #6455
  • 11:48
    mistergibson commented #6453
  • Oct 30 20:03
    headius commented #6454
  • Oct 30 20:01
    headius commented #6453
  • Oct 30 19:42
    headius commented #6451
  • Oct 30 19:36
    headius commented #5896
  • Oct 30 19:26
    headius commented #5896
  • Oct 30 19:21
    headius commented #6451
  • Oct 30 19:09
    headius commented #6449
  • Oct 30 19:08
    headius commented #6450
  • Oct 30 18:45
    headius milestoned #6450
  • Oct 30 18:45
    headius commented #6450
  • Oct 30 01:58
    LoganBarnett opened #6454
  • Oct 29 22:41
    mistergibson commented #6453
  • Oct 29 22:19
    mistergibson commented #6453
  • Oct 29 16:26
    godfat closed #6449
  • Oct 29 16:26
    godfat commented #6449
  • Oct 29 13:07
    kares closed #6409
  • Oct 29 12:32
    godfat commented #6449
  • Oct 29 11:07
    mistergibson opened #6453
Charles Oliver Nutter
@headius
I think I linked the MRI commit that made this optimization in that bug, so that would be a good rough template to follow (even though this logic isn't a line-for-line port)
jlahtinen
@jlahtinen
jruby-9.2.8.0 :006 > e = Exception.new('å'); puts "#{e} - #{e.inspect}"
å - #<Exception: Ã¥>
is this expected behavior?
Matt Patterson
@fidothe
I've been setting up my machine for hacking on #5905, and I have a couple of questions. just running mvn complains about the .polyglot.pom.rb, ./mvnw is fine, and ./mvnw -Pbootstrap runs fine, but ./mvn still complains after. (This is on JDK 1.8 on macOS 10.14) Is this expected? I ran jruby -S rake spec:ruby:fast which reported 3 failures and 2 errors (Signal.list redefines CLD with CHLD if defined FAILED, plus some networking stuff that seems like it might be a platform thing). I can see that's not happening in the last Travis build. Is that expected/a problem?
Blane Dabney
@raelik
@jlahtinen The normal behavior is that inspect returns a string that uses the default system encoding.
for MRI Ruby
Blane Dabney
@raelik
That said, I tried that on my jRuby and got the same result, whereas MRI 2.5.3 does what you would expect: å - #<Exception: å>
So that looks like a bug
Charles Oliver Nutter
@headius
hey hey
I wish notifications worked on here
@fidothe What's the complain? I think you might be hitting a recent Maven bug :-(
3.6.4 or something broke polyglot maven
I think if you delete pom.rb it will work fine since we keep the pom.xml up to date too
@jlahtinen That is a bug
Looks like it's probably just a bug in Exception#inspect
can you file it please?
Ghost
@ghost~5377c1e9048862e761fa1c25
@headius are you relying on the app for notifications? This app seems to be getting worse over time even with no updates!
Charles Oliver Nutter
@headius
Yeah they actually replied to my complaint and pointed to an unfixed bug they know about
Ghost
@ghost~5377c1e9048862e761fa1c25
I think some developer has installed a slow-burn self-destruct in it
Charles Oliver Nutter
@headius
I don't remember getting notifications for months and months
I hate to bail on gitter but it's interfering with work now
Matt Patterson
@fidothe
@headius - getting exactly the error described in that issue filed on polyglot-maven
Matt Patterson
@fidothe
@headius / @enebo should I be opening issues for test failures on a new checkout? (I don't yet understand what impact these maven issues might have on the tests, so I'm hesitant)
Matt Patterson
@fidothe
(fwiw, I force-downgraded maven to 3.5.4, don't get complaints about polyglot anymore, and still get 3 failures and 2 errors)
Matt Patterson
@fidothe
although i realise that the JDK 1.8 version I have installed outside weird macOS system java thing is 1.8u131. Trying again with 1.8u222 from AdoptOpenJDK
Matt Patterson
@fidothe
logs from test runs on both 1.8u131 and 1.8u222 here: https://gist.github.com/fidothe/dc10bee69950dbe69ca35fb46b68f8dd
Ghost
@ghost~5377c1e9048862e761fa1c25
I think I've been in this room since the start, but I'm heading off now as it's the last room I'm on Gitter for and it's becoming increasingly painful. Catch me on Twitter or the GraalVM Slack room or something if you need me.
Andrea Scarpino
@ilpianista_gitlab
I'm trying to patch a Jenkins plugin this way: http://dpaste.com/2NNQW49 However, the following results in GitParameterPluginAvailable always set to false. Instead, if I prepend the java class name with Java. I get the following backtrace: http://dpaste.com/1SX9VK9
My first question is: which way is the correct way? With the Java. prefix or without it?
Andrea Scarpino
@ilpianista_gitlab
which is the difference between require 'java' and include Java?
Charles Oliver Nutter
@headius
To close the loop here, not much difference; include Java would trigger require 'java' if it had not already been loaded, but in all recent JRuby versions it's already there. The difference comes in where you actually include; whatever module you include Java into will gain some peculiar side effects of our module/package logic that lives in the Java module.
Recommendation is to avoid include Java now, and use require 'java' only as future-proofing in case we don't load it by default some day.
jlahtinen
@jlahtinen
jruby/jruby-rack#217 who would know something about this?
Uwe Kubosch
@donv
@headius Are on this: https://issuetracker.google.com/issues/138705083 They want more info...
Charles Oliver Nutter
@headius
Ah yes
I gave them an example piece of code, I guess I also need to generate an example app 🙄
Charles Oliver Nutter
@headius
got it
hopefully this is enough
Charles Oliver Nutter
@headius
Friendly reminder for folks still here... we will continue to monitor, but Gitter has not been maintained and notifications are unreliable (I don't get them at all). We've moved our official chat room to Matrix, since it's active, FOSS, and bridges very well to IRC. You can join us via https://matrix.to/#/#jruby:matrix.org
There is a Gitter bridge for Matrix, but it has never worked well enough for us to enable it. Hopefully that will change in the future, but you'll get a quicker response if you use IRC (Freenode, #jruby) or Matrix.
That is all...carry on!
Charles Oliver Nutter
@headius
@donv Fixed for future Android 10+ builds, apparently!
Charles Oliver Nutter
@headius
Whoever it was that fixed it is apparently interested in seeing more Android JRuby apps, so that's interesting
Charles Oliver Nutter
@headius
@donv If it's possible for us to detect android we could commit the invoke/invokeExact patch to JRuby, I suppose
it's bothersome that this fix won't go into earlier versions but I'd like to start reducing that patch set
Uwe Kubosch
@donv
@headius Yes, this looks good. Reducing the patch set is the next task, and making a maven package for easy consumption.
@headius I looked at matrix. What client do you use?
Charles Oliver Nutter
@headius
I use the Riot electron app, it works pretty well
oh I'll answer there