jscs-dev/node-jscs

JavaScript Code Style checker - JSCS has merged with ESLint!

Jonathan Neal

@jonathantneal

Sindresorhus is recommending to add the configuration in the CLI like:

jscs --config=node_modules/jscs-xo/jscsrc

Oleg Gaidarenko

@markelog

That could work too

in package.json you can use same thing

{
    "jscsConfig": {
        "preset": "your-config"
    }
}

Jonathan Neal

@jonathantneal

Awesome, and the present name, would I need to use jscs-config-10up or 10up? I’m okay with either, just asking what the preference is because

You can also omit the eslint-config- and it will be automatically assumed by ESLint (cite)

Oleg Gaidarenko

@markelog

yep

any of the jscs-, jscs-config-,jscs-preset- would work

Jonathan Neal

@jonathantneal

Awesome.

Well done, everyone who worked on this! @hzoo, awesome to see you in here, btw. I love Gitter. Thanks for all your work on jscs.

Oleg Gaidarenko

@markelog

He is the man :)

Jonathan Neal

@jonathantneal

:+1: agreed :+1:

Okay, so now I have almost everything set. https://github.com/jscs-dev/node-jscs/wiki/Creating-a-Custom-Preset-or-Config is great. I’d like to add a test to my project. Some JS file that passes if all my rules are applied. I have the file ready, but is there a recommended way to setup the test?

For instance, I have added to my package.json:

"scripts": {
  "test": "jscs test.js"
}

Henry Zhu

@hzoo

thanks @jonathantneal - not here as often but glad to help

Oleg Gaidarenko

@markelog

check out the wikimedia preset - https://github.com/wikimedia/jscs-preset-wikimedia

Jonathan Neal

@jonathantneal

If I also define in package.json that "main": ".jscsrc" then I guess my test can be as simple as "test": "jscs test.js"

Oleg Gaidarenko

@markelog

they followed our recommendations, so it should be pretty connonical

didn’t tried like that, should work though

Jonathan Neal

@jonathantneal

I kinda like it because it lets people steal the file if they don’t want to buy into the preset.

Jonathan Neal

@jonathantneal

Thanks @markelog. Great resources. That totally got me exactly where I needed to be.

Oleg Gaidarenko

@markelog

Great to hear!

Teo Stocco

@zifeo

Hey guys! After looking some times for the rule enforcing space between args and body in arrow functions (valid x => x, not valid x=>x) I did not find any yet. Is there any trick using another rule for having this done? Thanks :D

Oleg Gaidarenko

@markelog

Hey, nope, no tricks, it would be easy to create a rule for it though

Teo Stocco

@zifeo

Okay, thanks will have a look how to do this!

Oleg Gaidarenko

@markelog

Released - https://twitter.com/jscs_dev/status/705116961437523968
Re-tweet, love and all that :-)

Zach Sosana

@SOSANA

hey guys really enjoy jscs but having problems with it not picking up my eslint file, for example in eslint we set max-len to 180 characters but my atom ide still says errors for 100 max characters

{
  "extends": "airbnb",
  "parser": "babel-eslint",
  "env": {
    "browser": true,
    "node": true,
    "mocha": true,
   },
   "ecmaFeatures": {
    "jsx": true,
    "es6": true,
    "classes": true,
   },
   "rules": {
     "comma-dangle": [1, "always-multiline"],
     "max-len": [1, 180, 4],
     "arrow-body-style": [0],
   },
}

Zach Sosana

@SOSANA

am I missing something? shouldn't it be picking my eslint file automatically?

Oleg Gaidarenko

@markelog

jscs and eslint two different projects, eslint doesn’t read jscs config and vice versa

Zach Sosana

@SOSANA

awww thanks @markelog

for eslint projects you know of any atom plugins to use?

Oleg Gaidarenko

@markelog

https://github.com/AtomLinter/linter-eslint i guess

Zach Sosana

@SOSANA

thanks @markelog for your help

Oleg Gaidarenko

@markelog

Charlie Robbins

@indexzero

@markelog @hzoo @mrjoelkemp some really interesting behavior for CST and ambiguous rule parsing

jscs-dev/node-jscs#2161
jscs-dev/node-jscs#2162

I’m trying to reproduce the ambiguous auto-fixing reported by some folks on my team, but I’m unsure how to write a test with auto-fix enabled, are there other examples in the code?

Oleg Gaidarenko

@markelog

@indexzero will check it out on the weekend, you sure you testing it against the 3.0 right?

since 2.x doesn't have cst

Ciprian Mocanu

@nikini

hi.. I'm new in this group. How can I request a new rule?

Where do I do that? Sorry, but I did not find that in the "contributing" page

Oleg Gaidarenko

@markelog

Check this out http://jscs.info/contributing

Ciprian Mocanu

@nikini

I looked there, but I can only see clear instructions on how to contribute yourself by making the rule yourself, but not by putting it on a board somehwere and somebody pick it up

There are rules how to do your commits, how to work on it, but it's unclear how to propose a new rule, without actually developing it yourself

Oleg Gaidarenko

@markelog

see http://jscs.info/contributing#proposing-features

“If it's a new rule that you're proposing:"

Ciprian Mocanu

@nikini

I see that, but where do I write it? Here?

Oleg Gaidarenko

@markelog

oh, you mean what bug-tracker do we use

github issues

Ciprian Mocanu

@nikini

aaah. okok.. thanks :smile: - I don't know why I didn't think to post there

Oleg Gaidarenko

@markelog

ok, glad i could help

Jonas Pauthier

@Nargonath

Hello guys! Is there any interactions between jscs and editorconfig? I mean if I set my preset to google which has 2 spaces indentation and I work on the project with an .editorconfig that specifies 4 spaces indentation, will it fire errors everywhere as I'm not respecting google preset requirements or will it update its requirements locally?

Where communities thrive

People

Repo info

Activity