Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 20 2018 03:40
    666don commented #2289
  • Aug 11 2017 16:16
    coveralls commented #1895
  • Jul 20 2017 14:45
    cashburn commented #2268
  • Jul 20 2017 14:45
    cashburn commented #2268
  • Jun 15 2017 11:14

    markelog on master

    Tests: handle error messages wi… (compare)

  • Apr 28 2017 14:00
    dasdany closed #2295
  • Apr 28 2017 14:00
    dasdany commented #2295
  • Apr 28 2017 14:00
    dasdany closed #2294
  • Apr 28 2017 14:00
    dasdany commented #2294
  • Apr 28 2017 13:59
    dasdany commented #2294
  • Apr 28 2017 13:57
    dasdany opened #2295
  • Apr 28 2017 13:33
    bboydflo commented #2294
  • Apr 28 2017 08:39
    dasdany opened #2294
  • Mar 17 2017 01:42
    coveralls commented #1500
  • Dec 19 2016 16:38
    KeithPepin-MW commented #1501
  • Dec 19 2016 16:38
    KeithPepin-MW commented #1501
  • Dec 19 2016 16:38
    KeithPepin-MW commented #1501
  • Dec 19 2016 16:37
    KeithPepin-MW commented #1501
  • Dec 19 2016 16:17
    KeithPepin-MW commented #1501
  • Dec 19 2016 16:15
    KeithPepin-MW commented #1501
Oleg Gaidarenko
@markelog
github issues
Ciprian Mocanu
@nikini
aaah. okok.. thanks :smile: - I don't know why I didn't think to post there
Oleg Gaidarenko
@markelog
ok, glad i could help
Jonas Pauthier
@Nargonath
Hello guys! Is there any interactions between jscs and editorconfig? I mean if I set my preset to google which has 2 spaces indentation and I work on the project with an .editorconfig that specifies 4 spaces indentation, will it fire errors everywhere as I'm not respecting google preset requirements or will it update its requirements locally?
Oleg Gaidarenko
@markelog
Hey, no interactions, two independent projects
Jonas Pauthier
@Nargonath
Yeah I know that they are independent but I wondered if jscs was "aware" of editorconfig. Would it seem relevant to have such a behavior in jscs?
Oleg Gaidarenko
@markelog
I would say no, better to be separated i think
Jonas Pauthier
@Nargonath
Can we modify jscs config locally for a project, pretty much as a .jscsrc or something alike?
so we could work on project with different coding style that our default without having all the code base in red.
Oleg Gaidarenko
@markelog
@Nargonath not sure i understand, jscs config is .jscsrc file, you can modify as you like, or you can change .editorconfig
Jonas Pauthier
@Nargonath
@markelog Perhaps I'm a bit confused as I'm not using jscs directly but through the Atom's plugin. I cannot change the .editorconfig because I'm not the one who decides it settings.
@markelog Looking at the local node-jscs project I have, I don't have any errors in the files even though my default preset is "google" and the editorconfig specifies 4 spaces indent style. The only difference with the previous project I mentioned is that it has the .jscsrc. I think that's what was missing from it. I got my answer. Sorry for disturbing. :)
Is there a doc that mentions the .jscsrc? Didn't find any :/. Perhaps I didn't look good enough.
Oleg Gaidarenko
@markelog
Yeah, it is all over http://jscs.info/overview
np :)
John Daniel Pray
@jpray
Hi, I'm trying to lint and fix code that has decorators. Using "esnext": true works when running jscs, but when running jscs fix, it errors on the decorator. Anyone know what might be going on here?
Oleg Gaidarenko
@markelog
you probably need to post this on https://github.com/jscs-dev/node-jscs/issues
John Daniel Pray
@jpray
ok, thanks for the feedback.
Alexsey
@Alexsey
Hello. Is there a way to forbid usage of unknown global variables?
Oleg Gaidarenko
@markelog
nope, it is kinda hard to detect globals
Alexsey
@Alexsey
@markelog it's a pity :( thanks for reply
Yuval
@ValYouW
Hi, will you accept a PR for jscs-dev/node-jscs#2197 ?
Oleg Gaidarenko
@markelog
@ValYouW: hey, yeah, we would
Yuval
@ValYouW
@markelog Thx, will try to work on it soon...
Cristian Tudorache
@denim2x
I just pushed a fix for #73 - it doesn't have any docs yet but all relevant tests pass
Cristian Tudorache
@denim2x
the 'excludeFiles' option stays the same - only this time .jscsignore files are taken into account also (both global and local)
@indexzero I'd be really grateful if you could take a moment to review my PR
Charlie Robbins
@indexzero
@denim2x could you link me it?
@markelog @mrjoelkemp @hzoo @zxqfox could anyone point me to where in the JSCS code it reads and writes back files before & after auto-fixing?
Charlie Robbins
@indexzero
I found an interesting bug: a side effect of auto-fixing another item causes escaped html (e.g. < to be unescaped in the fixed file)
Charlie Robbins
@indexzero
Yea, this specifically has to do with JSX
Charlie Robbins
@indexzero
Seems to be an esprima bug
Cristian Tudorache
@denim2x
@indexzero #2203
and gitkeeper
Yuval
@ValYouW
@markelog jscs-dev/node-jscs#2202
Please let me know what you think
Oleg Gaidarenko
@markelog
@indexzero in master or in 2.x?
@ValYouW i will, right now there is a lot to do, i probably check it out today or maybe tomorrow
thanks for the pull btw
Charlie Robbins
@indexzero
@markelog 2.11.0 looks to be a babylon bug exposed through babel-jscs. The AST node has the raw value (e.g. '&LA;
*'<'
But the TOKEN has the unescaped value
And I can't figure out where the token is created from the node
Oleg Gaidarenko
@markelog
oh, we use parser tokenizer
so it should be from there
i.e. yeah, it should be babylon behaviour
Charlie Robbins
@indexzero
@markelog @hzoo logged the bug as best I could determine it against babel-jscs. I don’t know if this is fixed in the 3.0.0-beta, but hopefully this gives you the information to see if this edge case persists as we move to babylon@6
jscs-dev/babel-jscs#25
Oleg Gaidarenko
@markelog
@indexzero thanks!
Charlie Robbins
@indexzero
No problem. This is such a mind$%^& I hope you can figure it out