Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 20 2018 03:40
    666don commented #2289
  • Aug 11 2017 16:16
    coveralls commented #1895
  • Jul 20 2017 14:45
    cashburn commented #2268
  • Jul 20 2017 14:45
    cashburn commented #2268
  • Jun 15 2017 11:14

    markelog on master

    Tests: handle error messages wi… (compare)

  • Apr 28 2017 14:00
    dasdany closed #2295
  • Apr 28 2017 14:00
    dasdany commented #2295
  • Apr 28 2017 14:00
    dasdany closed #2294
  • Apr 28 2017 14:00
    dasdany commented #2294
  • Apr 28 2017 13:59
    dasdany commented #2294
  • Apr 28 2017 13:57
    dasdany opened #2295
  • Apr 28 2017 13:33
    bboydflo commented #2294
  • Apr 28 2017 08:39
    dasdany opened #2294
  • Mar 17 2017 01:42
    coveralls commented #1500
  • Dec 19 2016 16:38
    KeithPepin-MW commented #1501
  • Dec 19 2016 16:38
    KeithPepin-MW commented #1501
  • Dec 19 2016 16:38
    KeithPepin-MW commented #1501
  • Dec 19 2016 16:37
    KeithPepin-MW commented #1501
  • Dec 19 2016 16:17
    KeithPepin-MW commented #1501
  • Dec 19 2016 16:15
    KeithPepin-MW commented #1501
Yuval
@ValYouW
@markelog Thx, will try to work on it soon...
Cristian Tudorache
@denim2x
I just pushed a fix for #73 - it doesn't have any docs yet but all relevant tests pass
Cristian Tudorache
@denim2x
the 'excludeFiles' option stays the same - only this time .jscsignore files are taken into account also (both global and local)
@indexzero I'd be really grateful if you could take a moment to review my PR
Charlie Robbins
@indexzero
@denim2x could you link me it?
@markelog @mrjoelkemp @hzoo @zxqfox could anyone point me to where in the JSCS code it reads and writes back files before & after auto-fixing?
Charlie Robbins
@indexzero
I found an interesting bug: a side effect of auto-fixing another item causes escaped html (e.g. < to be unescaped in the fixed file)
Charlie Robbins
@indexzero
Yea, this specifically has to do with JSX
Charlie Robbins
@indexzero
Seems to be an esprima bug
Cristian Tudorache
@denim2x
@indexzero #2203
and gitkeeper
Charlie Robbins
@indexzero
https://github.com/jscs-dev/node-jscs/pull/2203#issuecomment-208542455
Yuval
@ValYouW
@markelog jscs-dev/node-jscs#2202
Please let me know what you think
Oleg Gaidarenko
@markelog
@indexzero in master or in 2.x?
@ValYouW i will, right now there is a lot to do, i probably check it out today or maybe tomorrow
thanks for the pull btw
Charlie Robbins
@indexzero
@markelog 2.11.0 looks to be a babylon bug exposed through babel-jscs. The AST node has the raw value (e.g. '&LA;
*'<'
But the TOKEN has the unescaped value
And I can't figure out where the token is created from the node
Oleg Gaidarenko
@markelog
oh, we use parser tokenizer
so it should be from there
i.e. yeah, it should be babylon behaviour
Charlie Robbins
@indexzero
@markelog @hzoo logged the bug as best I could determine it against babel-jscs. I don’t know if this is fixed in the 3.0.0-beta, but hopefully this gives you the information to see if this edge case persists as we move to babylon@6
jscs-dev/babel-jscs#25
Oleg Gaidarenko
@markelog
@indexzero thanks!
Charlie Robbins
@indexzero
No problem. This is such a mind$%^& I hope you can figure it out
I could not figure out how onTokens get populated by babylon in bable-jscs@2.0.5, but I can see that @hzoo is using in the 3.0.0-beta
Charlie Robbins
@indexzero
@hzoo I meant to say you’re using a different technique than onToken in babel-jscs@3.0.0-beta
Cristian Tudorache
@denim2x
@indexzero Question: shall I make the global or local .jscsignore files optional (in the CLI for instance)?
Charlie Robbins
@indexzero
Yes, a .jscsignore would always be optional. But if it exists in the local directory it would be used implicitly. Just like a .gitignore
Ivan Pukhtin
@StreetStrider
Is it possible to run jscs over .json and --fix errors?
Oleg Gaidarenko
@markelog
@StreetStrider nope

Released - https://twitter.com/jscs_dev/status/720667941499441152

Re-tweet, love and all that :-)

Ivan Pukhtin
@StreetStrider
Owww
Andrea Sonny
@andreasonny83
cool
Jonas Pauthier
@Nargonath
Just read the article you wrote on Medium @markelog. Had a little heartache while reading it. It must be hard to let your baby goes that way guys. Thanks all for the hard work you put into that project to make it what it is today. Thanks as well for your help towards little contributors as I.
Thomas Grainger
@graingert
JSCS 3.0.3 seems to generate spurious error messages and break my webpack build.
jscs-dev/node-jscs#2226
Alexej Yaroshevich
@zxqfox
;-(
Oleg Gaidarenko
@markelog
@Nargonath thank you for the kind words :)
Thomas Grainger
@graingert
welp http://jscs.info is down
@markelog ^
Oleg Gaidarenko
@markelog
oh well, it seems domain wasn’t extended
Alexej Yaroshevich
@zxqfox
Looks like fine atm
hm
Oleg Gaidarenko
@markelog
dns info probably didn't come to you yet
Alexej Yaroshevich
@zxqfox
ye, looks like ;-(
Thomas Grainger
@graingert
@markelog https://www.whatsmydns.net/#NS/jscs.info
Oleg Gaidarenko
@markelog
looks like there was some complications with payment, it took to long to pass through