These are chat archives for jsoxford/jsoxford.github.com

11th
Aug 2015
Marcus Noble
@AverageMarcus
Aug 11 2015 09:35
@spikeheap mind taking a look at #157 ?
Marcus Noble
@AverageMarcus
Aug 11 2015 10:43
@spikeheap something really screwy is going on with Travis
Ryan Brooks
@spikeheap
Aug 11 2015 10:44
@AverageMarcus how so? I checked the build after your comment on the PR, but it looks like it succeeded. Seems odd.
Marcus Noble
@AverageMarcus
Aug 11 2015 10:47
Expand the grunt output and take a look at uncss
Looks like the previous one was failing too
#60 was the last that was actually successful
In that it was the last that deployed to master
Ryan Brooks
@spikeheap
Aug 11 2015 10:50
But the new posts have been merged and deployed successfully
Marcus Noble
@AverageMarcus
Aug 11 2015 10:50
Yeah, they were earlier builds
It's still using fontawesome and not svgs
Ryan Brooks
@spikeheap
Aug 11 2015 10:51
#60 was back in March
Marcus Noble
@AverageMarcus
Aug 11 2015 10:51
Sorry, I meant Travis build #60
Ryan Brooks
@spikeheap
Aug 11 2015 10:51
Ah ok
So we just need to unmerge The SVG PR and that should fix the build...
Let’s try it
I’ve reverted the merge and reopened the branch. it’s building now
Ryan Brooks
@spikeheap
Aug 11 2015 11:01
Argh, right, @AverageMarcus UnCSS uses Phantom to figure out what CSS isn’t used. it looks like that’s having issues running the containers, so we’ll need to keep running on the legacy infrastrcture.
Marcus Noble
@AverageMarcus
Aug 11 2015 11:02
But I'm not sure what the issue with SVG PR is then as that was before the container
Ryan Brooks
@spikeheap
Aug 11 2015 11:02
Yeah that’s a separate problem, which looks like it masked the containers problem. Fun times!
Marcus Noble
@AverageMarcus
Aug 11 2015 11:04
Yeah
It might be imagemin not liking the new icons?
Ryan Brooks
@spikeheap
Aug 11 2015 11:04
quite possibly. Should be reproducable locally though
Marcus Noble
@AverageMarcus
Aug 11 2015 11:05
Possibly
I never saw any issues locally but not don't recall it I ran the optimzation task
Marcus Noble
@AverageMarcus
Aug 11 2015 11:10
That has deployed
This is a little odd though...
Running "cssmin:dist" (cssmin) task
File _site/css/style.css created: 165.29 kB → 171.64 kB
Ryan Brooks
@spikeheap
Aug 11 2015 12:10
Nice :)