Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Apr 30 2015 13:28

    jtf323 on master

    New screenshot (compare)

  • Apr 28 2015 12:37

    jtf323 on master

    Games in progress are in Cyan (compare)

  • Apr 28 2015 12:34

    jtf323 on master

    Swapped the winner / underway c… (compare)

  • Apr 27 2015 22:05
    jtf323 closed #9
  • Apr 27 2015 22:04

    jtf323 on master

    Final update to colours Colour… Merge pull request #12 from stv… (compare)

  • Apr 27 2015 22:04
    jtf323 closed #12
  • Apr 27 2015 22:01
    stvhwrd opened #12
  • Apr 27 2015 21:41
    stvhwrd closed #11
  • Apr 27 2015 21:21
    stvhwrd opened #11
  • Apr 27 2015 15:41
    jtf323 reopened #9
  • Apr 24 2015 15:01

    jtf323 on v1.0

    (compare)

  • Apr 24 2015 14:57

    jtf323 on master

    Very minor formatting changes (compare)

  • Apr 24 2015 14:42

    jtf323 on master

    Cleaner argument parsing (compare)

  • Apr 24 2015 14:27

    jtf323 on master

    Updated README.md (compare)

  • Apr 24 2015 14:25

    jtf323 on master

    Added today only flag, added he… (compare)

  • Apr 24 2015 14:03

    jtf323 on master

    Added functions to fix locale /… (compare)

  • Apr 24 2015 13:51

    jtf323 on master

    Update screenshot and readme (compare)

  • Apr 23 2015 23:01

    jtf323 on master

    Small fix (compare)

  • Apr 23 2015 22:57

    jtf323 on master

    Updated colors (compare)

  • Apr 23 2015 12:55

    jtf323 on master

    Minor formatting changes (compare)

John Freed
@jtf323
FYI I fixed a bug where games in progress displayed as final
Stevie Howard
@stvhwrd
Hi! Cool script. I made a few changes to it. I'm new to the whole world of GitHub and all that so I don't know exactly what the etiquette is...
I forked it and pushed all the changes. What would you have preferred for me to do? Submit pull requests? Or... yeah. Not sure. Total newbie here so any suggestions would be appreciated!
John Freed
@jtf323
Hey I just saw your pull request, awesome changes!
And yeah that's 100% cool, I love when other people throw in their ideas! The only thing I'm going to change is that I'm going to use colorama for coloring the text since ANSI escape character sequences don't work on Windows. It should keep everything the same for Mac/Linux and just add Windows support basically
Thanks again for all the improvements!
Stevie Howard
@stvhwrd
Awesome! I've never contributed before so this is great for me! Thanks for accepting my changes. Learning lots as I go.
John Freed
@jtf323
Not a problem, I haven't contributed much to anyone else's repositories either, it's usually a little daunting haha
Loving your changes though, nice work!
Stevie Howard
@stvhwrd
Yeah it is! It felt like I was stepping on your toes at first.. haha
I guess you could always not merge the changes though if you didn't like the way it was going. Then the other person could just continue developing their own fork. All this stuff is just so novel to me, I love it
Stevie Howard
@stvhwrd
I should have a few changes after a live trial tonight and then be done with it.
John Freed
@jtf323
No problem! I actually ran into an issue when I played with it last night. Montréal is playing today and apaprently Colorama doesn't play nice with non-ascii characters ("é")
I tried stripping them out as a temporary solution which prevents it from crashing but then colorama stops working after the team name is printed (Even though it's printed without the é)
Stevie Howard
@stvhwrd
Yeah I did too. I added another filter just like the leafs and blue jackets ones. If "Canadiens" in team name then locale is Montreal. It's cheap and dirty but I couldn't get the accent aigu to print at all.
Stevie Howard
@stvhwrd
Still crashing today using the stripping method? I haven't had any crashing
Stevie Howard
@stvhwrd
Submitted pull request to fix Montreal crash
John Freed
@jtf323
Thanks! That works perfectly for fixing the crash. Colorama still isn't happy though (I'm testing on Windows at the moment)
None of the coloring works after Montreal gets displayed
I tried calling init() again without any luck =/
Stevie Howard
@stvhwrd
Screen Shot 2015-04-22 at 9.48.39 AM.png
John Freed
@jtf323
Damn you Windows :(
I think colorama uses the ansi escape characters for non-windows OSes which would make sense that it would work
Stevie Howard
@stvhwrd
In the script we have no colouring for games that are upcoming. It's just a coincidence that there's no colour after the word "Montreal". What are you seeing?
I made the teams blue for testing in screenshot
What I mean is that by coincidence, there should be no expected colour after "montreal"
John Freed
@jtf323
Ah gotcha!
I was thinking upcoming were still yellow I think
Stevie Howard
@stvhwrd
G
Stevie Howard
@stvhwrd
What is up with colorama?! Suddenly doesn't like Montréal (again)
John Freed
@jtf323
I think it's ok actually, I was playing with some stuff and I think I printed something like "Montréal Canadiens" all in color and it was unhappy, it seems to be ok as long as the string with unicode characters isn't in any color
Stevie Howard
@stvhwrd
That's strange! No problem printing in colour on Mac:
blob
This message was deleted
This message was deleted
This message was deleted
Stevie Howard
@stvhwrd
Do you think it's worthwhile to have the series score in there? Say, after the scoreline print Capitals wins series 4 - 3 or Blackhawks lead series 1-0 for example..?
Stevie Howard
@stvhwrd

How do we feel about this add:

Screen Shot 2015-04-27 at 11.40.57 PM.png

"next game" only shows up in the absence of —today-only

John Freed
@jtf323
Ohh that would be a cool addition!
Both the series score and "Next game" label